public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: devel@edk2.groups.io
Cc: Laszlo Ersek <lersek@redhat.com>,
	Jian J Wang <jian.j.wang@intel.com>, Hao Wu <hao.a.wu@intel.com>,
	Ray Ni <ray.ni@intel.com>, Star Zeng <star.zeng@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Dandan Bi <dandan.bi@intel.com>
Subject: [PATCH V3 0/8] make mExitBootServicesEvent static
Date: Fri, 26 Apr 2019 09:03:56 +0800	[thread overview]
Message-ID: <20190426010404.20624-1-zhichao.gao@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740

V1:
The DebugLib instances of DebugPortProtocol, ConOut and StdErr
use a global variable "mExitBootServicesEvent" which is in
conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So change the
name to the "mDebugLibExitBootServicesEvent".

V2:
Abandon v1.
Add a 'static' descriptor to the global variables that only
used in a single file to minimize the name collisions.
This is only for the variable named 'mExitBootServicesEvent'.

V3:
Update the commit message and some copyright date.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>

Zhichao Gao (8):
  MdePkg/UefiDebugLibConOut: make global variable static
  MdePkg/UefiDebugLibDebugPortProtocol: make global variable static
  MdePkg/UefiDebugLibStdErr: make global variable static
  IntelFrameworkModulePkg: make global variable static
  MdeModulePkg/FirmwarePerformanceDxe: make global variable static
  IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make global variable static
  IntelFrameworkModulePkg: make global variable static
  MdeModulePkg/StatusCodeHandlerRuntimeDxe: make global variable static

 .../SmmRuntimeDxeSupport.c                                    | 4 ++--
 .../DatahubStatusCodeHandlerDxe/DatahubStatusCodeHandlerDxe.c | 4 ++--
 IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 4 ++--
 .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c  | 4 ++--
 .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.c                  | 4 ++--
 MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c       | 2 +-
 .../UefiDebugLibDebugPortProtocol/DebugLibConstructor.c       | 2 +-
 MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c       | 2 +-
 8 files changed, 13 insertions(+), 13 deletions(-)

-- 
2.21.0.windows.1


             reply	other threads:[~2019-04-26  1:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26  1:03 Gao, Zhichao [this message]
2019-04-26  1:03 ` [PATCH V3 1/8] MdePkg/UefiDebugLibConOut: make global variable static Gao, Zhichao
2019-04-26  1:03 ` [PATCH V3 2/8] MdePkg/UefiDebugLibDebugPortProtocol: " Gao, Zhichao
2019-04-26  1:03 ` [PATCH V3 3/8] MdePkg/UefiDebugLibStdErr: " Gao, Zhichao
2019-04-26  1:04 ` [PATCH V3 4/8] IntelFrameworkModulePkg: " Gao, Zhichao
2019-04-26  1:04 ` [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: " Gao, Zhichao
2019-04-26  5:58   ` [edk2-devel] " Wu, Hao A
2019-04-26  8:11     ` Gao, Zhichao
2019-04-26  8:30       ` Wu, Hao A
2019-04-26 19:37         ` Laszlo Ersek
2019-04-26  1:04 ` [PATCH V3 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: " Gao, Zhichao
2019-04-26  1:36   ` Chiu, Chasel
2019-04-26  1:04 ` [PATCH V3 7/8] IntelFrameworkModulePkg: " Gao, Zhichao
2019-04-26  1:04 ` [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: " Gao, Zhichao
2019-04-26  6:00   ` Wu, Hao A
2019-04-26 19:37 ` [PATCH V3 0/8] make mExitBootServicesEvent static Laszlo Ersek
2019-04-28  1:30   ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190426010404.20624-1-zhichao.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox