From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=exKi2R8O;
 spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by groups.io with SMTP; Fri, 26 Apr 2019 04:10:42 -0700
Received: by mail-wr1-f67.google.com with SMTP id h4so3894873wre.7
        for <devel@edk2.groups.io>; Fri, 26 Apr 2019 04:10:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=2L1dTfLYvDNELajz8NHICGugC/ig83WgAYTGWtGbDGs=;
        b=exKi2R8OLQLfKPXT6N3MJjfSq/3TGimZupD4qYNevmEq1D+j/QVYlmLeK6FlKmOV+5
         +TngD8Fc9+eK79MfGhro900nCb2Gc6Pzjw2Kj88yPY2uREq5KWiznAdglK0j7qLBbXwt
         Z9gZNRLzkD4H5WrrZnuLHfAtXcwFKqwnnJiyYydGTThNrndt5pRLxbGq0EHJTO4xsbmJ
         6cbT0y0wsqPuVWjvtabckRstwhgH1458J/IR+4sYCCaqQg3ewDT80U0rD5YcOfosY2qi
         eH3nhFulF2LVlSMEmvn9ENEmzmmXgFbZY4ydJxoxgmOVfp8CBbPrmyNDyTJqHV0WR4A7
         4/qw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=2L1dTfLYvDNELajz8NHICGugC/ig83WgAYTGWtGbDGs=;
        b=gSY00aELCJTapZPWIJcyNqJkzhae3NszdVqYh7Q31FefwydIBhCaE50DXY5VZUWFvF
         gvoyMKtIIOCPuHUQCO4ka2Wo+mH3Ki5zvh+BCTr26mbjXNWJShfo18QSLTrLcNIuN0pd
         SKpL7snEx0xBaAgxOMeuOF55ByVBW4WWe1ETNGiv+qiH+WxD6PuUl+CfXhyysgsLahSQ
         BVgmjKtA5BkDExZbBk9egOLNSnIBEJmjA7rjJPpHdr6psD/G6q1+Y3qzEKQyVJ1P2gSF
         RatKjED9K7WFVF41CzA8bU0ZbvnyOxoArPXUM8NCeVmRfbk+p0EOYqsxlUwvTi0I1LQy
         Flbw==
X-Gm-Message-State: APjAAAVEkYebnlmvkMYiuTribjufJYKI8X+2LnGJ3zXNP1A81UGHcM4I
	l/aodlpdB/QzH2qANnW5MXQwIA==
X-Google-Smtp-Source: APXvYqysGQ7cZg0a+ERjKNzXrWVNSzj+RjRvgsRXkQW+5DLPNXZpY/UxusfFZsEYOYp+Iw/MgkO62w==
X-Received: by 2002:a5d:538c:: with SMTP id d12mr5555004wrv.138.1556277040766;
        Fri, 26 Apr 2019 04:10:40 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id r10sm9489996wrr.65.2019.04.26.04.10.39
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Fri, 26 Apr 2019 04:10:39 -0700 (PDT)
Date: Fri, 26 Apr 2019 12:10:37 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: devel@edk2.groups.io, graeme.gregory@linaro.org,
	masahisa.kojima@linaro.org
Subject: Re: [PATCH edk2-platforms 0/3] enable Secure96 GPIO LEDs on ACPI systems
Message-ID: <20190426111037.6sh764d7phgxn5xn@bivouac.eciton.net>
References: <20190425123254.16396-1-ard.biesheuvel@linaro.org>
MIME-Version: 1.0
In-Reply-To: <20190425123254.16396-1-ard.biesheuvel@linaro.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 25, 2019 at 02:32:51PM +0200, Ard Biesheuvel wrote:
> This series plumbs in the support for describing 96boards mezzanines
> via ACPI. For now, only the GPIO LEDs are described: in the future,
> I intend to wire up the I2C and SPI parts as well, but these are
> currently untested and so not ready for review.
> 
> Note that this applies onto
> 
> Silicon/SynQuacer: add ACPI description of GPIO controller and power button
> 
> which I sent out earlier today.

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

I do have a separate comment on 3/3, but the series is not gated on that.

> Ard Biesheuvel (3):
>   Silicon/SynQuacer: describe 96boards LS connector GPIOs via ACPI
>   Platform/96Boards: add ACPI support to mezzanine/LS connector driver
>   Platform/Secure96Dxe: add ACPI description of the GPIO LEDs
> 
>  Platform/96Boards/Include/Protocol/Mezzanine.h        |  21 ++++
>  Platform/96Boards/LsConnectorDxe/LsConnectorDxe.c     |  35 ++++---
>  Platform/96Boards/LsConnectorDxe/LsConnectorDxe.inf   |   1 +
>  Platform/96Boards/Secure96Dxe/Secure96.asl            | 103 ++++++++++++++++++++
>  Platform/96Boards/Secure96Dxe/Secure96Dxe.c           |  59 ++++++++++-
>  Platform/96Boards/Secure96Dxe/Secure96Dxe.inf         |   1 +
>  Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf |  14 +++
>  Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl       |  20 ++++
>  8 files changed, 238 insertions(+), 16 deletions(-)
>  create mode 100644 Platform/96Boards/Secure96Dxe/Secure96.asl
> 
> -- 
> 2.20.1
>