From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=yH0LDzzT; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 26 Apr 2019 07:17:42 -0700 Received: by mail-wm1-f68.google.com with SMTP id c1so4010955wml.4 for ; Fri, 26 Apr 2019 07:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Efslxbi+fWgxF56HzGNrl8ay62dJauzY1ciG22ZUIyQ=; b=yH0LDzzTamnHLKEo1M83qKEd2iFIk2n8D8PiGv7h9RXqy3pqKFLesWoT8ZIR6PPBsI 8lJePILT9eMnLveqZnSyTie51jPh+5cFbmTL+YuySKrogqYbOg9j9Rfa/UwKVvgA+KRw 2t8npLD7vRhYe66yBkQ70f06LUfX/4cHfgN2EOGD4v6N2wTcY3c3UoocXaZh4/Sjyfwy eBThedvbGr0vGjK2n0v4pRukZUTJCoWxkRvcJtihepX6WrRqseznE2XOWpKM54YPLBLl 1uN7bR7sjq+cSPG4q34htBK7DVG8E8jag/CtZ8cKW6jBPLGgffeAfD9TAbol/bBcQhMX u6rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Efslxbi+fWgxF56HzGNrl8ay62dJauzY1ciG22ZUIyQ=; b=q38v9/K09Cxtx9BQ+PBNL/sZ1NMCPcv8BZJDVhclwHMrtDkQ7Cl1fG0X55Up/e/xo7 ZVnEb7YgbF9aED+w+4JwBPU0fFxtpAa/0I8m8RKvf6DtP4wxb6rr9IUZMU3ofVzPMOcI uwPZGVt4CnmiTAaij6Wfimo2H+QpdsMA0FNbPjW6uZdulLMIcmbxR8+FL+JPNrvDftDj 0JaAHnkq+5g4R1yE3TbMYevS/30ka+pq4jo1O+8tYmINeaAzY2hA8GjDUEFwYi2GeF6V 6aM4O3O54G0atEdbKyOr2b2CdAuT25cMC45ZrLjexg5GRJnzzIEHdjV3Lz+84a8Um3nZ U7ww== X-Gm-Message-State: APjAAAXm3F0J5bgp5/9orZo5rg0NNeSDxekFOby/0kTIY+lbOlBR/lBH ijTRStLZUhW9FWWB7SRtqjVjBA== X-Google-Smtp-Source: APXvYqx48p+6KziiihRi3Vi4Cl4ttC1AnLzr1i9PnWymq/2VzNt5XExWCaomjMwh+qqbiYUWssQlww== X-Received: by 2002:a1c:2743:: with SMTP id n64mr6197114wmn.19.1556288261138; Fri, 26 Apr 2019 07:17:41 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d18sm8402055wrx.56.2019.04.26.07.17.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 07:17:39 -0700 (PDT) Date: Fri, 26 Apr 2019 15:17:38 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io , Graeme Gregory , Masahisa Kojima Subject: Re: [PATCH edk2-platforms 3/3] Platform/Secure96Dxe: add ACPI description of the GPIO LEDs Message-ID: <20190426141738.q4gm4s3jbrj42mib@bivouac.eciton.net> References: <20190425123254.16396-1-ard.biesheuvel@linaro.org> <20190425123254.16396-4-ard.biesheuvel@linaro.org> <20190426111610.w5cnegxjn66paavb@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 26, 2019 at 01:56:54PM +0200, Ard Biesheuvel wrote: > On Fri, 26 Apr 2019 at 13:16, Leif Lindholm wrote: > > > > On Thu, Apr 25, 2019 at 02:32:54PM +0200, Ard Biesheuvel wrote: > > > Wire up the new 96boards mezzanine SSDT loading support, and use it > > > to describe the four GPIO LEDs on the Secure96 mezzanine board. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel > > > --- > > > Platform/96Boards/Secure96Dxe/Secure96.asl | 103 ++++++++++++++++++++ > > > Platform/96Boards/Secure96Dxe/Secure96Dxe.c | 59 ++++++++++- > > > Platform/96Boards/Secure96Dxe/Secure96Dxe.inf | 1 + > > > 3 files changed, 158 insertions(+), 5 deletions(-) > > > > > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.asl b/Platform/96Boards/Secure96Dxe/Secure96.asl > > > new file mode 100644 > > > index 000000000000..bb9dac462a33 > > > --- /dev/null > > > +++ b/Platform/96Boards/Secure96Dxe/Secure96.asl > > > @@ -0,0 +1,103 @@ > > > +/** @file > > > + * Copyright (c) 2019, Linaro Limited. All rights reserved. > > > + * > > > + * This program and the accompanying materials are licensed and made > > > + * available under the terms and conditions of the BSD License which > > > + * accompanies this distribution. The full text of the license may be > > > + * found at http://opensource.org/licenses/bsd-license.php > > > + * > > > + * THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > > + * WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > > > + * IMPLIED. > > > + */ > > > + > > > +#include "Secure96.h" > > > + > > > +DefinitionBlock ("Secure96.aml", "SSDT", 2, "LINARO", "SECURE96", 1) > > > +{ > > > + External (\_SB.LS96.GPIO) > > > + > > > + Scope (_SB) > > > + { > > > + Device (LD96) > > > + { > > > + Name (_HID, "PRP0001") // _HID: Hardware ID > > > + Name (_UID, 0x00) // _UID: Unique ID > > > + Name (_DSD, Package () { > > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > > > > Surely the above stanza is the most repeated bit of boiler plate in > > the entire tree? I count 207 instances before this goes in. > > Can we stick a #define in some common header for this and reuse? > > ACPI_DSD_UUID? > > > > As I said, not required for this patch, but would be worth addressing. > > > > We should add the GUID to MdePkg, given that it occurs in the ACPI spec. Yeah. What form would be practically consumable by .asl? / Leif