From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 26 Apr 2019 17:53:59 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88CB8307027C; Sat, 27 Apr 2019 00:53:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-104.rdu2.redhat.com [10.10.121.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 795F15D70A; Sat, 27 Apr 2019 00:53:57 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall Subject: [PATCH 08/16] OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. specifiers Date: Sat, 27 Apr 2019 02:53:20 +0200 Message-Id: <20190427005328.27005-9-lersek@redhat.com> In-Reply-To: <20190427005328.27005-1-lersek@redhat.com> References: <20190427005328.27005-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Sat, 27 Apr 2019 00:53:59 +0000 (UTC) Content-Transfer-Encoding: quoted-printable The GetExact(), GetSettings(), PrintSettings() functions are only called from within "EnrollDefaultKeys.c", and none of them take variable arguments. Drop their EFIAPI calling convention specifiers. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1747 Signed-off-by: Laszlo Ersek --- OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c b/OvmfPkg/Enro= llDefaultKeys/EnrollDefaultKeys.c index be0e4d8f8e96..671efef8d6ad 100644 --- a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c +++ b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c @@ -806,17 +806,16 @@ Out: VendorGuid, Status); } return Status; } =20 =20 STATIC EFI_STATUS -EFIAPI GetExact ( IN CHAR16 *VariableName, IN EFI_GUID *VendorGuid, OUT VOID *Data, IN UINTN DataSize, IN BOOLEAN AllowMissing ) { @@ -850,17 +849,16 @@ typedef struct { UINT8 SecureBoot; UINT8 SecureBootEnable; UINT8 CustomMode; UINT8 VendorKeys; } SETTINGS; =20 STATIC EFI_STATUS -EFIAPI GetSettings ( OUT SETTINGS *Settings ) { EFI_STATUS Status; =20 Status =3D GetExact (EFI_SETUP_MODE_NAME, &gEfiGlobalVariableGuid, &Settings->SetupMode, sizeof Settings->SetupMode, FALSE); @@ -889,17 +887,16 @@ GetSettings ( =20 Status =3D GetExact (EFI_VENDOR_KEYS_VARIABLE_NAME, &gEfiGlobalVariabl= eGuid, &Settings->VendorKeys, sizeof Settings->VendorKeys, FALSE); return Status; } =20 STATIC VOID -EFIAPI PrintSettings ( IN CONST SETTINGS *Settings ) { AsciiPrint ("info: SetupMode=3D%d SecureBoot=3D%d SecureBootEnable=3D%= d " "CustomMode=3D%d VendorKeys=3D%d\n", Settings->SetupMode, Settings->= SecureBoot, Settings->SecureBootEnable, Settings->CustomMode, Settings->VendorKe= ys); } --=20 2.19.1.3.g30247aa5d201