public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments
@ 2019-04-28  2:25 Gao, Zhichao
  2019-04-28  8:02 ` Wang, Jian J
       [not found] ` <1599949D48F01C54.4588@groups.io>
  0 siblings, 2 replies; 3+ messages in thread
From: Gao, Zhichao @ 2019-04-28  2:25 UTC (permalink / raw)
  To: devel; +Cc: Jian Wang, Ting Ye

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1736

For accroding with the doxygen special documention blocks
in section 2.3.5, removing the blank line in the file comments
of the file header for PeiCryptLib.inf

Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Ting Ye <ting.ye@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
index 0166f0b360..415dda3078 100644
--- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
+++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
@@ -15,7 +15,6 @@
 #
 #  Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
-
 #
 ##
 
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments
  2019-04-28  2:25 [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments Gao, Zhichao
@ 2019-04-28  8:02 ` Wang, Jian J
       [not found] ` <1599949D48F01C54.4588@groups.io>
  1 sibling, 0 replies; 3+ messages in thread
From: Wang, Jian J @ 2019-04-28  8:02 UTC (permalink / raw)
  To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Ye, Ting



Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Sunday, April 28, 2019 10:26 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the
> comments
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1736
> 
> For accroding with the doxygen special documention blocks
> in section 2.3.5, removing the blank line in the file comments
> of the file header for PeiCryptLib.inf
> 
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> index 0166f0b360..415dda3078 100644
> --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> @@ -15,7 +15,6 @@
>  #
>  #  Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> -
>  #
>  ##
> 
> --
> 2.21.0.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments
       [not found] ` <1599949D48F01C54.4588@groups.io>
@ 2019-04-29  9:08   ` Wang, Jian J
  0 siblings, 0 replies; 3+ messages in thread
From: Wang, Jian J @ 2019-04-29  9:08 UTC (permalink / raw)
  To: devel@edk2.groups.io, Wang, Jian J, Gao, Zhichao; +Cc: Ye, Ting

Pushed at 038f929c921c3b6f2fb47a79f0e89caa0ed649c0

Regards,
Jian


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Sunday, April 28, 2019 4:02 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Ye, Ting <ting.ye@intel.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank
> line in the comments
> 
> 
> 
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> 
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Sunday, April 28, 2019 10:26 AM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> > Subject: [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the
> > comments
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1736
> >
> > For accroding with the doxygen special documention blocks
> > in section 2.3.5, removing the blank line in the file comments
> > of the file header for PeiCryptLib.inf
> >
> > Cc: Jian Wang <jian.j.wang@intel.com>
> > Cc: Ting Ye <ting.ye@intel.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > index 0166f0b360..415dda3078 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > @@ -15,7 +15,6 @@
> >  #
> >  #  Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > -
> >  #
> >  ##
> >
> > --
> > 2.21.0.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-29  9:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-28  2:25 [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments Gao, Zhichao
2019-04-28  8:02 ` Wang, Jian J
     [not found] ` <1599949D48F01C54.4588@groups.io>
2019-04-29  9:08   ` [edk2-devel] " Wang, Jian J

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox