Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Mon, Apr 29, 2019 at 08:52:46AM +0200, Ard Biesheuvel wrote:
> > > > I am not sure if any other platform is using
> > > > “ArmPlatformPkg/Drivers/NorFlashDxe” and may require block I/O and
> > > > disk  I/O protocols
> > > > if we remove “support of block I/O and disk  I/O protocols” then we
> > > > can share the common code easily.
> > > >
> > >
> > > I see your point.
> > >
> > > The only reason you need block i/o and disk i/o is to use ordinary
> > > partition and filesystem drivers. I guess Juno uses this for its magic
> > > filesystem? If not, I'd be glad to get rid of it.
> > >
> > >
> > Yes  "block i/o and disk i/o  of “ArmPlatformPkg/Drivers/NorFlashDxe”
> > driver is used even
> > in RD-platforms(edk2-platforms/Platform/ARM/SgiPkg/)(and JUNO) to list
> > partition. we don't want to break
> > legacy and want to have separate
> > "Platform/ARM/Drivers/StandaloneMmNorFlash/" driver.
> 
> In that case, could we move the existing code into
> edk2-platforms/Platform/ARM first? And then rip out the block i/o and
> disk i/o parts from the common driver?
> 
> Leif, any thoughts?

I guess my only thought is what to do about RDKQemu? Probably is
doesn't make any use of the special sauce, but need to verify?

Then we conside stripping it out of the ARM platforms
medium-term. It's one of the last bastions of "let's be different".
Even if it should be kept around, surely it could be revamped to sit
on top of a sane, generic NorFlashDxe?

I mean, the actually relevant bit is basically
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mtd/afs.c,
isn't it?

+Thomas.

/
    Leif