From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=cneF7ggo;
 spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
 by groups.io with SMTP; Mon, 29 Apr 2019 00:58:20 -0700
Received: by mail-wm1-f67.google.com with SMTP id w15so14273260wmc.3
        for <devel@edk2.groups.io>; Mon, 29 Apr 2019 00:58:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=HVgIiajBzaAGbFjmfb1N1FHATguShWJP0EqqHp1fwrc=;
        b=cneF7ggoQOlp0O1tjqITYn2byV70671NWwrk+crXd8qs4CSgnQjp3zozlkSNncaUKA
         JKd8kRwV5reTnykPxWLLYuO05KiBc/XDW/Xq5vrARWyuiaDpXTtzIsoqkI0QEuSNnt+R
         YYzwMwoHuHhc8orcQ6xnDjdcTKzUU08VSmlhqDFBOrMfq0KutWTxZTV42IdKSwvovwlz
         xf6y/e6nn8AlsMV3VxgMDc4IPFBLEtwTUv15kUXGsEEXtt46tEHW1hxlkOgHzJTvgxtd
         HIZgtDwyf9UHELdh1xVxKscmgYfB/XR/o6eONu9QXujNiXIhMxuL9Fu7tIcmCRju4J6X
         phAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        bh=HVgIiajBzaAGbFjmfb1N1FHATguShWJP0EqqHp1fwrc=;
        b=QtwazyOW2lx9RY0KvLiyNlkrMTMJglULLT4pBfyFDq62tvswHQVGuCMtHQzfrAEHX+
         CRntyPpO0YZt63Iov6hcSNtZTYnSRGMaN2Q1P980Utvbv8KYFZzm6CQy5wIDMljomlV7
         xkUdr+wqGPryrOjPfHtrkBhz5notjOZZYh0Z0d7DrG0nyLYGvTE3rhORSm2UKChKBRrU
         4zHK48o15DgtRmjIiPGGaxf6tMukvla87VYQ798v19cZvncBU8+Oc724beEf0FRpYRMr
         O9i7WWe9bxaskG3IcKGxDoyxsFlqI74HqUq5SM+o9tVBVMewLmE+FMYFP78qS9QQ2ZAP
         12Cw==
X-Gm-Message-State: APjAAAWSfddq4TCJpaS2Sxf3s0oVnBGV37zqAaUTvV60AusQZHSlzXuj
	CoSFGtysl5p3KSdE1ArJ/Wic4w==
X-Google-Smtp-Source: APXvYqzYFvZEVH7k/xjYmP2V8VDqLR6c5v6n+ccpDgLeZPLQyDgbhZrD2KJL7OccLkN4AISUZAli/g==
X-Received: by 2002:a1c:4c09:: with SMTP id z9mr1338181wmf.87.1556524698738;
        Mon, 29 Apr 2019 00:58:18 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id u5sm10328684wml.4.2019.04.29.00.58.17
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Mon, 29 Apr 2019 00:58:18 -0700 (PDT)
Date: Mon, 29 Apr 2019 08:58:16 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Jagadeesh Ujja <jagadeesh.ujja@arm.com>,
	Thomas Panakamattam Abraham <thomas.abraham@arm.com>
Subject: Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver
Message-ID: <20190429075816.y4gyeyqt4kp7lffk@bivouac.eciton.net>
References: <1554210602-2957-1-git-send-email-jagadeesh.ujja@arm.com>
 <CADpYukZHE6NY-U=EycJBVGbQ-XcxXpeT9w6svzWMePjvQXFciQ@mail.gmail.com>
 <CADpYukb5xECL2j02usxeORS-pmxO64O8R9HZoZGK3RGYB3gcDA@mail.gmail.com>
 <CAKv+Gu-K5SWY6XUSANWPBRsFGz=YEo0B-CDc_AbzQZEO-VuNkA@mail.gmail.com>
 <CADpYukYbf=eW6hHiez5uBMRrbRH5Zm+UD6y_eEsm8n-HMUx_CQ@mail.gmail.com>
 <CAKv+Gu93L7=n+8b_t5p88+TLGkur=Pnn3NSY+7WRcCgxR+kfEQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu93L7=n+8b_t5p88+TLGkur=Pnn3NSY+7WRcCgxR+kfEQ@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Mon, Apr 29, 2019 at 08:52:46AM +0200, Ard Biesheuvel wrote:
> > > > I am not sure if any other platform is using
> > > > “ArmPlatformPkg/Drivers/NorFlashDxe” and may require block I/O and
> > > > disk  I/O protocols
> > > > if we remove “support of block I/O and disk  I/O protocols” then we
> > > > can share the common code easily.
> > > >
> > >
> > > I see your point.
> > >
> > > The only reason you need block i/o and disk i/o is to use ordinary
> > > partition and filesystem drivers. I guess Juno uses this for its magic
> > > filesystem? If not, I'd be glad to get rid of it.
> > >
> > >
> > Yes  "block i/o and disk i/o  of “ArmPlatformPkg/Drivers/NorFlashDxe”
> > driver is used even
> > in RD-platforms(edk2-platforms/Platform/ARM/SgiPkg/)(and JUNO) to list
> > partition. we don't want to break
> > legacy and want to have separate
> > "Platform/ARM/Drivers/StandaloneMmNorFlash/" driver.
> 
> In that case, could we move the existing code into
> edk2-platforms/Platform/ARM first? And then rip out the block i/o and
> disk i/o parts from the common driver?
> 
> Leif, any thoughts?

I guess my only thought is what to do about RDKQemu? Probably is
doesn't make any use of the special sauce, but need to verify?

Then we conside stripping it out of the ARM platforms
medium-term. It's one of the last bastions of "let's be different".
Even if it should be kept around, surely it could be revamped to sit
on top of a sane, generic NorFlashDxe?

I mean, the actually relevant bit is basically
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mtd/afs.c,
isn't it?

+Thomas.

/
    Leif