From: "Gary Lin" <glin@suse.com>
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Anthony Perard <anthony.perard@citrix.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [edk2-devel] [PATCH 00/16] OvmfPkg, ArmVirtPkg: upstream the EnrollDefaultKeys app
Date: Tue, 30 Apr 2019 15:51:32 +0800 [thread overview]
Message-ID: <20190430075132.GF12813@GaryWorkstation> (raw)
In-Reply-To: <20190427005328.27005-1-lersek@redhat.com>
On Sat, Apr 27, 2019 at 02:53:12AM +0200, Laszlo Ersek wrote:
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747
> Repo: https://github.com/lersek/edk2.git
> Branch: enroll_bz_1747
>
> Please see the goal / use case in the BZ.
>
> Anatomy of the series:
>
> - Patch 01 adds the application as-is from RHEL, as the starting point
> for upstreaming (preserves continuity).
>
> - Patches 02 through 13 clean up various coding style warts, and add
> documentation, without functional changes.
>
> - Patches 14 through 16 replace the hard-coded Red Hat certificate
> (enrolled as PK and 1st KEK) with a certificate read dynamically from
> SMBIOS (enrolled the same way), originating from the VMM.
>
> I've successfully re-run the Secure Boot Logo Test in Windows HCK, after
> enabling SB in the VM-under-test with this application. I'll attach the
> test log in a separate email (sent in response to this one).
>
For the series, Reviewed-by: Gary Lin <glin@suse.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (16):
> OvmfPkg: introduce EnrollDefaultKeys application
> OvmfPkg/EnrollDefaultKeys: update @file comment blocks
> OvmfPkg/EnrollDefaultKeys: refresh INF file
> ArmVirtPkg: build EnrollDefaultKeys.efi
> OvmfPkg/EnrollDefaultKeys: clean up minor whitespace wart
> OvmfPkg/EnrollDefaultKeys: clean up global variable name prefixes
> OvmfPkg/EnrollDefaultKeys: clean up acronym capitalization in
> identifiers
> OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv.
> specifiers
> OvmfPkg/EnrollDefaultKeys: extract typedefs to a header file
> OvmfPkg/EnrollDefaultKeys: split out certificate and signature
> constants
> OvmfPkg/EnrollDefaultKeys: extract MICROSOFT_VENDOR_GUID
> OvmfPkg/EnrollDefaultKeys: describe functions with leading comment
> blocks
> OvmfPkg/EnrollDefaultKeys: document the steps of the entry point
> function
> OvmfPkg: introduce OVMF_PK_KEK1_APP_PREFIX_GUID
> OvmfPkg/EnrollDefaultKeys: enroll PK/KEK1 from the Type 11 SMBIOS
> table
> OvmfPkg/EnrollDefaultKeys: remove Red Hat's hard-coded PK/KEK1
>
> ArmVirtPkg/ArmVirt.dsc.inc | 1 +
> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
> OvmfPkg/EnrollDefaultKeys/AuthData.c | 440 ++++++++++++
> OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c | 706 ++++++++++++++++++++
> OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.h | 138 ++++
> OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf | 52 ++
> OvmfPkg/Include/Guid/MicrosoftVendor.h | 55 ++
> OvmfPkg/Include/Guid/OvmfPkKek1AppPrefix.h | 45 ++
> OvmfPkg/OvmfPkg.dec | 2 +
> OvmfPkg/OvmfPkgIa32.dsc | 2 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +
> OvmfPkg/OvmfPkgX64.dsc | 2 +
> 13 files changed, 1447 insertions(+)
> create mode 100644 OvmfPkg/EnrollDefaultKeys/AuthData.c
> create mode 100644 OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c
> create mode 100644 OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.h
> create mode 100644 OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf
> create mode 100644 OvmfPkg/Include/Guid/MicrosoftVendor.h
> create mode 100644 OvmfPkg/Include/Guid/OvmfPkKek1AppPrefix.h
>
> --
> 2.19.1.3.g30247aa5d201
>
>
>
>
>
next prev parent reply other threads:[~2019-04-30 7:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 0:53 [PATCH 00/16] OvmfPkg, ArmVirtPkg: upstream the EnrollDefaultKeys app Laszlo Ersek
2019-04-27 0:53 ` [PATCH 01/16] OvmfPkg: introduce EnrollDefaultKeys application Laszlo Ersek
2019-04-30 5:21 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 02/16] OvmfPkg/EnrollDefaultKeys: update @file comment blocks Laszlo Ersek
2019-04-30 5:13 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 03/16] OvmfPkg/EnrollDefaultKeys: refresh INF file Laszlo Ersek
2019-04-29 12:25 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 04/16] ArmVirtPkg: build EnrollDefaultKeys.efi Laszlo Ersek
2019-04-29 12:26 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 05/16] OvmfPkg/EnrollDefaultKeys: clean up minor whitespace wart Laszlo Ersek
2019-04-29 12:26 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 06/16] OvmfPkg/EnrollDefaultKeys: clean up global variable name prefixes Laszlo Ersek
2019-04-29 12:27 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 07/16] OvmfPkg/EnrollDefaultKeys: clean up acronym capitalization in identifiers Laszlo Ersek
2019-04-30 5:10 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 08/16] OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. specifiers Laszlo Ersek
2019-04-29 12:28 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 09/16] OvmfPkg/EnrollDefaultKeys: extract typedefs to a header file Laszlo Ersek
2019-04-29 12:30 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 10/16] OvmfPkg/EnrollDefaultKeys: split out certificate and signature constants Laszlo Ersek
2019-04-29 12:33 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 11/16] OvmfPkg/EnrollDefaultKeys: extract MICROSOFT_VENDOR_GUID Laszlo Ersek
2019-04-30 5:11 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 12/16] OvmfPkg/EnrollDefaultKeys: describe functions with leading comment blocks Laszlo Ersek
2019-04-30 5:12 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 13/16] OvmfPkg/EnrollDefaultKeys: document the steps of the entry point function Laszlo Ersek
2019-04-29 12:36 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 14/16] OvmfPkg: introduce OVMF_PK_KEK1_APP_PREFIX_GUID Laszlo Ersek
2019-04-30 5:24 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 15/16] OvmfPkg/EnrollDefaultKeys: enroll PK/KEK1 from the Type 11 SMBIOS table Laszlo Ersek
2019-04-30 5:34 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 0:53 ` [PATCH 16/16] OvmfPkg/EnrollDefaultKeys: remove Red Hat's hard-coded PK/KEK1 Laszlo Ersek
2019-04-30 5:35 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-27 1:07 ` [edk2-devel] [PATCH 00/16] OvmfPkg, ArmVirtPkg: upstream the EnrollDefaultKeys app Laszlo Ersek
2019-04-27 8:14 ` Ard Biesheuvel
2019-04-30 7:51 ` Gary Lin [this message]
2019-04-30 12:32 ` [edk2-devel] " Laszlo Ersek
2019-04-30 19:42 ` Ard Biesheuvel
2019-04-30 20:04 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430075132.GF12813@GaryWorkstation \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox