From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector1-arm-com header.b=MPVQFXUy; spf=pass (domain: arm.com, ip: 40.107.6.74, mailfrom: sami.mujawar@arm.com) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.74]) by groups.io with SMTP; Wed, 01 May 2019 07:01:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4EaHNgor5yAEuh1f2XRoP4DyALITC5ZowMvDnZUWCEI=; b=MPVQFXUyxr3oEabLQjGBIUbYcaHUqi8cyJjq2oa7Ei3u/DICIGxQqBvR5FuFWFbV/k9g1xhCDP3SIs7ZfzGNj4oULC2ssgiYDSCIkkrq43KpwfgHzEhkvXkMoJQ0ekazqif2SF6/h8blSpxQaLZS9Dh3iaJ3ECWyy+6zpcBWZ8E= Received: from VI1PR08CA0177.eurprd08.prod.outlook.com (2603:10a6:800:d1::31) by VI1PR0802MB2494.eurprd08.prod.outlook.com (2603:10a6:800:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Wed, 1 May 2019 14:01:56 +0000 Received: from DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::202) by VI1PR08CA0177.outlook.office365.com (2603:10a6:800:d1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1856.11 via Frontend Transport; Wed, 1 May 2019 14:01:55 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT026.mail.protection.outlook.com (10.152.20.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.1835.13 via Frontend Transport; Wed, 1 May 2019 14:01:54 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Wed, 1 May 2019 14:01:52 +0000 Received: from E107187.Arm.com (10.1.195.55) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Wed, 1 May 2019 14:01:52 +0000 From: "Sami Mujawar" To: CC: , , , , Subject: [PATCH v1 1/1] ArmPkg: Dispatch deferred images after EndOfDxe Date: Wed, 1 May 2019 15:01:46 +0100 Message-ID: <20190501140146.33224-1-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 Return-Path: Sami.Mujawar@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6029001)(376002)(39860400002)(346002)(396003)(136003)(2980300002)(189003)(199004)(6916009)(36756003)(44832011)(316002)(86362001)(50466002)(426003)(48376002)(53936002)(51416003)(7696005)(336012)(47776003)(486006)(63350400001)(63370400001)(476003)(16586007)(126002)(2616005)(26005)(53416004)(5660300002)(14444005)(2351001)(54906003)(305945005)(478600001)(77096007)(966005)(50226002)(72206003)(70206006)(70586007)(356004)(6666004)(1076003)(68736007)(8676002)(4326008)(8936002)(6306002)(81156014)(81166006)(186003)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0802MB2494;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2dc7ea6-0f68-449d-7966-08d6ce3d9139 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328);SRVR:VI1PR0802MB2494; X-MS-TrafficTypeDiagnostic: VI1PR0802MB2494: X-MS-Exchange-PUrlCount: 1 NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-Forefront-PRVS: 00246AB517 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 0mxcg8zvalunOr2BUJ8P1A2EHAR18Ep3d9MKMV4kC0VvnSFK5Uv+JqhwqerxNbpEcNDNV/hmG8PNgxqzKuTM9ee4By0Icm68gYp2jrryCvYGe3dF6jiqZZJHxYPkYec8CjYqY+XsoMmnbM2ViMIJAPEWV6tlPqprZVgcE+5yd6ujd5izHpRT6VTIV4mOIXhyhqBfyJQMTo3rgn6xgrybkZZXNTLcx2iS1XVmRYrqROzKQgnedfXVZRhUAlJrR3CtEHOJsyxWKli69Emw4uOuD6ErAzIz5RKZaRw7YvnZ2ch4Ett3vRZFxZTqpbMqxKFcIp4s2DHT79tz+tL6MCpyC765N6VSO5MeASJViPNrt8xu85NC2IqgSqk8ArOh/A+fT7jYErHBqavefE867y65o3oSiC4DK2JMHNAISX8xWgo= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2019 14:01:54.4163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c2dc7ea6-0f68-449d-7966-08d6ce3d9139 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2494 Content-Type: text/plain Third party driver images loaded from Option ROM get queued for execution after EndOfDxe. These queued images need to be dispatched from the PlatformBootManagerLib. Since the queued images were not dispatched, the PCI Option ROM drivers were not getting loaded on Juno. Therefore, add call to EfiBootManagerDispatchDeferredImages() for dispatching deferred images from PlatformBootManagerLib. Signed-off-by: Sami Mujawar --- The changes can be seen at https://github.com/samimujawar/edk2/tree/527_option_rom_loading_v1 ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c index 0f91692c1a5ee6104bfef8545e4f436e53042178..71b857b5ba884c27ab870f6b75fa3e34d48e6060 100644 --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c @@ -2,7 +2,7 @@ Implementation for PlatformBootManagerLib library class interfaces. Copyright (C) 2015-2016, Red Hat, Inc. - Copyright (c) 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2014 - 2019, ARM Ltd. All rights reserved.
Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.
Copyright (c) 2016, Linaro Ltd. All rights reserved.
@@ -554,6 +554,11 @@ PlatformBootManagerBeforeConsole ( EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); // + // Dispatch deferred images after EndOfDxe event. + // + EfiBootManagerDispatchDeferredImages (); + + // // Locate the PCI root bridges and make the PCI bus driver connect each, // non-recursively. This will produce a number of child handles with PciIo on // them. -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'