From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Bi, Dandan" <dandan.bi@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Sun, Zailiang" <zailiang.sun@intel.com>,
"Qian, Yi" <yi.qian@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [RFC] [patch] Merge MdeModulePkg\BaseTianoCustomDecompressLib into MdePkg\BaseUefiDecompressLib
Date: Thu, 2 May 2019 10:20:25 +0100 [thread overview]
Message-ID: <20190502092025.7b7tp22crgas3cth@bivouac.eciton.net> (raw)
In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40BCEE29@SHSMSX104.ccr.corp.intel.com>
On Wed, May 01, 2019 at 11:46:49PM +0000, Bi, Dandan wrote:
> > > For the platforms in edk2-platforms repo, I find they don't use the Tiano
> > Custom Decompression algorithm actually.
> > > So we can update them to use the
> > MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf firstly
> > to avoid any
> > > imconpatible changes.
> >
> > That sounds good to me. But can you explain how you determined they
> > don't use the algorithm?
>
> The Tiano Custom Decompression algorithm is registered with TianoCustomDecompress Guid.
> TianoCustomDecompress A31280AD-481E-41B6-95E8-127F4C984779
> We can detect whether this Guid is used in fdf file to see whether the Tiano Compression algorithm is used.
> For the platforms in edk2-platforms repo,
> A31280AD-481E-41B6-95E8-127F4C984779 is used to define the
> TIANOCOMPRESSED rule, but this rule is not used.
Aaah, got it - thanks!
Yes, then I am happy with this change.
/
Leif
next prev parent reply other threads:[~2019-05-02 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 8:58 [RFC] [patch] Merge MdeModulePkg\BaseTianoCustomDecompressLib into MdePkg\BaseUefiDecompressLib Dandan Bi
2019-04-30 21:35 ` Leif Lindholm
2019-05-01 23:46 ` [edk2-devel] " Dandan Bi
2019-05-02 9:20 ` Leif Lindholm [this message]
2019-05-05 5:26 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502092025.7b7tp22crgas3cth@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox