From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=dQhPqikH; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Thu, 02 May 2019 02:20:29 -0700 Received: by mail-wm1-f65.google.com with SMTP id b10so1753621wmj.4 for ; Thu, 02 May 2019 02:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=i37/e9j7NOFOX73g64m5VKhdk8XIhwVtQt07a6jbO28=; b=dQhPqikH3RaDuGNsAG80p2GmrqtZwD2gu0Q0nfxvwMNXIMfOYEajXqB3ltGRCWCOWj +XRl6jWTnbWs7I4w3cOl0QIshbbsRqeCBgcEOtGDFjhT9zmM94z75c/4hJz/ethS4JKK +iee//tD0zYceOIQnagr9mhhxnvK5kuG/4bnE6DDhP74sXyf2QCb8A8A0iu9UOhLJP5q OgcMCTzA8xUjkZ7JyXLqiWDhayiupi5i4g+jMqZXqbsG8nKuahvM8jznZSzhFGPbQ8nC mPwvZSE22g6hzti1BaAs++IaPOCIRcfpN9KKkW34Sa/GaIfr7EDkxP2TqnSLyLEjP446 8EsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=i37/e9j7NOFOX73g64m5VKhdk8XIhwVtQt07a6jbO28=; b=Acn87watOucwmOEwiVIuYPsp8QwqTXdOYgYHmIs24vcBM8wUoDArE0mR2YFIqdZyeb 4UGJJVzCm8GlA8E9F2hS0HPq9f1iT3m3vlZv8br8kYeTCwO63IBqQIN3pOECqsufITMH Ojf0eBmVOkv/AeFk4nF2LwjppjyxKXiRgMBxggSvnIODStu1L+fYg4Nei9bWwql3kBjp z3f1gcYZFQ4B3YAUWQpJK2KJ2YucQfN7EJcFEo6FzW/M9HXIFFiHn5RDDncKUxZcXgXe hdFc4F5lskRc5QCOMp0zRTuclT0vyT/4E+vPlfyOkAdkrp0RcxkAM3vgWnwFefuO0ONs zE4Q== X-Gm-Message-State: APjAAAWpiMPrUR9qTFdrva34+wZralewBHPtrDLpJv/EYV9Qq+J2ke0F 2CKRKYC4bKbDDVLIRHp0Nej+RA== X-Google-Smtp-Source: APXvYqwslzh5vGuP0uZtsRRF9n3ZurA6ZKY08mXL0eSmlqb+uuQ0a6b8SdezLemtpQXhPThVfIuohw== X-Received: by 2002:a05:600c:205a:: with SMTP id p26mr1495214wmg.11.1556788828084; Thu, 02 May 2019 02:20:28 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c63sm10967504wma.29.2019.05.02.02.20.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 02:20:27 -0700 (PDT) Date: Thu, 2 May 2019 10:20:25 +0100 From: "Leif Lindholm" To: "Bi, Dandan" Cc: "devel@edk2.groups.io" , "Kinney, Michael D" , "Gao, Liming" , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Sun, Zailiang" , "Qian, Yi" , Ard Biesheuvel Subject: Re: [edk2-devel] [RFC] [patch] Merge MdeModulePkg\BaseTianoCustomDecompressLib into MdePkg\BaseUefiDecompressLib Message-ID: <20190502092025.7b7tp22crgas3cth@bivouac.eciton.net> References: <20190430085841.15144-1-dandan.bi@intel.com> <20190430213511.q65fzg3p32gr4jtu@bivouac.eciton.net> <3C0D5C461C9E904E8F62152F6274C0BB40BCEE29@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40BCEE29@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 01, 2019 at 11:46:49PM +0000, Bi, Dandan wrote: > > > For the platforms in edk2-platforms repo, I find they don't use the Tiano > > Custom Decompression algorithm actually. > > > So we can update them to use the > > MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf firstly > > to avoid any > > > imconpatible changes. > > > > That sounds good to me. But can you explain how you determined they > > don't use the algorithm? > > The Tiano Custom Decompression algorithm is registered with TianoCustomDecompress Guid. > TianoCustomDecompress A31280AD-481E-41B6-95E8-127F4C984779 > We can detect whether this Guid is used in fdf file to see whether the Tiano Compression algorithm is used. > For the platforms in edk2-platforms repo, > A31280AD-481E-41B6-95E8-127F4C984779 is used to define the > TIANOCOMPRESSED rule, but this rule is not used. Aaah, got it - thanks! Yes, then I am happy with this change. / Leif