From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=LZk/jsZ+; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 02 May 2019 08:40:39 -0700 Received: by mail-wr1-f68.google.com with SMTP id r7so3964572wrr.13 for ; Thu, 02 May 2019 08:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=I7TcK5IQJmFKel9eMcypCP0gjmXyiI8e84oCCUMdtAo=; b=LZk/jsZ+Co9IQ4R2ptBQDNiINkTXeP8K3H6n8enjNa39R6OcrezvxRCHtoiIJ2HuoY g4MwltoCwNbwJfL9qElUnHAd5HHuIvingLOflMxK1lbs6Rs80ipsjm2MOcuO936/O8nb dxWG9ImcMHTZLTERTX9hs/32zMLoyAu7smAsfknObpbHW6I+0Np0GaxdBA7hhg5469Xd KowFuYT/zlTJ+1HNiYYj3Xk05oC5e+5CLzDFlGMu3ll6SeDJTjUYGFaj1GbiWXcVG8FY 0/K4LjoXcyRe8n9azufDK/NYPRiv0M+5G/JSe7IHF+MndyAWOjmEtCZebLihOSbN86wr u1lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I7TcK5IQJmFKel9eMcypCP0gjmXyiI8e84oCCUMdtAo=; b=e2LFS+dNYhSwzOEV+4aCFiu5aGFBDltDWP35i6dgghGJcPKyoDN3wEFJlpsgpdQvXU icTvSlsyIaDUC+grZHL0NJy72o9M6lZrtXPkjduV0MMvDe46e0v3MLzo4h1w3QdDiVu8 uGwZY88JuznQXkjLc/Wh4OPUnGXtwXT4le4n1pSDjfq9g2dodnOf88T18fZWSvfgcsQs TIMLsevQsyecpkK4LzLTt8LMjeS+2q1xr1IVuq+gd++oUF1O8QjOEUXQWbvjdAHq+lk9 CcsDUOluSmC6mwdDqenXANZ6DgeaRBjozePmepLArVmUlEPYmlVB+VHgBW8HWV7GsGpO fBTw== X-Gm-Message-State: APjAAAVxqH5rY5FRV2nsEhzFBbGMHHY/pBcp572MXTSn5PbmGQBFzpmE UupKb1Cd3yclMsyit9pIfP4/Ig== X-Google-Smtp-Source: APXvYqzsfbyP5fH02UZ4gs52XUcn+rlyT0Om87ysmmb2c/vtrpKSyScen9UasgsR7LLWz7QjfvgFGw== X-Received: by 2002:adf:e70a:: with SMTP id c10mr2005560wrm.278.1556811637640; Thu, 02 May 2019 08:40:37 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b10sm16064003wrh.59.2019.05.02.08.40.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 08:40:36 -0700 (PDT) Date: Thu, 2 May 2019 16:40:35 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, graeme.gregory@linaro.org Subject: Re: [PATCH edk2-platforms v2 0/2] enable Secure96 mezzanine on ACPI systems Message-ID: <20190502154035.wdsxba5r6kby5iyr@bivouac.eciton.net> References: <20190502095854.6989-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190502095854.6989-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 02, 2019 at 11:58:52AM +0200, Ard Biesheuvel wrote: > This series plumbs in the support for describing 96boards mezzanines > via ACPI, and uses it to add a description of the Secure96. Note that > the TPM is still missing at the moment, but the I2C crypto accelerators > and the GPIO LEDs are covered. > > Changes since v1: > - Don't rely on a ACPI device in the host platform's namespace to describe > the GPIO lines - this prevents the mezzanine from using GPIOs as interrupts, > and is generally far too restrictive. Since we need a hack (see below) for > I2C anyway, just use the same method for the GPIO controller. > - I2C resources are described with a reference to the I2C controller via a > string argument, which cannot be parameterized using PCDs like we do with > GPIO interrupt numbers. (This is due to the fact that string PCDs are not > expanded to true string literals by EDK2's AutoGen.h CPP magic). So add the > default names (e.g., \_SB.I2C0) to Secure96.h, and permit a platform to > override them if necessary by setting a scoped build option with a -D > argument. > > Ard Biesheuvel (2): > Platform/96Boards: add ACPI support to mezzanine/LS connector driver > Platform/Secure96Dxe: add ACPI description of the LEDs and I2C > peripherals For the series: Reviewed-by: Leif Lindholm > Platform/96Boards/Include/Protocol/Mezzanine.h | 21 ++++ > Platform/96Boards/LsConnectorDxe/LsConnectorDxe.c | 35 ++++-- > Platform/96Boards/LsConnectorDxe/LsConnectorDxe.inf | 1 + > Platform/96Boards/Secure96Dxe/Secure96.asl | 116 ++++++++++++++++++++ > Platform/96Boards/Secure96Dxe/Secure96.h | 8 ++ > Platform/96Boards/Secure96Dxe/Secure96Dxe.c | 59 +++++++++- > Platform/96Boards/Secure96Dxe/Secure96Dxe.inf | 1 + > 7 files changed, 225 insertions(+), 16 deletions(-) > create mode 100644 Platform/96Boards/Secure96Dxe/Secure96.asl > > -- > 2.20.1 >