From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: devel@edk2.groups.io, mw@semihalf.com
Subject: Re: [PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference
Date: Thu, 2 May 2019 17:16:09 +0100 [thread overview]
Message-ID: <20190502161609.eflluwlbuymoo65c@bivouac.eciton.net> (raw)
In-Reply-To: <20190502110013.27351-1-ard.biesheuvel@linaro.org>
On Thu, May 02, 2019 at 01:00:13PM +0200, Ard Biesheuvel wrote:
> StdLib.dec has been move to a separate repository (edk2-libc), so
> any package that requires it needs to be built with an additional
> repo reference added to PACKAGES_PATH.
>
> EepromCmd has such a reference, but since it doesn't appear to
> actually require it, let's just drop it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> index c86ead1b7df2..77f76d51a647 100644
> --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> @@ -46,7 +46,6 @@ [Sources]
> [Packages]
> MdePkg/MdePkg.dec
> ShellPkg/ShellPkg.dec
> - StdLib/StdLib.dec
> MdeModulePkg/MdeModulePkg.dec
> Silicon/Marvell/Marvell.dec
I'm pretty sure there are unused LibraryClasses defined here and
headers included as well, but...
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Marcin, can you give this command a quick scouring once you've sent
out the PCIe bits?
Certainly UefiRuntimeServicesTableLib is not used.
Regards,
Leif
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-05-02 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 11:00 [PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference Ard Biesheuvel
2019-05-02 15:53 ` Marcin Wojtas
2019-05-02 16:16 ` Leif Lindholm [this message]
2019-05-03 6:41 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502161609.eflluwlbuymoo65c@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox