From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=SAq8vlPJ; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Thu, 02 May 2019 09:16:13 -0700 Received: by mail-wr1-f66.google.com with SMTP id o4so4196711wra.3 for ; Thu, 02 May 2019 09:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Z5Eb2bilP0jvd9LqIOE0gSWs9iMm9QmM3NEjaL92RS8=; b=SAq8vlPJ1DhiRxzv1nWCoVKSU5x0i/VPDFUnxzvngDE91ql5laVf54yW9W10NuLLG+ qeVx9r/8eevKv0kTnw5SPvA/RTIglAd/erWlQ2r8ydXAW838lpGIA7Qeh8pjvEQcq64s 37e1bZk4plr7IorbbB/wn1nv80x6BBwQzloA2ZWx1szshvwC8YeDQrrSWXWYiczMZ8pz DIqgdUs3VflNaf38M3rSewI5NVdsDxk4YWQ6bJujelO5RH1flf0Dz5TraTRXjJGqNrRN BmuO3bpRC7soGCYmb2yU/0yQzvsIqw2LP9fnvzcWUqAjVxW74RxsPXrbkpukoVuCa50M tG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Z5Eb2bilP0jvd9LqIOE0gSWs9iMm9QmM3NEjaL92RS8=; b=RbN9PJYC7qIEvYQN5B/Di2cVJr1UDHKOE6iAI3n8BZ6b1cq/0qz2xBxGV3LrbvXMvT W9vQzkrVPrMzfebQ/F41Qy2Wx+v/+yguPlDTnIvK4o9dPqfUiyhUbS5QV6GWW8QAVSaz Qe2UGg4745dasvfbiIRkTLjlG06dZcH13Ly77tnS21fhMbjfTKZ7Mx286APjs1rOjp6I moTyoBb8V20pPfzmTv5TJ7TRNuqaAR0QY15jwj0KluLfJhv/dih81WZ7WD7U46dKgO7J If/7kQ2nRmF1etB8IZQHXRezASKGa7ssTUwGtRSv+NtrDvOzVYOQhtMdgHhBs1mZBpjH ViyQ== X-Gm-Message-State: APjAAAUtrPQhOXlwmiddkj234394HZJCYsdXE0oGIFTl4p8z1K4d05OE EQjdLgMgZAqeCtHgIaBmGX/k8Q== X-Google-Smtp-Source: APXvYqwacij86s6gHAYmjqpJB/N46fSClvdsw2h76b5KmaC623KhfJ+LLpTk6/GZM0LFvBl+zvriAA== X-Received: by 2002:a5d:4eca:: with SMTP id s10mr3379560wrv.319.1556813771272; Thu, 02 May 2019 09:16:11 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p67sm9224328wmp.22.2019.05.02.09.16.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 09:16:10 -0700 (PDT) Date: Thu, 2 May 2019 17:16:09 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, mw@semihalf.com Subject: Re: [PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference Message-ID: <20190502161609.eflluwlbuymoo65c@bivouac.eciton.net> References: <20190502110013.27351-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190502110013.27351-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 02, 2019 at 01:00:13PM +0200, Ard Biesheuvel wrote: > StdLib.dec has been move to a separate repository (edk2-libc), so > any package that requires it needs to be built with an additional > repo reference added to PACKAGES_PATH. > > EepromCmd has such a reference, but since it doesn't appear to > actually require it, let's just drop it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf > index c86ead1b7df2..77f76d51a647 100644 > --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf > +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf > @@ -46,7 +46,6 @@ [Sources] > [Packages] > MdePkg/MdePkg.dec > ShellPkg/ShellPkg.dec > - StdLib/StdLib.dec > MdeModulePkg/MdeModulePkg.dec > Silicon/Marvell/Marvell.dec I'm pretty sure there are unused LibraryClasses defined here and headers included as well, but... Reviewed-by: Leif Lindholm Marcin, can you give this command a quick scouring once you've sent out the PCIe bits? Certainly UefiRuntimeServicesTableLib is not used. Regards, Leif > > -- > 2.20.1 >