[PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference

[PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference

[Ard Biesheuvel]

StdLib.dec has been move to a separate repository (edk2-libc), so
any package that requires it needs to be built with an additional
repo reference added to PACKAGES_PATH.

EepromCmd has such a reference, but since it doesn't appear to
actually require it, let's just drop it.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
index c86ead1b7df2..77f76d51a647 100644
--- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
+++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
@@ -46,7 +46,6 @@ [Sources]
 [Packages]
   MdePkg/MdePkg.dec
   ShellPkg/ShellPkg.dec
-  StdLib/StdLib.dec
   MdeModulePkg/MdeModulePkg.dec
   Silicon/Marvell/Marvell.dec
 
-- 
2.20.1

Re: [PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference

[Marcin Wojtas]

Hi Ard,

czw., 2 maj 2019 o 13:00 Ard Biesheuvel <ard.biesheuvel@linaro.org> napisał(a):
>
> StdLib.dec has been move to a separate repository (edk2-libc), so
> any package that requires it needs to be built with an additional
> repo reference added to PACKAGES_PATH.
>
> EepromCmd has such a reference, but since it doesn't appear to
> actually require it, let's just drop it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Indeed it works without this dependency, thanks!

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

> ---
>  Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> index c86ead1b7df2..77f76d51a647 100644
> --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> @@ -46,7 +46,6 @@ [Sources]
>  [Packages]
>    MdePkg/MdePkg.dec
>    ShellPkg/ShellPkg.dec
> -  StdLib/StdLib.dec
>    MdeModulePkg/MdeModulePkg.dec
>    Silicon/Marvell/Marvell.dec
>
> --
> 2.20.1
>

Re: [PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference

[Leif Lindholm]

On Thu, May 02, 2019 at 01:00:13PM +0200, Ard Biesheuvel wrote:
> StdLib.dec has been move to a separate repository (edk2-libc), so
> any package that requires it needs to be built with an additional
> repo reference added to PACKAGES_PATH.
> 
> EepromCmd has such a reference, but since it doesn't appear to
> actually require it, let's just drop it.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> index c86ead1b7df2..77f76d51a647 100644
> --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> @@ -46,7 +46,6 @@ [Sources]
>  [Packages]
>    MdePkg/MdePkg.dec
>    ShellPkg/ShellPkg.dec
> -  StdLib/StdLib.dec
>    MdeModulePkg/MdeModulePkg.dec
>    Silicon/Marvell/Marvell.dec

I'm pretty sure there are unused LibraryClasses defined here and
headers included as well, but...
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Marcin, can you give this command a quick scouring once you've sent
out the PCIe bits?
Certainly UefiRuntimeServicesTableLib is not used.

Regards,

Leif

>  
> -- 
> 2.20.1
> 

Re: [PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference

[Ard Biesheuvel]

On Thu, 2 May 2019 at 18:16, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Thu, May 02, 2019 at 01:00:13PM +0200, Ard Biesheuvel wrote:
> > StdLib.dec has been move to a separate repository (edk2-libc), so
> > any package that requires it needs to be built with an additional
> > repo reference added to PACKAGES_PATH.
> >
> > EepromCmd has such a reference, but since it doesn't appear to
> > actually require it, let's just drop it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> > index c86ead1b7df2..77f76d51a647 100644
> > --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> > +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> > @@ -46,7 +46,6 @@ [Sources]
> >  [Packages]
> >    MdePkg/MdePkg.dec
> >    ShellPkg/ShellPkg.dec
> > -  StdLib/StdLib.dec
> >    MdeModulePkg/MdeModulePkg.dec
> >    Silicon/Marvell/Marvell.dec
>
> I'm pretty sure there are unused LibraryClasses defined here and
> headers included as well, but...
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks all

Pushed as 4795747fe477..392154d755c6