From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"jsd@semihalf.com" <jsd@semihalf.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Kostya Porotchkin <kostap@marvell.com>,
Jici Gao <Jici.Gao@arm.com>
Subject: Re: [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements
Date: Fri, 3 May 2019 10:28:04 +0100 [thread overview]
Message-ID: <20190503092804.uhjppbc32qgqsj2r@bivouac.eciton.net> (raw)
In-Reply-To: <CAPv3WKc7NiX04+oS1O1AqXj7edkSVzeKE9REAR1tiNfsanOnSg@mail.gmail.com>
On Fri, May 03, 2019 at 09:51:41AM +0200, Marcin Wojtas wrote:
> Hi Leif,
>
> pt., 3 maj 2019 o 09:36 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> >
> > On Fri, May 03, 2019 at 01:50:12AM +0200, Marcin Wojtas wrote:
> > > Hi,
> > >
> > > This small patchset extends PP2 NIC driver with the basic
> > > AdapterInformationProtocol support and adds 88E1112 PHY support.
> > > Also a minor fix is included on top.
> > >
> > > The patches are available in the github:
> > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190503
> > >
> > > I'm looking forward to your comments or remarks.
> >
> > For v2, please add a comment to 0/4 on what user(or
> > developer)-observable effect this has on existing edk2-platforms
> > ... platforms.
> >
>
> Not sure I get it - do you want me to describe a change between v1 and
> v2 or explanation, why I submit these patches at all? Or something
> else?
The latter - why the patches were submitted at all.
Best Regards,
Leif
>
> Best regards,
> Marcin
>
> > No comments (beyond Ard's) on the actual patches.
> >
> > Best Regards,
> >
> > Leif
> >
> > > Best regards,
> > > Marcin
> > >
> > > Marcin Wojtas (3):
> > > Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization
> > > Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
> > > Marvell/Drivers: MvPhyDxe: Reset PHY only once
> > >
> > > Tomasz Michalec (1):
> > > Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol
> > >
> > > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 1 +
> > > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h | 17 ++-
> > > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h | 3 +
> > > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 111 ++++++++++----
> > > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 157 ++++++++++++++++++++
> > > Silicon/Marvell/Documentation/PortingGuide.txt | 7 +-
> > > 6 files changed, 265 insertions(+), 31 deletions(-)
> > >
> > > --
> > > 2.7.4
> > >
prev parent reply other threads:[~2019-05-03 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 23:50 [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements Marcin Wojtas
2019-05-02 23:50 ` [edk2-platforms: PATCH 1/4] Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol Marcin Wojtas
2019-05-03 6:33 ` Ard Biesheuvel
2019-05-03 7:49 ` Marcin Wojtas
2019-05-02 23:50 ` [edk2-platforms: PATCH 2/4] Marvell/Drivers: MvPhyDxe: Improve 88E1510 initialization Marcin Wojtas
2019-05-03 6:35 ` Ard Biesheuvel
2019-05-02 23:50 ` [edk2-platforms: PATCH 3/4] Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization Marcin Wojtas
2019-05-02 23:50 ` [edk2-platforms: PATCH 4/4] Marvell/Drivers: MvPhyDxe: Reset PHY only once Marcin Wojtas
2019-05-03 6:36 ` [edk2-platforms: PATCH 0/4] Armada 7k8k network improvements Ard Biesheuvel
2019-05-03 7:08 ` Marcin Wojtas
2019-05-03 7:36 ` Leif Lindholm
2019-05-03 7:51 ` Marcin Wojtas
2019-05-03 9:28 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503092804.uhjppbc32qgqsj2r@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox