From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: [PATCH 0/4] OvmfPkg/PlatformPei: fix two assertion failures with weird RAM sizes
Date: Sat, 4 May 2019 02:07:11 +0200 [thread overview]
Message-ID: <20190504000716.7525-1-lersek@redhat.com> (raw)
Repo: https://github.com/lersek/edk2.git
Branch: exbar_mtrr_rhbz_1666941
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1666941
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1701710
When booting OVMF on QEMU with "weird" RAM sizes, QEMU's low-RAM split
logic can trigger two assertion failures in OVMF:
- conflict between PCIEXBAR (ECAM) and low-RAM, on q35,
- running out of variable MTRRs when marking the uncacheable MMIO range
in 32-bit address space, on both i440fx and q35.
This series fixes both issues, by moving around the PCIEXBAR on q35, and
by truncating the size of the uncacheable 32-bit area to a power of two.
The latter idea was inspired by SeaBIOS.
Tested on both machine types, with the following memory sizes (all in
MB): 1025, 2815, 3583, 5120. On i440fx, the X64 build was used (without
SMM). On q35, the IA32 and IA32X64 builds were used (with SMM). Testing
included "/proc/mtrr" verification, 32-bit PCI MMIO aperture
verification, general dmesg checks, and my usual regression tests too
(ACPI S3, UEFI variable services, ...).
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Thanks
Laszlo
Laszlo Ersek (4):
OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches
explicitly
OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35
branching
OvmfPkg/PlatformPei: reorder the 32-bit PCI hole vs. the PCIEXBAR on
q35
OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits
clear
OvmfPkg/OvmfPkgIa32.dsc | 5 +----
OvmfPkg/OvmfPkgIa32X64.dsc | 5 +----
OvmfPkg/OvmfPkgX64.dsc | 5 +----
OvmfPkg/PlatformPei/MemDetect.c | 23 +++++++++++++++++---
OvmfPkg/PlatformPei/Platform.c | 14 +++++-------
OvmfPkg/PlatformPei/Platform.h | 2 ++
6 files changed, 31 insertions(+), 23 deletions(-)
--
2.19.1.3.g30247aa5d201
next reply other threads:[~2019-05-04 0:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 0:07 Laszlo Ersek [this message]
2019-05-04 0:07 ` [PATCH 1/4] OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches explicitly Laszlo Ersek
2019-05-06 11:06 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-05-06 12:04 ` Laszlo Ersek
2019-05-16 7:52 ` Ard Biesheuvel
2019-05-04 0:07 ` [PATCH 2/4] OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35 branching Laszlo Ersek
2019-05-06 11:08 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-05-16 7:53 ` Ard Biesheuvel
2019-05-04 0:07 ` [PATCH 3/4] OvmfPkg/PlatformPei: reorder the 32-bit PCI hole vs. the PCIEXBAR on q35 Laszlo Ersek
2019-05-16 8:00 ` [edk2-devel] " Ard Biesheuvel
2019-05-16 12:18 ` Laszlo Ersek
2019-05-16 12:24 ` Philippe Mathieu-Daudé
2019-05-16 19:15 ` Laszlo Ersek
2019-05-04 0:07 ` [PATCH 4/4] OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits clear Laszlo Ersek
2019-05-08 7:33 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-05-08 9:10 ` Laszlo Ersek
2019-05-16 8:05 ` Ard Biesheuvel
2019-05-15 10:36 ` [edk2-devel] [PATCH 0/4] OvmfPkg/PlatformPei: fix two assertion failures with weird RAM sizes Laszlo Ersek
2019-05-15 11:56 ` Leif Lindholm
2019-05-15 12:44 ` Laszlo Ersek
2019-05-15 16:42 ` Michael D Kinney
2019-05-16 19:33 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504000716.7525-1-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox