public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Fan, ZhijuX" <zhijux.fan@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	"Cohen, Eugene" <eugene@hp.com>
Subject: Re: [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from ArmPlatformPkg
Date: Tue, 7 May 2019 10:30:46 +0100	[thread overview]
Message-ID: <20190507093045.g2w6dzmkqrq26g3l@bivouac.eciton.net> (raw)
In-Reply-To: <FAD0D7E0AE0FA54D987F6E72435CAFD50AF5BCA9@SHSMSX101.ccr.corp.intel.com>

On Mon, May 06, 2019 at 09:20:12AM +0000, Fan, ZhijuX wrote:
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627
> 
> The FrameworkDatabase was already obsolete,
> So, FrameworkDatabase can be removed from ArmPlatformPkg.
> 
> This patch is going to fix this issue.
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>

So, first of all:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Hmm. I wonder if anyone actually uses this Makefile at all since we
moved the platforms out. Thomas? Sami? Eugene?

Best Regards,

Leif

> ---
>  ArmPlatformPkg/Scripts/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ArmPlatformPkg/Scripts/Makefile b/ArmPlatformPkg/Scripts/Makefile
> index 09f1c90923..76f25e35e8 100644
> --- a/ArmPlatformPkg/Scripts/Makefile
> +++ b/ArmPlatformPkg/Scripts/Makefile
> @@ -65,7 +65,6 @@ endif
>  $(EDK2_CONF):
>  ifeq ("$(OS)","Windows_NT")
>  	copy $(EDK_TOOLS_PATH)\Conf\build_rule.template Conf\build_rule.txt
> -	copy $(EDK_TOOLS_PATH)\Conf\FrameworkDatabase.template Conf\FrameworkDatabase.txt
>  	copy $(EDK_TOOLS_PATH)\Conf\target.template Conf\target.txt
>  	copy $(EDK_TOOLS_PATH)\Conf\tools_def.template Conf\tools_def.txt
>  else
> -- 
> 2.14.1.windows.1
> 



  reply	other threads:[~2019-05-07  9:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06  9:20 [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from ArmPlatformPkg Fan, ZhijuX
2019-05-07  9:30 ` Leif Lindholm [this message]
2019-05-07  9:48   ` Sami Mujawar
2019-05-08  6:11     ` thomas.abraham
2019-05-08  9:01       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190507093045.g2w6dzmkqrq26g3l@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox