[edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX
@ 2019-05-07 10:08 Xu, Wei6
  2019-05-07 10:08 ` [edk2-devel][Patch 1/2] FatPkg/FatPei: " Xu, Wei6
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Xu, Wei6 @ 2019-05-07 10:08 UTC (permalink / raw)
  To: devel; +Cc: Ni Ray, Wu Hao A

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777

BootInRecoveryMode Ppi dependency should be removed from PEI storage stack drivers.Besides recovery, more features are using the storage stack.

CC: Ni Ray <ray.ni@intel.com>
CC: Wu Hao A <hao.a.wu@intel.com>

xuwei6 (2):
  FatPkg/FatPei: Remove BootInRecoveryMode PPI DEPEX.
  MdeModulePkg: Remove BootInRecoveryMode PPI DEPEX from PEI storage
    stack.

 FatPkg/FatPei/FatPei.inf                                  | 2 +-
 MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf              | 2 +-
 MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf              | 2 +-
 MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf              | 2 +-
 MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.16.2.windows.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [edk2-devel][Patch 1/2] FatPkg/FatPei: Remove BootInRecoveryMode PPI DEPEX.
  2019-05-07 10:08 [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Xu, Wei6
@ 2019-05-07 10:08 ` Xu, Wei6
  2019-05-07 10:08 ` [edk2-devel][Patch 2/2] MdeModulePkg: Remove BootInRecoveryMode PPI DEPEX from PEI storage stack Xu, Wei6
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Xu, Wei6 @ 2019-05-07 10:08 UTC (permalink / raw)
  To: devel; +Cc: Ni Ray, Wu Hao A, Xu Wei6

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777

BootInRecoveryMode Ppi dependency should be removed from PEI storage stack drivers. Besides recovery, more features are using the storage stack.
Platform can apply Ppi dependency in Recovery FV which contains full storage driver stack.
Platform storage stack modules, such as host controller init PEI module, should also remove this dependency.

CC: Ni Ray <ray.ni@intel.com>
CC: Wu Hao A <hao.a.wu@intel.com>
Signed-off-by: Xu Wei6 <wei6.xu@intel.com>
---
 FatPkg/FatPei/FatPei.inf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf
index b554aae040..4560dbaab4 100644
--- a/FatPkg/FatPei/FatPei.inf
+++ b/FatPkg/FatPei/FatPei.inf
@@ -71,9 +71,9 @@
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName         ## CONSUMES
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   FatPeiExtra.uni
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [edk2-devel][Patch 2/2] MdeModulePkg: Remove BootInRecoveryMode PPI DEPEX from PEI storage stack.
  2019-05-07 10:08 [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Xu, Wei6
  2019-05-07 10:08 ` [edk2-devel][Patch 1/2] FatPkg/FatPei: " Xu, Wei6
@ 2019-05-07 10:08 ` Xu, Wei6
  2019-05-07 16:01 ` [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Zhang, Chao B
  2019-05-09  7:19 ` Wu, Hao A
  3 siblings, 0 replies; 5+ messages in thread
From: Xu, Wei6 @ 2019-05-07 10:08 UTC (permalink / raw)
  To: devel; +Cc: Ni Ray, Wu Hao A, Xu Wei6

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777

BootInRecoveryMode Ppi dependency should be removed from PEI storage stack drivers. Besides recovery, more features are using the storage stack.
Platform can apply Ppi dependency in Recovery FV which contains full storage driver stack.
Platform storage stack modules, such as host controller init PEI module, should also remove this dependency.

CC: Ni Ray <ray.ni@intel.com>
CC: Wu Hao A <hao.a.wu@intel.com>
Signed-off-by: Xu Wei6 <wei6.xu@intel.com>
---
 MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf              | 2 +-
 MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf              | 2 +-
 MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf              | 2 +-
 MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf b/MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf
index a810c3c6bc..0fc09ffca4 100644
--- a/MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf
+++ b/MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf
@@ -57,9 +57,9 @@
   gPeiUsbControllerPpiGuid                      ## CONSUMES
   gEdkiiIoMmuPpiGuid                            ## CONSUMES
   gEfiEndOfPeiSignalPpiGuid                     ## CONSUMES
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbControllerPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbControllerPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   EhciPeiExtra.uni
diff --git a/MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf b/MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf
index 074f12586c..ad50d4c0c9 100644
--- a/MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf
+++ b/MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf
@@ -54,9 +54,9 @@
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdSataSpinUpDelayInSecForRecoveryPath   ## CONSUMES
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid AND gPeiAtaControllerPpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiAtaControllerPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   IdeBusPeiExtra.uni
diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf b/MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf
index accb0e2460..06515b7ca7 100644
--- a/MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf
+++ b/MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf
@@ -52,9 +52,9 @@
   gEdkiiIoMmuPpiGuid                            ## CONSUMES
   gEfiEndOfPeiSignalPpiGuid                     ## CONSUMES
 
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbControllerPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbControllerPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   UhciPeiExtra.uni
diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf b/MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf
index 89bb28ee53..f216538f4d 100644
--- a/MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf
+++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf
@@ -52,9 +52,9 @@
   gPeiUsbControllerPpiGuid                      ## CONSUMES
   gEdkiiIoMmuPpiGuid                            ## CONSUMES
   gEfiEndOfPeiSignalPpiGuid                     ## CONSUMES
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbControllerPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbControllerPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   XhciPeiExtra.uni
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf b/MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf
index f9f44a883e..de2df5fe3c 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf
@@ -54,9 +54,9 @@
   ## CONSUMES
   ## NOTIFY
   gPeiUsbIoPpiGuid
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbIoPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsbIoPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   UsbBotPeiExtra.uni
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf
index 617aa3bb10..31d7c2e2fe 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf
@@ -52,9 +52,9 @@
   gPeiUsbIoPpiGuid                              ## PRODUCES
   gPeiUsbHostControllerPpiGuid                  ## SOMETIMES_CONSUMES
   gPeiUsb2HostControllerPpiGuid                 ## SOMETIMES_CONSUMES
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid AND gPeiUsb2HostControllerPpiGuid OR gPeiUsbHostControllerPpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid AND gPeiUsb2HostControllerPpiGuid OR gPeiUsbHostControllerPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   UsbBusPeiExtra.uni
diff --git a/MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf b/MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf
index 11ab49b33b..6a8f3c2da8 100644
--- a/MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf
+++ b/MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf
@@ -63,9 +63,9 @@
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName         ## CONSUMES
 
 [Depex]
-  gEfiPeiMemoryDiscoveredPpiGuid AND gEfiPeiBootInRecoveryModePpiGuid
+  gEfiPeiMemoryDiscoveredPpiGuid
 
 [UserExtensions.TianoCore."ExtraFiles"]
   CdExpressPeiExtra.uni
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX
  2019-05-07 10:08 [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Xu, Wei6
  2019-05-07 10:08 ` [edk2-devel][Patch 1/2] FatPkg/FatPei: " Xu, Wei6
  2019-05-07 10:08 ` [edk2-devel][Patch 2/2] MdeModulePkg: Remove BootInRecoveryMode PPI DEPEX from PEI storage stack Xu, Wei6
@ 2019-05-07 16:01 ` Zhang, Chao B
  2019-05-09  7:19 ` Wu, Hao A
  3 siblings, 0 replies; 5+ messages in thread
From: Zhang, Chao B @ 2019-05-07 16:01 UTC (permalink / raw)
  To: devel@edk2.groups.io, Xu, Wei6; +Cc: Ni, Ray, Wu, Hao A

Reviewed-by ： Chao Zhang <chao.b.zhang@intel.com>

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, Wei6
Sent: Tuesday, May 7, 2019 6:08 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
Subject: [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777

BootInRecoveryMode Ppi dependency should be removed from PEI storage stack drivers.Besides recovery, more features are using the storage stack.

CC: Ni Ray <ray.ni@intel.com>
CC: Wu Hao A <hao.a.wu@intel.com>

xuwei6 (2):
  FatPkg/FatPei: Remove BootInRecoveryMode PPI DEPEX.
  MdeModulePkg: Remove BootInRecoveryMode PPI DEPEX from PEI storage
    stack.

 FatPkg/FatPei/FatPei.inf                                  | 2 +-
 MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf              | 2 +-
 MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf                  | 2 +-
 MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf              | 2 +-
 MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf              | 2 +-
 MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.16.2.windows.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX
  2019-05-07 10:08 [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Xu, Wei6
                   ` (2 preceding siblings ...)
  2019-05-07 16:01 ` [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Zhang, Chao B
@ 2019-05-09  7:19 ` Wu, Hao A
  3 siblings, 0 replies; 5+ messages in thread
From: Wu, Hao A @ 2019-05-09  7:19 UTC (permalink / raw)
  To: Xu, Wei6, devel@edk2.groups.io; +Cc: Ni, Ray

> -----Original Message-----
> From: Xu, Wei6
> Sent: Tuesday, May 07, 2019 6:08 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray; Wu, Hao A
> Subject: [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777
> 
> BootInRecoveryMode Ppi dependency should be removed from PEI storage
> stack drivers.Besides recovery, more features are using the storage stack.
> 
> CC: Ni Ray <ray.ni@intel.com>
> CC: Wu Hao A <hao.a.wu@intel.com>
> 
> xuwei6 (2):
>   FatPkg/FatPei: Remove BootInRecoveryMode PPI DEPEX.
>   MdeModulePkg: Remove BootInRecoveryMode PPI DEPEX from PEI storage
>     stack.

Please help to run the 'PatchCheck' script. There are some commit log
format issues for both of the patches.

With that fixed:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

> 
>  FatPkg/FatPei/FatPei.inf                                  | 2 +-
>  MdeModulePkg/Bus/Pci/EhciPei/EhciPei.inf                  | 2 +-
>  MdeModulePkg/Bus/Pci/IdeBusPei/IdeBusPei.inf              | 2 +-
>  MdeModulePkg/Bus/Pci/UhciPei/UhciPei.inf                  | 2 +-
>  MdeModulePkg/Bus/Pci/XhciPei/XhciPei.inf                  | 2 +-
>  MdeModulePkg/Bus/Usb/UsbBotPei/UsbBotPei.inf              | 2 +-
>  MdeModulePkg/Bus/Usb/UsbBusPei/UsbBusPei.inf              | 2 +-
>  MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> --
> 2.16.2.windows.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-09  7:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-07 10:08 [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Xu, Wei6
2019-05-07 10:08 ` [edk2-devel][Patch 1/2] FatPkg/FatPei: " Xu, Wei6
2019-05-07 10:08 ` [edk2-devel][Patch 2/2] MdeModulePkg: Remove BootInRecoveryMode PPI DEPEX from PEI storage stack Xu, Wei6
2019-05-07 16:01 ` [edk2-devel][Patch 0/2] Remove BootInRecoveryMode PPI DEPEX Zhang, Chao B
2019-05-09  7:19 ` Wu, Hao A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox