From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=D9qLbbqn; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Tue, 07 May 2019 04:31:09 -0700 Received: by mail-wr1-f67.google.com with SMTP id v10so9554179wrt.6 for ; Tue, 07 May 2019 04:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Aanaovnm35wlzh3NuvNo9uZFJB814eDHX7rGZjWqsxg=; b=D9qLbbqn1k1gPxW67xf89iyHcK0SFFwYMHq2JQDFQOIu/Q4eGePAqRnef9G77hgvzH 3PBA3Nrd4JWvKuMOyeymVM1SGvtbyOyBKJcCs/rjCJVk0Xx6Oa6aDH7rmCyeto19l/qp iNVl+QctngHM3Nk3SpUtR2Q75VWZjWYst6STO2TE0HlZoyYCwtHvrTFC13qB2fpq6PWP cNkNdoNE2xSykIJafK8P/uSZLFbLN4IPkk11ctjiaddqwp5TtTtu4fqJqiUFw2VU7UoF Dxu+GF/NPrLfGWpNxRAyf2R7nxnL3w29ZGJXMdOJ/2eziHpdEqt3QhF4IKh53VBVyu77 8pRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Aanaovnm35wlzh3NuvNo9uZFJB814eDHX7rGZjWqsxg=; b=K6WxX70JVQiHMD94s6QDUx0syAddc4CcHtOPTdmRy4xVcr0HxPu2y1YArEmddKwAJx NCTZCEJx1jF/ZJEW0f7yPhLgpw0nQijZ/zf7ygPqSYfFcI66/fpGxeIfG270nTLyKv0X qOlLud8HgrJEoltVIMYa5MSsLB1IEFIxu2PcAv2GIaJczCeJtSOuZODqAeiQrq6khIYS OsBWAj91QxOhKYufT71wey2X5/+uvVHDZ1L/H39m144a01hXYgy5WKWR2V0iinJcnj3D h/b7hiSMzb1gbVkzCDHRqZ4WS+Own0fGP9/BsXARuO6gM8uFmr1U7+TlxiCAjz9kdGdf 5b2g== X-Gm-Message-State: APjAAAVMZFtotZlyHJntOSmxPSsCyvSe5WIPCBfU3Xs4wJ/usSlBnYuA om8f0AXZSJoPA7ticUQqcrTsjA== X-Google-Smtp-Source: APXvYqzVbdWBnn9ogFRI4banAjp32T0Lz2TKot+Qqsc6Bdi1QySZ7GYNzq6z9vUiYubRvyceSMrnxQ== X-Received: by 2002:adf:9301:: with SMTP id 1mr19284757wro.231.1557228667603; Tue, 07 May 2019 04:31:07 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q2sm16494180wrd.48.2019.05.07.04.31.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 04:31:06 -0700 (PDT) Date: Tue, 7 May 2019 12:31:05 +0100 From: "Leif Lindholm" To: Dandan Bi Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-platforms] [patch 1/7] Platform/AMD: Update UefiDecompressLib instance Message-ID: <20190507113105.22gvbhueojdfrynn@bivouac.eciton.net> References: <20190505080537.22000-1-dandan.bi@intel.com> <20190505080537.22000-2-dandan.bi@intel.com> MIME-Version: 1.0 In-Reply-To: <20190505080537.22000-2-dandan.bi@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Dandan, Sorry to be a pain, but could you follow the steps in https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09 and then regenerate these patches and send out again? That way, it is obvious from the diff which sections are being modified. Best Regards, Leif On Sun, May 05, 2019 at 04:05:31PM +0800, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722 > > BaseUefiDecompressLib in MdePkg is the > base UEFI decompress Library. > BaseUefiTianoCustomDecompressLib in MdeModulePkg > implements the base UEFI decompress functionality and > Tiano decompress functionality. > > 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf > is not used, so remove it. > 2. Platform doesn't use the TianoCompress, so do > not have to use BaseUefiTianoCustomDecompressLib, > can use the BaseUefiDecompressLib in MdePkg directly. > 3. A common UefiDecompressLib resolution can apply to > all module types now. So keep the common one in > [LibraryClasses.common] section and remove all others. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 ----- > Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 --------- > 2 files changed, 14 deletions(-) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index 616553172b..39b5dad154 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -186,11 +186,10 @@ DEFINE X64EMU_ENABLE = FALSE > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > - UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf > > [LibraryClasses.common.PEIM] > @@ -199,21 +198,19 @@ DEFINE X64EMU_ENABLE = FALSE > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > - UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf > > [LibraryClasses.common.DXE_CORE] > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > - UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf > PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf > > [LibraryClasses.common.DXE_DRIVER] > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > @@ -227,17 +224,15 @@ DEFINE X64EMU_ENABLE = FALSE > !if $(TARGET) != RELEASE > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > !endif > > [LibraryClasses.common.UEFI_APPLICATION] > - UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > > [LibraryClasses.common.UEFI_DRIVER] > - UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > [LibraryClasses.ARM] > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf > index a058665bcc..2aaf83084e 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf > @@ -416,19 +416,10 @@ CAPSULE_HEADER_INIT_VERSION = 0x1 > PEI_DEPEX PEI_DEPEX Optional |.depex > TE TE Align = Auto |.efi > UI STRING="$(MODULE_NAME)" Optional > } > > -[Rule.Common.PEIM.TIANOCOMPRESSED] > - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 { > - PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE { > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - } > - } > - > [Rule.Common.DXE_CORE] > FILE DXE_CORE = $(NAMED_GUID) { > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > } > -- > 2.18.0.windows.1 >