From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=gCJnAS71; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Tue, 07 May 2019 07:40:06 -0700 Received: by mail-wm1-f68.google.com with SMTP id y2so20474378wmi.5 for ; Tue, 07 May 2019 07:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WCoIin4CYb/t6ARAP/z0DzYCZkY+jxpOKC4rVjOyDpk=; b=gCJnAS71e2/FqovSwqdyRve9VAcA8qJGrrwW6OEOuO4kd9yAxfIEbz3HLGRXwIRkkr JfGgHKp538c92Zxc6uoMfaosOZHLwVzx6v1+iCDCFGNp/jNMug7zJSXw3jQVIte/lf0r PnNfpND3lipDpJFW+1GjxivGRRZmuikkoNU+4aEkYP7fVSo4xQ0zoCf63gsmWDzcN3U+ XKfPTUPVc6GEgI+y9q0R+ex2EBwRyFPGg/Dt/UtjJzfLOI0LICexF4b8cdpvwPv21MYu wVQu85SDry+X3YBzQ4vwc0/jDGxUNIIbOXHevJG8Q5Ow/TGgdgc5LTaSyheobZapzZxC R3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WCoIin4CYb/t6ARAP/z0DzYCZkY+jxpOKC4rVjOyDpk=; b=DdqMYCiADkcJKF+JB/PvWvF2xbOawjAW68omfNbTCdOMXQQsft0liAm1ZnbCcMSS9p yjwTcBcHkAV3teZU/Vjxz84KcV9Q9wPffXSMMSc3sll/hgUGHG4Ba/OzcH9byzCloO3s pGcvBJVOASHugWegnHFSDTHblJn0kayBxAt/1+CdtNHZwtD3ag32npjNrTMN/ZnalntJ +4H4xG4E4h1WDaqijtGqA44pbEPW5KR+DV1sGGXYDOx6AEiVxX92O4/wUsjfErmNl52R 4vSxNHFeP/4okBXNED/dpJ/45jlUiuaX/+c3CctVVHCMOViv1aaWzBT1x+pI4Fj+CnTh 2yKA== X-Gm-Message-State: APjAAAV8QIwnjEmNrsHV/elmwHEaRNf6f0Mx35X+pHDh4Dk31ibT+B4J k5TPYGNCDFWfpCKZ5ygq3RvlrcsMjHY= X-Google-Smtp-Source: APXvYqwI0e3MDXSVmdIWAOgmp0qWHrHJPoIFzF2craC8pwP7mfn37+mE3smEEmxhT20nidDZTSd8iA== X-Received: by 2002:a7b:cb58:: with SMTP id v24mr20211447wmj.121.1557240004310; Tue, 07 May 2019 07:40:04 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s12sm7744726wrr.46.2019.05.07.07.40.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 07:40:03 -0700 (PDT) Date: Tue, 7 May 2019 15:40:02 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, zhijux.fan@intel.com Cc: "afish@apple.com" , "Gao, Liming" , "Feng, Bob C" Subject: Re: FW: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes Message-ID: <20190507144002.gq3rdtappd3rupmd@bivouac.eciton.net> References: <5C1A24BA-648D-4A3F-AE88-034073AB5C13@apple.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Fan Zhiju, But where does the string come from that contains a .C suffix? Is the tool internally converting things to uppercase, or is some source file in the build incorrectly named? I am asking because it is not clear to me whether the patch resolves a problem or hides one. Best Regards, Leif On Tue, May 07, 2019 at 03:05:02AM +0000, Fan, ZhijuX wrote: > This problem has nothing to do with the file system, We just use the > filename as a string to compare with other strings > Our unittest tested minplatform, Ovmf. This problem was found when > building a platform inside Intel. > We've tested it on Linux and Windows. > > Any question, please let me know. Thanks. > > Best Regards > Fan Zhiju > > -----Original Message----- > From: afish@apple.com [mailto:afish@apple.com] > Sent: Tuesday, May 7, 2019 10:31 AM > To: devel@edk2.groups.io; Fan, ZhijuX > Cc: Gao, Liming ; Feng, Bob C > Subject: Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes > > This brings up a question? Do we tests on a file system that is case sensitive? Is this just lack of a test case? > > Thanks, > > Andrew Fish > > > On May 6, 2019, at 7:22 PM, Fan, ZhijuX wrote: > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1773 > > > > Build break if C file suffixes of named .C instead of .c Code not > > recognize filenames with .C suffixes. > > > > This patch adds code to Support both .c file and .C file > > > > Cc: Bob Feng > > Cc: Liming Gao > > Signed-off-by: Zhiju.Fan > > --- > > BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py > > b/BaseTools/Source/Python/AutoGen/GenMake.py > > index 0e0f9fd9b0..858ddedf8e 100644 > > --- a/BaseTools/Source/Python/AutoGen/GenMake.py > > +++ b/BaseTools/Source/Python/AutoGen/GenMake.py > > @@ -1035,7 +1035,8 @@ cleanlib: > > CmdTargetDict[CmdSign] = "%s %s" % (CmdTargetDict[CmdSign], SingleCommandList[-1]) > > Index = CommandList.index(Item) > > CommandList.pop(Index) > > - if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, CmdSumDict[CmdSign.lstrip('/Fo').rsplit(TAB_SLASH, 1)[0]])): > > + if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, CmdSumDict[T.Target.SubDir])) or \ > > + SingleCommandList[-1].endswith("%s%s.C" % (TAB_SLASH, CmdSumDict[T.Target.SubDir])): > > Cpplist = CmdCppDict[T.Target.SubDir] > > Cpplist.insert(0, '$(OBJLIST_%d): $(COMMON_DEPS)' % list(self.ObjTargetDict.keys()).index(T.Target.SubDir)) > > T.Commands[Index] = '%s\n\t%s' % (' > > \\\n\t'.join(Cpplist), CmdTargetDict[CmdSign]) > > -- > > 2.14.1.windows.1 > > > > > > > > > > > > > >