public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance
@ 2019-05-08  2:00 Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 1/7] Platform/AMD: " Dandan Bi
                   ` (7 more replies)
  0 siblings, 8 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.

1. TIANOCOMPRESSED rule in OverdriveBoard.fdf
is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
3. A common UefiDecompressLib resolution can apply to
all module types now. So keep the common one in
[LibraryClasses.common] section and remove all others.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

Dandan Bi (7):
  Platform/AMD: Update UefiDecompressLib instance
  Platform/LeMaker: Update UefiDecompressLib instance
  Platform/RPi3: Update UefiDecompressLib instance
  Platform/SoftIron: Update UefiDecompressLib instance
  Silicon/Hisilicon: Update UefiDecompressLib instance
  Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule
  Platform: Remove TIANOCOMPRESSED rule

 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc           | 5 -----
 Platform/AMD/OverdriveBoard/OverdriveBoard.fdf           | 9 ---------
 Platform/ARM/SgiPkg/SgiPlatform.fdf                      | 9 ---------
 Platform/LeMaker/CelloBoard/CelloBoard.dsc               | 5 -----
 Platform/LeMaker/CelloBoard/CelloBoard.fdf               | 9 ---------
 Platform/RaspberryPi/RPi3/RPi3.dsc                       | 3 ---
 Platform/RaspberryPi/RPi3/RPi3.fdf                       | 9 ---------
 Platform/Socionext/DeveloperBox/DeveloperBox.fdf         | 9 ---------
 .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf  | 9 ---------
 .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 5 -----
 .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf   | 9 ---------
 Silicon/Hisilicon/Hisilicon.dsc.inc                      | 5 -----
 Silicon/Hisilicon/Hisilicon.fdf.inc                      | 9 ---------
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc            | 1 -
 Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                | 9 ---------
 15 files changed, 105 deletions(-)

-- 
2.18.0.windows.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [edk2-platforms] [patch v2 1/7] Platform/AMD: Update UefiDecompressLib instance
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
@ 2019-05-08  2:00 ` Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 2/7] Platform/LeMaker: " Dandan Bi
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.

1. TIANOCOMPRESSED rule in OverdriveBoard.fdf
is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
3. A common UefiDecompressLib resolution can apply to
all module types now. So keep the common one in
[LibraryClasses.common] section and remove all others.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 -----
 Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 ---------
 2 files changed, 14 deletions(-)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 616553172b..39b5dad154 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -186,11 +186,10 @@ [LibraryClasses.common.PEI_CORE]
   HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
   MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
   PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
 
 [LibraryClasses.common.PEIM]
@@ -199,21 +198,19 @@ [LibraryClasses.common.PEIM]
   MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
   PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
   PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
 
 [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
   MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
   DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
 
 [LibraryClasses.common.DXE_DRIVER]
   SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
@@ -227,17 +224,15 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
 !if $(TARGET) != RELEASE
   DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
 !endif
 
 [LibraryClasses.common.UEFI_APPLICATION]
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER]
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
 
 [LibraryClasses.ARM]
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
index a058665bcc..2aaf83084e 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
@@ -416,19 +416,10 @@ [Rule.Common.PEIM.Binary]
      PEI_DEPEX PEI_DEPEX Optional       |.depex
      TE       TE Align = Auto           |.efi
      UI       STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [edk2-platforms] [patch v2 2/7] Platform/LeMaker: Update UefiDecompressLib instance
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 1/7] Platform/AMD: " Dandan Bi
@ 2019-05-08  2:00 ` Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 3/7] Platform/RPi3: " Dandan Bi
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.

1. TIANOCOMPRESSED rule in fdf is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
3. A common UefiDecompressLib resolution can apply to
all module types now. So keep the common one in
[LibraryClasses.common] section and remove all others.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 Platform/LeMaker/CelloBoard/CelloBoard.dsc | 5 -----
 Platform/LeMaker/CelloBoard/CelloBoard.fdf | 9 ---------
 2 files changed, 14 deletions(-)

diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index c26d38226c..bc2f3e2076 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -170,11 +170,10 @@ [LibraryClasses.common.PEI_CORE]
   PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
 
 [LibraryClasses.common.PEIM]
@@ -185,22 +184,20 @@ [LibraryClasses.common.PEIM]
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
   PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
 
 [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
   MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
   DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
 
 [LibraryClasses.common.DXE_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
   SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
@@ -216,19 +213,17 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
 !if $(TARGET) != RELEASE
   DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
 !endif
 
 [LibraryClasses.common.UEFI_APPLICATION]
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
 
 [LibraryClasses.ARM]
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.fdf b/Platform/LeMaker/CelloBoard/CelloBoard.fdf
index 0f5880cfa4..d34b986b93 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.fdf
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.fdf
@@ -326,19 +326,10 @@ [Rule.Common.PEIM.Binary]
      PEI_DEPEX PEI_DEPEX Optional       |.depex
      TE       TE Align = Auto           |.efi
      UI       STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [edk2-platforms] [patch v2 3/7] Platform/RPi3: Update UefiDecompressLib instance
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 1/7] Platform/AMD: " Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 2/7] Platform/LeMaker: " Dandan Bi
@ 2019-05-08  2:00 ` Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 4/7] Platform/SoftIron: " Dandan Bi
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.

1. TIANOCOMPRESSED rule in fdf is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
3. A common UefiDecompressLib resolution can apply to
all module types now. So keep the common one in
[LibraryClasses.common] section and remove all others.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ---
 Platform/RaspberryPi/RPi3/RPi3.fdf | 9 ---------
 2 files changed, 12 deletions(-)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index f1143b1471..dcdfa10290 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -178,31 +178,28 @@ [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
   MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
   DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
 
 [LibraryClasses.common.DXE_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
   SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
 
 [LibraryClasses.common.UEFI_APPLICATION]
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
   FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
 
 [LibraryClasses.common.DXE_RUNTIME_DRIVER]
diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf
index 22813d453c..85f2187545 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.fdf
+++ b/Platform/RaspberryPi/RPi3/RPi3.fdf
@@ -386,19 +386,10 @@ [Rule.Common.PEIM]
      PEI_DEPEX PEI_DEPEX Optional       $(INF_OUTPUT)/$(MODULE_NAME).depex
      TE       TE Align = Auto           $(INF_OUTPUT)/$(MODULE_NAME).efi
      UI       STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [edk2-platforms] [patch v2 4/7] Platform/SoftIron: Update UefiDecompressLib instance
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
                   ` (2 preceding siblings ...)
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 3/7] Platform/RPi3: " Dandan Bi
@ 2019-05-08  2:00 ` Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 5/7] Silicon/Hisilicon: " Dandan Bi
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.

1. TIANOCOMPRESSED rule in fdf is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
3. A common UefiDecompressLib resolution can apply to
all module types now. So keep the common one in
[LibraryClasses.common] section and remove all others.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 5 -----
 .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf   | 9 ---------
 2 files changed, 14 deletions(-)

diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 4fbc4201cf..cc4f2facd0 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -168,11 +168,10 @@ [LibraryClasses.common.PEI_CORE]
   PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
 
@@ -184,22 +183,20 @@ [LibraryClasses.common.PEIM]
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
   PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
 
 [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
   MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
   DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
 
 [LibraryClasses.common.DXE_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
   SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
@@ -215,19 +212,17 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER]
 !if $(TARGET) != RELEASE
   DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
 !endif
 
 [LibraryClasses.common.UEFI_APPLICATION]
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
 
 [LibraryClasses.ARM]
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
index 0cf558e189..fa814880e0 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
@@ -323,19 +323,10 @@ [Rule.Common.PEIM.Binary]
      PEI_DEPEX PEI_DEPEX Optional       |.depex
      TE       TE Align = Auto           |.efi
      UI       STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [edk2-platforms] [patch v2 5/7] Silicon/Hisilicon: Update UefiDecompressLib instance
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
                   ` (3 preceding siblings ...)
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 4/7] Platform/SoftIron: " Dandan Bi
@ 2019-05-08  2:00 ` Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 6/7] Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule Dandan Bi
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.

1. TIANOCOMPRESSED rule in fdf is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
3. A common UefiDecompressLib resolution can apply to
all module types now. So keep the common one in
[LibraryClasses.common] section and remove all others.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 Silicon/Hisilicon/Hisilicon.dsc.inc | 5 -----
 Silicon/Hisilicon/Hisilicon.fdf.inc | 9 ---------
 2 files changed, 14 deletions(-)

diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index a2ade57451..8a9812b9ed 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -138,11 +138,10 @@ [LibraryClasses.common.PEI_CORE]
   PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
   PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
@@ -155,11 +154,10 @@ [LibraryClasses.common.PEIM]
   PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
   PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
 
   PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
 
   ## Fixed compile error after upgrade to 14.10
@@ -172,11 +170,10 @@ [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
   MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
   DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
   PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
 
 [LibraryClasses.common.DXE_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
@@ -184,11 +181,10 @@ [LibraryClasses.common.DXE_DRIVER]
   SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
 
 [LibraryClasses.common.UEFI_APPLICATION]
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLICATION]
@@ -196,11 +192,10 @@ [LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLICATION]
   ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
 
 [LibraryClasses.common.UEFI_DRIVER]
   ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
-  UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
   DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
 
diff --git a/Silicon/Hisilicon/Hisilicon.fdf.inc b/Silicon/Hisilicon/Hisilicon.fdf.inc
index 986dd75891..4699d80459 100644
--- a/Silicon/Hisilicon/Hisilicon.fdf.inc
+++ b/Silicon/Hisilicon/Hisilicon.fdf.inc
@@ -65,19 +65,10 @@ [Rule.Common.PEIM.BINARY]
      PEI_DEPEX PEI_DEPEX Optional       $(INF_OUTPUT)/$(MODULE_NAME).depex
      TE       TE Align = Auto           |.efi
      UI       STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.PEIM.FMP_IMAGE_DESC]
   FILE PEIM = $(NAMED_GUID) {
      RAW BIN                  |.acpi
      PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
      PE32      PE32      Align=4K        $(INF_OUTPUT)/$(MODULE_NAME).efi
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [edk2-platforms] [patch v2 6/7] Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
                   ` (4 preceding siblings ...)
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 5/7] Silicon/Hisilicon: " Dandan Bi
@ 2019-05-08  2:00 ` Dandan Bi
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 7/7] Platform: " Dandan Bi
  2019-05-08 18:02 ` [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Leif Lindholm
  7 siblings, 0 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

1. TIANOCOMPRESSED rule in fdf is not used, so remove it.
2. The common UefiDecompressLib resolution in
[LibraryClasses.common] section can apply to
all module types. Remove the additional one.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 -
 Silicon/Marvell/Armada7k8k/Armada7k8k.fdf     | 9 ---------
 2 files changed, 10 deletions(-)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 545b369f27..0cf5d8447a 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -188,11 +188,10 @@ [LibraryClasses.common.PEIM]
 [LibraryClasses.common.DXE_CORE]
   HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
   MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
   DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
-  UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
   DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
   PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
 
 [LibraryClasses.common.DXE_DRIVER]
   DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
index 3a320ba64d..8a050ef987 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
@@ -352,19 +352,10 @@ [Rule.Common.PEIM]
      PEI_DEPEX PEI_DEPEX Optional       $(INF_OUTPUT)/$(MODULE_NAME).depex
      TE       TE Align = Auto           $(INF_OUTPUT)/$(MODULE_NAME).efi
      UI       STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [edk2-platforms] [patch v2 7/7] Platform: Remove TIANOCOMPRESSED rule
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
                   ` (5 preceding siblings ...)
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 6/7] Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule Dandan Bi
@ 2019-05-08  2:00 ` Dandan Bi
  2019-05-08 18:02 ` [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Leif Lindholm
  7 siblings, 0 replies; 11+ messages in thread
From: Dandan Bi @ 2019-05-08  2:00 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722

TIANOCOMPRESSED rule in fdf is not used, so remove it.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 Platform/ARM/SgiPkg/SgiPlatform.fdf                      | 9 ---------
 Platform/Socionext/DeveloperBox/DeveloperBox.fdf         | 9 ---------
 .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf  | 9 ---------
 3 files changed, 27 deletions(-)

diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
index 3d450a8e28..b163dab5c3 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
+++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
@@ -292,19 +292,10 @@ [Rule.Common.PEIM]
      PEI_DEPEX PEI_DEPEX Optional       $(INF_OUTPUT)/$(MODULE_NAME).depex
      TE  TE Align = Auto                $(INF_OUTPUT)/$(MODULE_NAME).efi
      UI  STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
index e6b42fc202..5309a77c1a 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
@@ -440,19 +440,10 @@ [Rule.Common.PEIM]
      PEI_DEPEX PEI_DEPEX Optional       $(INF_OUTPUT)/$(MODULE_NAME).depex
      TE  TE Align = Auto                $(INF_OUTPUT)/$(MODULE_NAME).efi
      UI  STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
index 3f47781fe9..1e07f579a8 100644
--- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
+++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf
@@ -390,19 +390,10 @@ [Rule.Common.PEIM]
      PEI_DEPEX PEI_DEPEX Optional       $(INF_OUTPUT)/$(MODULE_NAME).depex
      TE  TE Align = Auto                $(INF_OUTPUT)/$(MODULE_NAME).efi
      UI  STRING="$(MODULE_NAME)" Optional
   }
 
-[Rule.Common.PEIM.TIANOCOMPRESSED]
-  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
-    PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-    GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
-      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
-      UI        STRING="$(MODULE_NAME)" Optional
-    }
-  }
-
 [Rule.Common.DXE_CORE]
   FILE DXE_CORE = $(NAMED_GUID) {
     PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING="$(MODULE_NAME)" Optional
   }
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance
  2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
                   ` (6 preceding siblings ...)
  2019-05-08  2:00 ` [edk2-platforms] [patch v2 7/7] Platform: " Dandan Bi
@ 2019-05-08 18:02 ` Leif Lindholm
  2019-05-09  0:43   ` Dandan Bi
  7 siblings, 1 reply; 11+ messages in thread
From: Leif Lindholm @ 2019-05-08 18:02 UTC (permalink / raw)
  To: Dandan Bi; +Cc: devel, Ard Biesheuvel, Michael D Kinney

On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
> 
> BaseUefiDecompressLib in MdePkg is the
> base UEFI decompress Library.
> BaseUefiTianoCustomDecompressLib in MdeModulePkg
> implements the base UEFI decompress functionality and
> Tiano decompress functionality.
> 
> 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf
> is not used, so remove it.
> 2. Platform doesn't use the TianoCompress, so do
> not have to use BaseUefiTianoCustomDecompressLib,
> can use the BaseUefiDecompressLib in MdePkg directly.
> 3. A common UefiDecompressLib resolution can apply to
> all module types now. So keep the common one in
> [LibraryClasses.common] section and remove all others.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Are you happy to push these yourself?

Final note - it would be even better if --stat=1000 and
--stat-graph-width=20 were also used, in accordance with
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
While we have a bug in upstream git that means the cover letter still
shows truncated paths, that resolves the problem for the actual
patches.

Best Regards,

Leif

> Dandan Bi (7):
>   Platform/AMD: Update UefiDecompressLib instance
>   Platform/LeMaker: Update UefiDecompressLib instance
>   Platform/RPi3: Update UefiDecompressLib instance
>   Platform/SoftIron: Update UefiDecompressLib instance
>   Silicon/Hisilicon: Update UefiDecompressLib instance
>   Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule
>   Platform: Remove TIANOCOMPRESSED rule
> 
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc           | 5 -----
>  Platform/AMD/OverdriveBoard/OverdriveBoard.fdf           | 9 ---------
>  Platform/ARM/SgiPkg/SgiPlatform.fdf                      | 9 ---------
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc               | 5 -----
>  Platform/LeMaker/CelloBoard/CelloBoard.fdf               | 9 ---------
>  Platform/RaspberryPi/RPi3/RPi3.dsc                       | 3 ---
>  Platform/RaspberryPi/RPi3/RPi3.fdf                       | 9 ---------
>  Platform/Socionext/DeveloperBox/DeveloperBox.fdf         | 9 ---------
>  .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf  | 9 ---------
>  .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 5 -----
>  .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf   | 9 ---------
>  Silicon/Hisilicon/Hisilicon.dsc.inc                      | 5 -----
>  Silicon/Hisilicon/Hisilicon.fdf.inc                      | 9 ---------
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc            | 1 -
>  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                | 9 ---------
>  15 files changed, 105 deletions(-)
> 
> -- 
> 2.18.0.windows.1
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance
  2019-05-08 18:02 ` [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Leif Lindholm
@ 2019-05-09  0:43   ` Dandan Bi
  2019-05-09 11:36     ` [edk2-devel] " Leif Lindholm
  0 siblings, 1 reply; 11+ messages in thread
From: Dandan Bi @ 2019-05-09  0:43 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: devel@edk2.groups.io, Ard Biesheuvel, Kinney, Michael D


> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Thursday, May 9, 2019 2:02 AM
> To: Bi, Dandan <dandan.bi@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib
> instance
> 
> On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
> >
> > BaseUefiDecompressLib in MdePkg is the base UEFI decompress Library.
> > BaseUefiTianoCustomDecompressLib in MdeModulePkg implements the
> base
> > UEFI decompress functionality and Tiano decompress functionality.
> >
> > 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf is not used, so remove
> > it.
> > 2. Platform doesn't use the TianoCompress, so do not have to use
> > BaseUefiTianoCustomDecompressLib, can use the BaseUefiDecompressLib
> in
> > MdePkg directly.
> > 3. A common UefiDecompressLib resolution can apply to all module types
> > now. So keep the common one in [LibraryClasses.common] section and
> > remove all others.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Are you happy to push these yourself?

Could you help to push them? Since I don't have the push rights.

Thanks,
Dandan
> 
> Final note - it would be even better if --stat=1000 and
> --stat-graph-width=20 were also used, in accordance with
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-
> guide-for-edk2-contributors-and-maintainers#contrib-23
> While we have a bug in upstream git that means the cover letter still shows
> truncated paths, that resolves the problem for the actual patches.
> 
> Best Regards,
> 
> Leif
> 
> > Dandan Bi (7):
> >   Platform/AMD: Update UefiDecompressLib instance
> >   Platform/LeMaker: Update UefiDecompressLib instance
> >   Platform/RPi3: Update UefiDecompressLib instance
> >   Platform/SoftIron: Update UefiDecompressLib instance
> >   Silicon/Hisilicon: Update UefiDecompressLib instance
> >   Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule
> >   Platform: Remove TIANOCOMPRESSED rule
> >
> >  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc           | 5 -----
> >  Platform/AMD/OverdriveBoard/OverdriveBoard.fdf           | 9 ---------
> >  Platform/ARM/SgiPkg/SgiPlatform.fdf                      | 9 ---------
> >  Platform/LeMaker/CelloBoard/CelloBoard.dsc               | 5 -----
> >  Platform/LeMaker/CelloBoard/CelloBoard.fdf               | 9 ---------
> >  Platform/RaspberryPi/RPi3/RPi3.dsc                       | 3 ---
> >  Platform/RaspberryPi/RPi3/RPi3.fdf                       | 9 ---------
> >  Platform/Socionext/DeveloperBox/DeveloperBox.fdf         | 9 ---------
> >  .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf  | 9 ---------
> >  .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 5 -----
> >  .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf   | 9 ---------
> >  Silicon/Hisilicon/Hisilicon.dsc.inc                      | 5 -----
> >  Silicon/Hisilicon/Hisilicon.fdf.inc                      | 9 ---------
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc            | 1 -
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                | 9 ---------
> >  15 files changed, 105 deletions(-)
> >
> > --
> > 2.18.0.windows.1
> >

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [edk2-devel] [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance
  2019-05-09  0:43   ` Dandan Bi
@ 2019-05-09 11:36     ` Leif Lindholm
  0 siblings, 0 replies; 11+ messages in thread
From: Leif Lindholm @ 2019-05-09 11:36 UTC (permalink / raw)
  To: devel, dandan.bi; +Cc: Ard Biesheuvel, Kinney, Michael D

On Thu, May 09, 2019 at 12:43:15AM +0000, Dandan Bi wrote:
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > 
> > For the series:
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > 
> > Are you happy to push these yourself?
> 
> Could you help to push them? Since I don't have the push rights.

Sure. Series pushed as d83f1ca097..c08d3d0931.
Thanks!

/
    Leif

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-05-09 11:36 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-08  2:00 [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Dandan Bi
2019-05-08  2:00 ` [edk2-platforms] [patch v2 1/7] Platform/AMD: " Dandan Bi
2019-05-08  2:00 ` [edk2-platforms] [patch v2 2/7] Platform/LeMaker: " Dandan Bi
2019-05-08  2:00 ` [edk2-platforms] [patch v2 3/7] Platform/RPi3: " Dandan Bi
2019-05-08  2:00 ` [edk2-platforms] [patch v2 4/7] Platform/SoftIron: " Dandan Bi
2019-05-08  2:00 ` [edk2-platforms] [patch v2 5/7] Silicon/Hisilicon: " Dandan Bi
2019-05-08  2:00 ` [edk2-platforms] [patch v2 6/7] Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule Dandan Bi
2019-05-08  2:00 ` [edk2-platforms] [patch v2 7/7] Platform: " Dandan Bi
2019-05-08 18:02 ` [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Leif Lindholm
2019-05-09  0:43   ` Dandan Bi
2019-05-09 11:36     ` [edk2-devel] " Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox