From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=GgYGjW/g; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Wed, 08 May 2019 02:01:32 -0700 Received: by mail-wm1-f66.google.com with SMTP id o25so2218494wmf.2 for ; Wed, 08 May 2019 02:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hi5As3mO1x/t4uyx1WTMrTwxsoGlXBPaJVAz8pQRn7o=; b=GgYGjW/gbUsJaLN5LLPXstqOfZZJcYvIcDntQ+cwe2QHx2unyr0BYizFkVDDSDyQAb 5216H/iam3mQcCVi6kT76DGGFiseETC2l0/m9iun0rLyZ0yYJPYnj3KVyqJ2E2SM4szT wmCL5ThFJWckJ3KWcmm+mrxWYjErdpOYArO9DxUJEqnSktBTbiW5T7rteOIFtPvlY4VP Zl/1LkYW2dD+miOOdaiS1CvR4KfF77vJq5qmHvRYz6l5sJnrmwnha5O9UccR8oSTSBU/ UpBud4aBWGUfyK5ntQzCpDyHxjCzb0Ilxl5PSO389Kixp0XpnWnFzmMu+bJAOFrxA+9d Hd/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hi5As3mO1x/t4uyx1WTMrTwxsoGlXBPaJVAz8pQRn7o=; b=HWVF6GTLa+yZF4qDc1QdMWWV58MGXOWLPMfl0c8rbJYv9jwdqWY2WnbmppFmOHJN3n G85wat7OlkFXZfjrOOv2ZTyFp00QbqUcFJE7+c3xrbFX2mYmBJx3QrjWICH7CSe51GWL URXUJ0/I42WGu8LaSoSThgRWeAJcPCI0cD0eMekjrlPPJoiXmiZKbI4yiXBoMmwT3I3q +oqRsUnvxYLE06hJt+fOm3R6phF836KFvHpMjKMbCBm6j0G0O98QEtAXxf0bvRzwDrGg wFqtr50SuDNeI3pzVshwzj4BG3IuKtvMqcY+KgiYioKvU2ZRtzoacbjeexFTtW2rP3vB iBKQ== X-Gm-Message-State: APjAAAUHRBJzsAu9vHp8fYNHoAxD1Qrtyn33TL/kMqV37U/+sfmjDC7I 6QSxH+uGn2IDTs/aB3J6+IuGmA== X-Google-Smtp-Source: APXvYqxDkUOaXXtLBO1D/I5nTBH74BKGm6Ct3dYaCZAutOpE/8jLVFlX6GtrLguIIarGLJ1s2kbfbA== X-Received: by 2002:a05:600c:3d1:: with SMTP id z17mr2159478wmd.27.1557306090912; Wed, 08 May 2019 02:01:30 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g10sm14700019wrq.2.2019.05.08.02.01.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 02:01:30 -0700 (PDT) Date: Wed, 8 May 2019 10:01:28 +0100 From: "Leif Lindholm" To: Thomas Abraham Cc: Sami Mujawar , "Fan, ZhijuX" , "devel@edk2.groups.io" , "Cohen, Eugene" , nd Subject: Re: [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from ArmPlatformPkg Message-ID: <20190508090128.3aargn6bm73xgq6u@bivouac.eciton.net> References: <20190507093045.g2w6dzmkqrq26g3l@bivouac.eciton.net> <1d59c35c-dc10-bd50-777a-85d9d88d29ac@arm.com> MIME-Version: 1.0 In-Reply-To: <1d59c35c-dc10-bd50-777a-85d9d88d29ac@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Thomas, On Wed, May 08, 2019 at 06:11:18AM +0000, Thomas Abraham wrote: > > We do not use this file and am ok if this is removed. However, I will let Thomas confirm this. > > This makefile is not used for ARM platforms (FVP, Juno, SGI, RD) and so > this makefile can be removed. Excellent, thanks. Could I be awkward enough to ask you to send a patch to do so, since Ard is out this week and I don't review my own patches? Regards, Leif > Thanks, > Thomas. > > > > > Regards, > > > > Sami Mujawar > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: 07 May 2019 10:31 AM > > To: Fan, ZhijuX > > Cc: devel@edk2.groups.io; Thomas Abraham ; Sami Mujawar ; Cohen, Eugene > > Subject: Re: [PATCH 3/3] ArmPlatformPkg:Delete FrameworkDatabase from ArmPlatformPkg > > > > On Mon, May 06, 2019 at 09:20:12AM +0000, Fan, ZhijuX wrote: > >> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627 > >> > >> The FrameworkDatabase was already obsolete, So, FrameworkDatabase can > >> be removed from ArmPlatformPkg. > >> > >> This patch is going to fix this issue. > >> > >> Cc: Leif Lindholm > >> Cc: Ard Biesheuvel > >> Signed-off-by: Zhiju.Fan > > > > So, first of all: > > Reviewed-by: Leif Lindholm > > > > Hmm. I wonder if anyone actually uses this Makefile at all since we moved the platforms out. Thomas? Sami? Eugene? > > > > Best Regards, > > > > Leif > > > >> --- > >> ArmPlatformPkg/Scripts/Makefile | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/ArmPlatformPkg/Scripts/Makefile > >> b/ArmPlatformPkg/Scripts/Makefile index 09f1c90923..76f25e35e8 100644 > >> --- a/ArmPlatformPkg/Scripts/Makefile > >> +++ b/ArmPlatformPkg/Scripts/Makefile > >> @@ -65,7 +65,6 @@ endif > >> $(EDK2_CONF): > >> ifeq ("$(OS)","Windows_NT") > >> copy $(EDK_TOOLS_PATH)\Conf\build_rule.template Conf\build_rule.txt > >> -copy $(EDK_TOOLS_PATH)\Conf\FrameworkDatabase.template Conf\FrameworkDatabase.txt > >> copy $(EDK_TOOLS_PATH)\Conf\target.template Conf\target.txt > >> copy $(EDK_TOOLS_PATH)\Conf\tools_def.template Conf\tools_def.txt > >> else > >> -- > >> 2.14.1.windows.1 > >> > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.