From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=B9j00hPr; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Wed, 08 May 2019 02:09:30 -0700 Received: by mail-wm1-f66.google.com with SMTP id 198so2239331wme.3 for ; Wed, 08 May 2019 02:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kI3YVgmHFiguv8HPkvjjX1cABYdLCT65/K5+B8D4mqo=; b=B9j00hPrlEdZGQvJq2LTfV+je5Dd6Cvc/iS2adNXC/hfKW9zIEU19DZQOUNIR5AG/9 LK3+zGcg+8gusOj321TLI4WlEtLrpManskACqJaOyYv9WhXm+QnJIF6BlCfcMp0JLu8m kuZKmDT7mBTztnTOhXbahvz9diChTDdleDlyYpif+bqHZmyDJcG+EibceiNJPbQR6e+G 4c45SsqLY7kWy+3BhHgTfN7hYocSIRPEDlftCzRcrJowk3jqTmihF5w6Wk+ZdllF08sj SS8j4mebkW/m2+gFJNR/D2f10286zMcLeCe4T8dFveRVEtBOdxaiAKl5p4/5Yd532nbz FVbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kI3YVgmHFiguv8HPkvjjX1cABYdLCT65/K5+B8D4mqo=; b=A9N2P8hYqWxgMHkiwPcJu9zEn7FJNwVaua+GCHcZkBF8duOTYCU1cdIM6LlFw5/FSP WglI0CFtiIgcKp0/hNqYxm8eb8eHlIX90Or8DiK1Ry3jCW5Gc/YY5VWtkLmKXYS8HpTo Vj/RQRczSLo1CNoXEMaPd00/TNuPP7wLC1ugflSNdIw7/rrdEjSWLDM6PPRCH8NXvwso Wcq3vGZ3a+2ldN/9Y55288Q46G5jyS7H72xAvqTmaOSKTCn+joIPgtypczrioFHx67Zs 5uuxk5XeoNcBputVhd7SX0zSubqG8hwnxkGCeybK0FvxJEd4wGMiJYajKf9gTDuimzm9 oxHQ== X-Gm-Message-State: APjAAAWhTG4ZufjY+qPIOLC+PSfJZqU2IygqBulosXIe3WLtQv7zki4m CHI76E49rm+ebvBrsUt7H0RVsw== X-Google-Smtp-Source: APXvYqyNTZv2uHSYehXCIXgXANCoJH44StFnP0KhjV1yLoUKhq9dSwXlcyFMwzOM/j0DFwwePwQlwg== X-Received: by 2002:a7b:c04b:: with SMTP id u11mr2075874wmc.95.1557306568700; Wed, 08 May 2019 02:09:28 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j4sm8141170wrw.94.2019.05.08.02.09.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 02:09:28 -0700 (PDT) Date: Wed, 8 May 2019 10:09:26 +0100 From: "Leif Lindholm" To: Andrew Fish Cc: devel@edk2.groups.io, zhijux.fan@intel.com, "Gao, Liming" , "Feng, Bob C" Subject: Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes Message-ID: <20190508090926.4r4e6jqlg45yg6yp@bivouac.eciton.net> References: <5C1A24BA-648D-4A3F-AE88-034073AB5C13@apple.com> <20190507144002.gq3rdtappd3rupmd@bivouac.eciton.net> <55FC6AA1-43B5-4557-8A17-0E3B00E3EE9A@apple.com> MIME-Version: 1.0 In-Reply-To: <55FC6AA1-43B5-4557-8A17-0E3B00E3EE9A@apple.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 07, 2019 at 07:01:26PM -0700, Andrew Fish wrote: > > > > On May 7, 2019, at 7:40 AM, Leif Lindholm wrote: > > > > Hi Fan Zhiju, > > > > But where does the string come from that contains a .C suffix? > > Is the tool internally converting things to uppercase, or is some > > source file in the build incorrectly named? > > > > Leif, > > Our build system defines .C as correct! I think it has been that way a very long time. .C is valid, but at least for GCC it is equivalent to all of the other non-.c options - i.e., interpret as c++. Which is why I am wondering about the case that ends up with the build system internally processing this. If it is changed to permitting .C files to be compiled as C instead of C++ (which the patch seems to imply), that sounds incorrect to me. / Leif > https://github.com/tianocore/edk2/blob/master/BaseTools/Conf/build_rule.template#L109 > > [C-Code-File] > > ?.c > ?.C > ?.cc > ?.CC > ?.cpp > ?.Cpp > ?.CPP > > Thanks, > > Andrew Fish > > > > I am asking because it is not clear to me whether the patch resolves a > > problem or hides one. > > > > Best Regards, > > > > Leif > > > > On Tue, May 07, 2019 at 03:05:02AM +0000, Fan, ZhijuX wrote: > >> This problem has nothing to do with the file system, We just use the > >> filename as a string to compare with other strings > >> Our unittest tested minplatform, Ovmf. This problem was found when > >> building a platform inside Intel. > >> We've tested it on Linux and Windows. > >> > >> Any question, please let me know. Thanks. > >> > >> Best Regards > >> Fan Zhiju > >> > >> -----Original Message----- > >> From: afish@apple.com [mailto:afish@apple.com] > >> Sent: Tuesday, May 7, 2019 10:31 AM > >> To: devel@edk2.groups.io; Fan, ZhijuX > >> Cc: Gao, Liming ; Feng, Bob C > >> Subject: Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes > >> > >> This brings up a question? Do we tests on a file system that is case sensitive? Is this just lack of a test case? > >> > >> Thanks, > >> > >> Andrew Fish > >> > >>> On May 6, 2019, at 7:22 PM, Fan, ZhijuX wrote: > >>> > >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1773 > >>> > >>> Build break if C file suffixes of named .C instead of .c Code not > >>> recognize filenames with .C suffixes. > >>> > >>> This patch adds code to Support both .c file and .C file > >>> > >>> Cc: Bob Feng > >>> Cc: Liming Gao > >>> Signed-off-by: Zhiju.Fan > >>> --- > >>> BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py > >>> b/BaseTools/Source/Python/AutoGen/GenMake.py > >>> index 0e0f9fd9b0..858ddedf8e 100644 > >>> --- a/BaseTools/Source/Python/AutoGen/GenMake.py > >>> +++ b/BaseTools/Source/Python/AutoGen/GenMake.py > >>> @@ -1035,7 +1035,8 @@ cleanlib: > >>> CmdTargetDict[CmdSign] = "%s %s" % (CmdTargetDict[CmdSign], SingleCommandList[-1]) > >>> Index = CommandList.index(Item) > >>> CommandList.pop(Index) > >>> - if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, CmdSumDict[CmdSign.lstrip('/Fo').rsplit(TAB_SLASH, 1)[0]])): > >>> + if SingleCommandList[-1].endswith("%s%s.c" % (TAB_SLASH, CmdSumDict[T.Target.SubDir])) or \ > >>> + SingleCommandList[-1].endswith("%s%s.C" % (TAB_SLASH, CmdSumDict[T.Target.SubDir])): > >>> Cpplist = CmdCppDict[T.Target.SubDir] > >>> Cpplist.insert(0, '$(OBJLIST_%d): $(COMMON_DEPS)' % list(self.ObjTargetDict.keys()).index(T.Target.SubDir)) > >>> T.Commands[Index] = '%s\n\t%s' % (' > >>> \\\n\t'.join(Cpplist), CmdTargetDict[CmdSign]) > >>> -- > >>> 2.14.1.windows.1 > >>> > >>> > >>> > >>> > >>> > >> > >> > >> > >> > > > > >