From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector1-arm-com header.b=guxTiv8c; spf=pass (domain: arm.com, ip: 40.107.15.80, mailfrom: krzysztof.koch@arm.com) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.80]) by groups.io with SMTP; Wed, 08 May 2019 06:14:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KvAB/p899u+Hh/BJ0oxW0YW+xA1a35e11ai8buWJiKg=; b=guxTiv8cmEMqYlENNTgdTxvsBcRhk5WAfg2YOR9z77nEZ+r0QhCLdUF5C6jiic6+Yx99LFGinWfz4FNRFzSBrOlB68SWbFDvBDnejI2xcv5tDj+Gvd1YqVZ7W4Rc0zF9lPv34MPetezzaLTPNjsRF8BXjEFGH1do7OIjmn88qbk= Received: from VI1PR0802CA0001.eurprd08.prod.outlook.com (2603:10a6:800:aa::11) by AM5PR0802MB2481.eurprd08.prod.outlook.com (2603:10a6:203:a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.20; Wed, 8 May 2019 13:14:15 +0000 Received: from AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::203) by VI1PR0802CA0001.outlook.office365.com (2603:10a6:800:aa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1856.10 via Frontend Transport; Wed, 8 May 2019 13:14:14 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT048.mail.protection.outlook.com (10.152.17.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.1856.11 via Frontend Transport; Wed, 8 May 2019 13:14:13 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Wed, 8 May 2019 13:14:01 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Wed, 8 May 2019 13:14:00 +0000 Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Wed, 8 May 2019 13:13:59 +0000 From: "Krzysztof Koch" To: CC: , , , , , , , Subject: [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT Date: Wed, 8 May 2019 14:13:54 +0100 Message-ID: <20190508131354.59672-1-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 Return-Path: Krzysztof.Koch@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(39860400002)(396003)(376002)(136003)(2980300002)(199004)(189003)(40434004)(6306002)(86362001)(51416003)(305945005)(14444005)(72206003)(48376002)(2616005)(53416004)(478600001)(476003)(336012)(50466002)(8676002)(5024004)(63370400001)(63350400001)(2906002)(77096007)(7696005)(426003)(81156014)(81166006)(26005)(5660300002)(36756003)(50226002)(1076003)(70586007)(70206006)(6666004)(4326008)(6916009)(47776003)(2351001)(356004)(68736007)(8746002)(54906003)(8936002)(486006)(186003)(53936002)(126002)(316002)(966005)(44832011);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0802MB2481;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49f8b363-c976-4368-1a79-08d6d3b710c8 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328);SRVR:AM5PR0802MB2481; X-MS-TrafficTypeDiagnostic: AM5PR0802MB2481: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 0031A0FFAF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: GB2JvxvBYQ63cC5TZcL7mWKflNeOW+RbTcD35DbXbhYQvcu2NP75bqOnm/icSf/ne3Q8bXSQtCVhqC/rEL7gYi/Zku1hWSsBiHDpDoi9Inu3MgPaBh1SrLvojKpTIIslU73tg+yF/MVEA+h4KJt3UhvTIkembceiEigOPGkLwTFSJlTRqTtRqMR7sBIZgtG4Z/m1ELXWF/+xAdrBhLEAls/ly/+t9qYAyqZ3zCN0BNKu2UaMwZB1qWaajNfh7BiyUd9zDqUSBrALT4B8jLxkLNAx6xgFzvTmCbD4VQvY554jw3SIow/LaETtzc3d7LEaxz0Zz26o4QTzEEvyleHxL1+3xd3HD2U2pXXyvxlw6VRXFvhFJV31OiKzy83s1IS2k+zCNlgdt+PBejOP9MWAMnygFYtsbtMpUAVycSdw06w= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2019 13:14:13.2538 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49f8b363-c976-4368-1a79-08d6d3b710c8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2481 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable The ID Type Structure (Type 2) inside the Processor Properties Topology Table (PPTT) has a VENDOR_ID field which identifies the node vendor. The approved values are listed in the ACPI ID Registry and they are meant to be interpreted as arrays of ASCII characters. This change to the acpiview parser for PPTT aims to reflect that. Signed-off-by: Krzysztof Koch --- The changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/woa= _500_print_vendor_id_ascii_v1 Notes: v1: - Display VENDOR_ID in ASCII [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 2= +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/Pptt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPa= rser.c index c6588a12b4639f2bf6f0953d98410befbab66e31..ffcc53cda7d8df1d2f0787c1b4b= 1d30de87ac854 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c @@ -150,7 +150,7 @@ STATIC CONST ACPI_PARSER IdStructureParser[] =3D { {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL}, - {L"VENDOR_ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, + {L"VENDOR_ID", 4, 4, NULL, Dump4Chars, NULL, NULL, NULL}, {L"LEVEL_1_ID", 8, 8, L"0x%x", NULL, NULL, NULL, NULL}, {L"LEVEL_2_ID", 8, 16, L"0x%x", NULL, NULL, NULL, NULL}, {L"MAJOR_REV", 2, 24, L"0x%x", NULL, NULL, NULL, NULL}, -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.