From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=dMG9oVrJ; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Wed, 08 May 2019 10:52:42 -0700 Received: by mail-wm1-f67.google.com with SMTP id y5so4347179wma.2 for ; Wed, 08 May 2019 10:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bR62PVUtXfpeRy8udc/ap/c26URd4hOXMZ6do9H75WY=; b=dMG9oVrJRtReE4vQ/eICFaQCvOVcTHx4aEwoaCFw+CHn2ApaUfI09aoW92VCf1E9Se OO7jJSh8JUmifGQyU7+6hGoQqprsp4X88nlW0J1OyneXK7h1X2saHVDk8Bt8kbxoPh99 Zl2inFRUOlnN1EpMmuu6NDSRhAy1xgGqUPVyZi4FqLWoiECtxVbdzlxEmQIEP80D+umP /KSONyEyVvqBjmWDJ9l2a505b0E0MBw6Cyr4pnM+hsZ3ttjkSeEbUKS9xQ4g+3xVpopH XUe+oHBXJkEgNH7NLJPdHBpgoO61lcMZ1NB6eJnD3Wf3jHOWBw7O1zW09Kt0h8uwxiGf bEQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bR62PVUtXfpeRy8udc/ap/c26URd4hOXMZ6do9H75WY=; b=AFEs6nFr5Q8e9ZznOhAdqA+cajDMzmlhWX70q25qJ2mkHNImjIepOdUQQjT1fUGDeV LNtnxwxvoNh9XCcBPUm/NF2S4Ft/UVWTL0gypsTUF7Nvqbv8umKsCDzH+1UGgfln4XRy AkS8K2iBAYnlWKUJyJLVcyXYBtvdH6M6OUkSKemVdNxdHR4n+vtMxerNWjPHOuhQbJNx 4tAzu/thOTktvbwb4zQOz0tIUT/s3pTDUgfOp0jPADDEwuzV3pBo/IZe3vqvpp6arVOJ IOAkZG2WMbK7zCxx4alVufAj2UDz7Ezqa9X8IZCsdSDPzacX/OM6y+wZAfiwoiPqKDuk eVkQ== X-Gm-Message-State: APjAAAUK7YAx0lyhiTs6L11W1K6ouHojx1IuEd+bNg8sUfBcCgB2smmn j1ZDq7BWpu+MLJQGsfxKT3A4zg== X-Google-Smtp-Source: APXvYqxqYvi2rzB27uDKmj/M7K92Ejy0mWbhkDGxuuMwXT7GHklpqLj13ah+xdmJGZE68GvjD5ONEw== X-Received: by 2002:a05:600c:205a:: with SMTP id p26mr3785575wmg.11.1557337960583; Wed, 08 May 2019 10:52:40 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z9sm2235793wma.39.2019.05.08.10.52.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 10:52:39 -0700 (PDT) Date: Wed, 8 May 2019 18:52:38 +0100 From: "Leif Lindholm" To: Marcin Wojtas Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com, Jici.Gao@arm.com Subject: Re: [edk2-platforms: PATCH v2 0/4] Armada 7k8k network improvements Message-ID: <20190508175238.tqecoxlm74x2g2fm@bivouac.eciton.net> References: <1557110227-31466-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1557110227-31466-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 06, 2019 at 04:37:03AM +0200, Marcin Wojtas wrote: > Hi, > > The second version of the patchset addresses all comments from > v1 review. Details can be found in a changelog below. > > The purpose of this patchset is to fix possible hangs when attempting > to PXE boot on unconnected interfaces (1/4). Patches 2-3/4 > extend MvPhyDxe with support for another Marvell PHY model (88E1112). > The last patch is a small fix, removing redundancy of soft resetting > of the network PHYs during initialization. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190506 > > I'm looking forward to your comments or remarks. For series Reviewed-by: Leif Lindholm I added Ard's Acked-by to 3-4/4 which he expressed acceptance of before. Pushed as 747e75cc3e..d83f1ca097. I will add that while compile testing this set with clang, I came a cross a compilation error: /work/git/edk2-platforms/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c:1083:6: error: variable 'NumBytes' is uninitialized when used here [-Werror,-Wuninitialized] *NumBytes = FlashInstance->FvbSize; It is also reproducible with GCC, but only when building NOOPT. This change was introduced by cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode"). Could you provide a fix for that please? Best Regards, Leif > Best regards, > Marcin > > Changelog: > v1 -> v2: > * 1/4 > - change SB in commit message > - add STATIC > - add full error handling for Snp.GetStatus in Pp2AipGetInformation > - use normal 'if' instead of ternary in Pp2AipGetInformation > - fix typos in comments > - use AllocatePool and CopyGuid in Pp2AipGetSupportedTypes > > * 2/4 > - Add space in gBS->Stall call > - s/Improve/Refactor/ in commit message > > Marcin Wojtas (3): > Marvell/Drivers: MvPhyDxe: Refactor 88E1510 initialization > Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization > Marvell/Drivers: MvPhyDxe: Reset PHY only once > > Tomasz Michalec (1): > Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol > > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 1 + > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h | 17 +- > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h | 3 + > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 111 +++++++++---- > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 166 ++++++++++++++++++++ > Silicon/Marvell/Documentation/PortingGuide.txt | 7 +- > 6 files changed, 274 insertions(+), 31 deletions(-) > > -- > 2.7.4 >