Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
> 
> BaseUefiDecompressLib in MdePkg is the
> base UEFI decompress Library.
> BaseUefiTianoCustomDecompressLib in MdeModulePkg
> implements the base UEFI decompress functionality and
> Tiano decompress functionality.
> 
> 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf
> is not used, so remove it.
> 2. Platform doesn't use the TianoCompress, so do
> not have to use BaseUefiTianoCustomDecompressLib,
> can use the BaseUefiDecompressLib in MdePkg directly.
> 3. A common UefiDecompressLib resolution can apply to
> all module types now. So keep the common one in
> [LibraryClasses.common] section and remove all others.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Are you happy to push these yourself?

Final note - it would be even better if --stat=1000 and
--stat-graph-width=20 were also used, in accordance with
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
While we have a bug in upstream git that means the cover letter still
shows truncated paths, that resolves the problem for the actual
patches.

Best Regards,

Leif

> Dandan Bi (7):
>   Platform/AMD: Update UefiDecompressLib instance
>   Platform/LeMaker: Update UefiDecompressLib instance
>   Platform/RPi3: Update UefiDecompressLib instance
>   Platform/SoftIron: Update UefiDecompressLib instance
>   Silicon/Hisilicon: Update UefiDecompressLib instance
>   Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule
>   Platform: Remove TIANOCOMPRESSED rule
> 
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc           | 5 -----
>  Platform/AMD/OverdriveBoard/OverdriveBoard.fdf           | 9 ---------
>  Platform/ARM/SgiPkg/SgiPlatform.fdf                      | 9 ---------
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc               | 5 -----
>  Platform/LeMaker/CelloBoard/CelloBoard.fdf               | 9 ---------
>  Platform/RaspberryPi/RPi3/RPi3.dsc                       | 3 ---
>  Platform/RaspberryPi/RPi3/RPi3.fdf                       | 9 ---------
>  Platform/Socionext/DeveloperBox/DeveloperBox.fdf         | 9 ---------
>  .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf  | 9 ---------
>  .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 5 -----
>  .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf   | 9 ---------
>  Silicon/Hisilicon/Hisilicon.dsc.inc                      | 5 -----
>  Silicon/Hisilicon/Hisilicon.fdf.inc                      | 9 ---------
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc            | 1 -
>  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                | 9 ---------
>  15 files changed, 105 deletions(-)
> 
> -- 
> 2.18.0.windows.1
>