From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=WLroFQ5V; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Wed, 08 May 2019 11:02:09 -0700 Received: by mail-wm1-f68.google.com with SMTP id j187so4388346wmj.1 for ; Wed, 08 May 2019 11:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KR/IUh92J5OwybytCg3GiijxsqjsrZ4Rj7y93SZahKA=; b=WLroFQ5VZVbFy+3Zm7t8qKUwgRNBCz5xUTVXFxf7DtR3xBSkP+CxXmTk6mvGIvmuZM JEubrXkEFJ8O8Gh/DaDk7JhEIHWQa/fEr4WR6Aa2aPC3KcoUDUR60oCERXb2fXSpds2A A5zo+S14fLazZdjMcXk9l++Bix+TqH1UkMsCVjHJ/1NJszZPJ00GsG9PUbs7IMRblXAJ n2YdIiE4WNeGYNYDJ97TfpdiZHXtNmR9DSf2dlS73t5v8YgTJBj7IacFbA6wDjy/h4ZE nMpPrwvKKUVmLGvFwlGsqk2AEvaV1CdcVV0usrSYhb69bjaUhsTndS4jJzxHYqS0h9zW kD4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KR/IUh92J5OwybytCg3GiijxsqjsrZ4Rj7y93SZahKA=; b=W7uIj0T+KavIfJmMn3u6fgnzasaeBxZQSJFu6iRHT+WYzokTKfjDGjrMwMrA0rtTyi IGvV8KkzxCbXR+rCHxz5x0Y0OCaXELgqDiX8HHVFWDDw1z4+cE31aggKmPplUnvezcnj l1ITraE4kBrGn6a6s2y97r8jm9Hkhc1nGED/QZ1ug5VSPHHgi2tn1hoxPK1GQdlOpHR7 oAXI+jSX+0g9sRS0Wqh75/UJ/ASJq7FTuNXUhNkqOulUOAvfHwWBUNdedvxpdGuP1OVG dlLqRZ8+NsJni87PMdLRG80R/qq3bUNSg949SeYg1kvRho6sAj7CSIMRlYj8ZkL+fIN3 +7sw== X-Gm-Message-State: APjAAAXnquM6V3mJdpLutb4hY/p19zXcFXDKkwhvDMniCU/8J5VQziNc WX6sJozZu7OfjZVOKwvbhrdDtA== X-Google-Smtp-Source: APXvYqx5Z0yFJIb1QeVyjxsfzBsCqOkQQ63J9l1je+071vS5e4wnJnQO4dyRvMY3GmJqzPS3gKB9dw== X-Received: by 2002:a7b:c353:: with SMTP id l19mr3841818wmj.12.1557338527911; Wed, 08 May 2019 11:02:07 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a15sm3921128wru.88.2019.05.08.11.02.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 11:02:07 -0700 (PDT) Date: Wed, 8 May 2019 19:02:05 +0100 From: "Leif Lindholm" To: Dandan Bi Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Message-ID: <20190508180205.qemhakgnhsksk3l3@bivouac.eciton.net> References: <20190508020031.28436-1-dandan.bi@intel.com> MIME-Version: 1.0 In-Reply-To: <20190508020031.28436-1-dandan.bi@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722 > > BaseUefiDecompressLib in MdePkg is the > base UEFI decompress Library. > BaseUefiTianoCustomDecompressLib in MdeModulePkg > implements the base UEFI decompress functionality and > Tiano decompress functionality. > > 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf > is not used, so remove it. > 2. Platform doesn't use the TianoCompress, so do > not have to use BaseUefiTianoCustomDecompressLib, > can use the BaseUefiDecompressLib in MdePkg directly. > 3. A common UefiDecompressLib resolution can apply to > all module types now. So keep the common one in > [LibraryClasses.common] section and remove all others. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney For the series: Reviewed-by: Leif Lindholm Are you happy to push these yourself? Final note - it would be even better if --stat=1000 and --stat-graph-width=20 were also used, in accordance with https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 While we have a bug in upstream git that means the cover letter still shows truncated paths, that resolves the problem for the actual patches. Best Regards, Leif > Dandan Bi (7): > Platform/AMD: Update UefiDecompressLib instance > Platform/LeMaker: Update UefiDecompressLib instance > Platform/RPi3: Update UefiDecompressLib instance > Platform/SoftIron: Update UefiDecompressLib instance > Silicon/Hisilicon: Update UefiDecompressLib instance > Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule > Platform: Remove TIANOCOMPRESSED rule > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 ----- > Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 --------- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 9 --------- > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 5 ----- > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 9 --------- > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 --- > Platform/RaspberryPi/RPi3/RPi3.fdf | 9 --------- > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 9 --------- > .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 9 --------- > .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 5 ----- > .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 9 --------- > Silicon/Hisilicon/Hisilicon.dsc.inc | 5 ----- > Silicon/Hisilicon/Hisilicon.fdf.inc | 9 --------- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 - > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 9 --------- > 15 files changed, 105 deletions(-) > > -- > 2.18.0.windows.1 >