From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org,
jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com,
Jici.Gao@arm.com
Subject: Re: [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error
Date: Thu, 9 May 2019 13:35:25 +0100 [thread overview]
Message-ID: <20190509123525.uespe54livtrkpgc@bivouac.eciton.net> (raw)
In-Reply-To: <1557357861-14472-1-git-send-email-mw@semihalf.com>
On Thu, May 09, 2019 at 01:24:21AM +0200, Marcin Wojtas wrote:
> Commit cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode)
> introduced a compilation error, visible with certain toolchains.
> Fix that.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e284bb9226.
Thanks for quick turnaround.
> ---
> Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
> index b4fd29c..62f9e57 100644
> --- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
> +++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
> @@ -1003,7 +1003,6 @@ MvFvbConfigureFlashInstance (
> )
> {
> EFI_STATUS Status;
> - UINTN *NumBytes;
> UINTN DataOffset;
> UINTN VariableSize, FtwWorkingSize, FtwSpareSize, MemorySize;
>
> @@ -1080,10 +1079,9 @@ MvFvbConfigureFlashInstance (
> DataOffset = GET_DATA_OFFSET (FlashInstance->FvbOffset,
> FlashInstance->StartLba,
> FlashInstance->Media.BlockSize);
> - *NumBytes = FlashInstance->FvbSize;
> Status = FlashInstance->SpiFlashProtocol->Read (&FlashInstance->SpiDevice,
> DataOffset,
> - *NumBytes,
> + FlashInstance->FvbSize,
> (VOID *)FlashInstance->RegionBaseAddress);
> if (EFI_ERROR (Status)) {
> goto ErrorFreeAllocatedPages;
> --
> 2.7.4
>
prev parent reply other threads:[~2019-05-09 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 23:24 [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error Marcin Wojtas
2019-05-09 12:35 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509123525.uespe54livtrkpgc@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox