From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=AcFzhA8T; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Thu, 09 May 2019 05:35:29 -0700 Received: by mail-wm1-f65.google.com with SMTP id s18so4109872wmh.0 for ; Thu, 09 May 2019 05:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JU38+qwdRwiug0loy5A3YdcasPKMs32ZdJb9t+i9BJ0=; b=AcFzhA8TtaJRs+TL4doAqFIrrvPM7dPBD0Mq9PDLRK9tcRXhohHN/YWWUSc97xYB9f NwCkfCpEEoaNQ95Yb/VYFfc/zfasP4F/jt8/XawWlNed/IieqCGdrdxnpghD3AcizU95 DPKDcBSTdj4guMEiQZSWKdDRvZIv8cBYBIw0mAL8pEGs6mhSCdprXkwnPicPEg7UCeTU rhE74XjWe2Pz38x1Wb0zb4tglY9b5tpDRk+tvc9s5DUcSsD2xUYlXUXZgZ08DZx/o8Gd aW1+Eg286838sbZieFNpuQOgUDuZeAGDQYcee+4UJTNBnLx5Rb204Ib6tUPi975UBgRf FseA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JU38+qwdRwiug0loy5A3YdcasPKMs32ZdJb9t+i9BJ0=; b=JAjT6HWj4G/YaeLmwJiSMKjZToDYQeLVPHaKCzWlyt58Hdou8TuBlnOhHtklzlEAjf 2NHUBluDW1IYTG7LAn/A7JFE1aVahcjkyd/XjmyZHoHShHZFp2ozulGgDAQv9Zzgdl0Z jAjYV3l2cvXef1w2toqORSpWlOo6OqBSnVyWvi2Ln046CkomAKwKskQ9z1gzPXe8DpVx QP+55QFlP+u+ZWeRIdMNJiPnt+0JCB5ZC/+S7C6bS/SxrGkX26+d+xonC/1u7eyxeFav 8hDeDqnggV3Gbj2gMf603kAxwjGWZWXEaYjA/bWFwUYZCnBTzUhS8951pStaxh0ACrLP 9TgQ== X-Gm-Message-State: APjAAAVdZfEW2j5V0lsECCC3ReIMp56ODDS/rkJlQSd7G+j1ME6F1gA+ /49XBWU0cq0DF4kQYHapV2hd2A== X-Google-Smtp-Source: APXvYqxvXRBQTvHyP+Eyjmmk9Bk5y1xaQOf81H0skYUwswW+26sC59g1f7XXaygLYu/ZD9RbIB5PCg== X-Received: by 2002:a05:600c:2412:: with SMTP id 18mr2928864wmp.46.1557405327905; Thu, 09 May 2019 05:35:27 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b12sm5093381wrf.21.2019.05.09.05.35.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 May 2019 05:35:26 -0700 (PDT) Date: Thu, 9 May 2019 13:35:25 +0100 From: "Leif Lindholm" To: Marcin Wojtas Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com, Jici.Gao@arm.com Subject: Re: [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error Message-ID: <20190509123525.uespe54livtrkpgc@bivouac.eciton.net> References: <1557357861-14472-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1557357861-14472-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 09, 2019 at 01:24:21AM +0200, Marcin Wojtas wrote: > Commit cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode) > introduced a compilation error, visible with certain toolchains. > Fix that. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm Pushed as e284bb9226. Thanks for quick turnaround. > --- > Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c > index b4fd29c..62f9e57 100644 > --- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c > +++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c > @@ -1003,7 +1003,6 @@ MvFvbConfigureFlashInstance ( > ) > { > EFI_STATUS Status; > - UINTN *NumBytes; > UINTN DataOffset; > UINTN VariableSize, FtwWorkingSize, FtwSpareSize, MemorySize; > > @@ -1080,10 +1079,9 @@ MvFvbConfigureFlashInstance ( > DataOffset = GET_DATA_OFFSET (FlashInstance->FvbOffset, > FlashInstance->StartLba, > FlashInstance->Media.BlockSize); > - *NumBytes = FlashInstance->FvbSize; > Status = FlashInstance->SpiFlashProtocol->Read (&FlashInstance->SpiDevice, > DataOffset, > - *NumBytes, > + FlashInstance->FvbSize, > (VOID *)FlashInstance->RegionBaseAddress); > if (EFI_ERROR (Status)) { > goto ErrorFreeAllocatedPages; > -- > 2.7.4 >