From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=kfspYWCc; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Fri, 10 May 2019 08:58:37 -0700 Received: by mail-wm1-f67.google.com with SMTP id q15so4042884wmj.0 for ; Fri, 10 May 2019 08:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qoxXttE2WFG5IeWQyV0g8m0lVagUiv8W9zIQaWCkYWw=; b=kfspYWCc51sz3Yv8TkMIluYUo/k9697fZb63wcd3GD8g8LVI1V9mCz5dif+SBUB56M bvAuPExIWOX5WHzT2UOHs2JXEqj3eMVytHfHtMBkHQni8kvGrN9DRQ9tdLcnA2VSzVx2 cTF8gehOd/6bPXwIBHk1PpiICr8VblEfoyXAh+pr1iC7Q1OT4O6u7J+mjYYY2SeqckBx /mPxNojFSxzvXCzTx0LssVM7jArrRLF4IEKual2kKVl8eWJfyzg6wgof9WV6ZdmGBb5p b4znOSv2l4yOT+dwSQNbbpCz3+jLeDcnGnOVFXlPvb6ae9ne9Yh+dMZZkwDUlcaK967h mGXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qoxXttE2WFG5IeWQyV0g8m0lVagUiv8W9zIQaWCkYWw=; b=QRfHD9wR4RqFBsU/x5wXkS4x/bv+eXeYe0nRIyXbfVgWQcUWn7iXrUXqK981pwvhJZ zHdYjP5RvP1wElrUP95SCHtE790W61YjkF3pEK20Ckpssdil3SxmSS+bOkzWRucuQ5zt u9imqPIsW6BJbJYxZWaP9oPLw/lF5HU/t5ucAEP8knkhzHvr2s/xnbBfuCAkAME1izbi +2t1ARb2rpMTEVeHpDRl6nfobXLRXNOroE/PZhMtj1ftULa441FAKjezOZllYLqhYoea OdO+2GoPQJWsmgn5Cp7CWt4rRMjf+gFtwi1xxcsKtGcyKjR5hDHliAYGRUGHaTlD05zI /j8Q== X-Gm-Message-State: APjAAAVouGNfPyVtZFhWdEQxRUMHO1j+dC2YrWg8Pt1aJo6KHffOB23z kOTgAaWmGc2uaw5WNhknqALxpQ== X-Google-Smtp-Source: APXvYqy/fvMgpd/7MCPV1nkgXAWHa0W5ZggcKXdt873K7pKCI14x1IdWuKucsij1gevVutYnSBfu3w== X-Received: by 2002:a1c:9a14:: with SMTP id c20mr7178685wme.61.1557503915794; Fri, 10 May 2019 08:58:35 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m17sm2652540wmc.6.2019.05.10.08.58.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 May 2019 08:58:35 -0700 (PDT) Date: Fri, 10 May 2019 16:58:33 +0100 From: "Leif Lindholm" To: Marcin Wojtas Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com, Jici.Gao@arm.com, rebecca@bluestop.org, kettenis@jive.eu Subject: Re: [edk2-platforms: PATCH 00/14] Armada7k8k PCIE support Message-ID: <20190510155833.n4nkh6kkzhcolnnj@bivouac.eciton.net> References: <1557395622-32425-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1557395622-32425-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 09, 2019 at 11:53:28AM +0200, Marcin Wojtas wrote: > Hi, > > Hereby I submit Armada7k8k PCIE support. The commits > allow to use single controller on each of currently > supported boards (MacchiatoBin, A7040/A8040-DB) both in > firmware and in OS with ACPI boot. Multiple slots, > using custom PciSegmentLib, will be added later. Thanks, Marcin. As you have seen, I had only really minor comments on this set. (Patches I have not commented on look fine to me.) But I think we need Ard to give this a skim as well before pushing it, so I don't think we need a v2 until that has happened. Best Regards, Leif > Current patchset can be grouped following way: > 1. Preparation patches for Armada platforms (SoC and > Board description libraries and protocol) > > 2. Implement PciHostBridgeLib/PciExpressLib and > enable compilation. > > 3. ACPI support for each board + switch to pci-host-generic > in MacchiatoBin DT. > > 4. Additional 2 small patches. > > Thank to these commits (and all previously merged support), we can > now use mainline ARM-TF + EDK2 with DT and ACPI distributions and > operating systems. Example logs: > * McBin DT boot with pci-host-generic driver https://pastebin.com/5dRVCjRR > * McBin + Centos AltArch7 https://pastebin.com/BGx3Q6w0 > * ACPI boot on Armada7040Db with USB over PCIE https://pastebin.com/kMMUnEr8 > > In case anyone wishes to try, for your convenience, I uploaded > the McBin binary built from the PCIE branch on top of the > latest edk2/edk2-platforms with today's ARM-TF: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/wiki/files/flash-image-mcbin-mainline-r20190509.bin > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/pcie-upstream-r20190509 > > I'm looking forward to your comments or remarks. > > Best regards, > Marcin > > Ard Biesheuvel (1): > Marvell/Armada7k8k: Add PciExpressLib implementation > > Marcin Wojtas (13): > Marvell/Library: MvGpioLib: Extend GPIO pin description > Marvell/Library: ArmadaSoCDescLib: Add PCIE information > Marvell/Library: ArmadaBoardDescLib: Add PCIE information > Marvell/Armada7k8k: Extend board description libraries with PCIE > Marvell/Armada7k8k: MvBoardDesc: Extend protocol with PCIE support > Marvell/Armada7k8k: Implement PciHostBridgeLib > Marvell/Armada7k8k: Enable PCIE support > Marvell/Armada80x0McBin: Enable ACPI PCIE support > Marvell/Armada80x0Db: Enable ACPI PCIE support > Marvell/Armada70x0Db: Enable ACPI PCIE support > Marvell/Armada80x0McBin: DeviceTree: Use pci-host-generic driver > Marvell/Armada7k8k: Remove duplication in .dsc files > Marvell/Armada7k8: Add 'acpiview' shell command to build > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 18 +- > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 +- > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 +- > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 4 +- > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 5 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf | 1 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf | 1 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin.inf | 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf | 42 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf | 52 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h | 25 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h | 25 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h | 25 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h | 95 ++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 6 + > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 46 + > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 20 + > Silicon/Marvell/Include/Library/MvGpioLib.h | 1 + > Silicon/Marvell/Include/Protocol/BoardDesc.h | 22 + > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c | 48 + > Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 4 + > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 48 + > Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 6 + > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 48 + > Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c | 1529 ++++++++++++++++++++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c | 244 ++++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c | 330 +++++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 44 + > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 86 ++ > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 217 +++ > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc | 47 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 217 +++ > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc | 47 + > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 217 +++ > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc | 47 + > Silicon/Marvell/Armada7k8k/DeviceTree/armada-8040-mcbin.dts | 3 + > 37 files changed, 3569 insertions(+), 11 deletions(-) > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc > > -- > 2.7.4 >