From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=OsFcvHp5; spf=pass (domain: linaro.org, ip: 209.85.128.52, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by groups.io with SMTP; Fri, 10 May 2019 10:57:00 -0700 Received: by mail-wm1-f52.google.com with SMTP id y2so8405994wmi.5 for ; Fri, 10 May 2019 10:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xLOB9bTCEoZxbPh85Y6RJt36o1HLtpJsvmdOtASFXI4=; b=OsFcvHp5UkbQrLqjth5dNJv5ewpcqMRTYD5Ksi+W2orIy7RFCn0mb9mJC6hYntlATK qfkWihSaoFqWZywlK0vTleKXxFnYREOhrnTTCIFuekFOmD1uanK8QCC84ta+R/rstHN4 qo4ZhLfrKHcJv5Eo6zNMFWzknp75bGIM0+xRqO7tdTjwVS+5T9YhT3/EHQa2YZpz3786 HhAVcSUjAsUmDZK+wIqZzgaFBmWWrphUFpJ6RKIiFbCPL8ncnzKKrfihi0GpYa5NPWa+ J1iKp9COxB+ZRof/EE5Ulk6QjcMbCBD1Nha4bLYLngJhuhVoCJkv86T4S1DR0dj350GY wFTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xLOB9bTCEoZxbPh85Y6RJt36o1HLtpJsvmdOtASFXI4=; b=fOlUdTZVdVXQ3kxeFm/JTtgAsals5eW0N1Pm5hQfYqEpxJlIw1s+nwlHyP/hesWs43 mWQ8WS9sKacWVv+/kgsejR/pCuHsuW3iSYlbVdDhZsSk1SFouRQLRl36zYss79EPZqfW rkAnBBDiz7cLWxs2/evacQCq9bGtheV7naa2L1btLGj/xKrOUvDNMIalub28gUaIFPKB zTJX8uwlKnqSJxcIJpdJrWgDm1F0vEnWi9jz7IKr1Lpi3T+hLz7rsq1kFfuIqk3eCCQt AD99Q+qGZEYWJPI7JauNXXb6fsIifkAbcd8pMCR/qnuJvNkIGXasj3dZ9NV+VLp9gPOe wkCA== X-Gm-Message-State: APjAAAWucavqLZOppE6uzWjbro0osfzOGAa6ACYEjaUw+fxmKPMH4vn/ JQgCMkIFvyoJEnuU9mSeb74c7w== X-Google-Smtp-Source: APXvYqwQKjrxPf/90qIh6ymMWF/+w8eOz/qOMeVTQV3SyPR1j9+ORgpXUpoyiKZzWPUkhQBM8sKiGw== X-Received: by 2002:a7b:c093:: with SMTP id r19mr1612139wmh.35.1557511018748; Fri, 10 May 2019 10:56:58 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c10sm13355081wrd.69.2019.05.10.10.56.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 May 2019 10:56:57 -0700 (PDT) Date: Fri, 10 May 2019 18:56:56 +0100 From: "Leif Lindholm" To: Michael D Kinney Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [edk2-platforms: Patch 1/8] Silicon/TexasInsturments: Import Omap35xxPkg from edk2 Message-ID: <20190510175656.2ekr3slbbpcqo4bi@bivouac.eciton.net> References: <20190510033435.24112-1-michael.d.kinney@intel.com> <20190510033435.24112-2-michael.d.kinney@intel.com> MIME-Version: 1.0 In-Reply-To: <20190510033435.24112-2-michael.d.kinney@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Mike, I'm afraid a typo has snuck in below: On Thu, May 09, 2019 at 08:34:28PM -0700, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1467 > > Import Omap35xxPkg from edk2/master. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Michael D Kinney > --- > .../Omap35xxPkg/Flash/Flash.c | 768 +++++++++ > .../Omap35xxPkg/Flash/Flash.h | 100 ++ > .../Omap35xxPkg/Flash/Flash.inf | 42 + > .../TexasInsturments/Omap35xxPkg/Gpio/Gpio.c | 129 ++ > .../Omap35xxPkg/Gpio/Gpio.inf | 39 + > .../Omap35xxPkg/Include/Library/OmapDmaLib.h | 84 + > .../Omap35xxPkg/Include/Library/OmapLib.h | 38 + > .../Omap35xxPkg/Include/Omap3530/Omap3530.h | 34 + > .../Include/Omap3530/Omap3530Dma.h | 124 ++ > .../Include/Omap3530/Omap3530Gpio.h | 125 ++ > .../Include/Omap3530/Omap3530Gpmc.h | 101 ++ > .../Include/Omap3530/Omap3530I2c.h | 56 + > .../Include/Omap3530/Omap3530Interrupt.h | 45 + > .../Include/Omap3530/Omap3530MMCHS.h | 208 +++ > .../Omap3530/Omap3530PadConfiguration.h | 297 ++++ > .../Include/Omap3530/Omap3530Prcm.h | 159 ++ > .../Include/Omap3530/Omap3530Timer.h | 76 + > .../Include/Omap3530/Omap3530Uart.h | 48 + > .../Include/Omap3530/Omap3530Usb.h | 42 + > .../Omap35xxPkg/Include/TPS65950.h | 74 + > .../InterruptDxe/HardwareInterrupt.c | 396 +++++ > .../Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 48 + > .../LcdGraphicsOutputBlt.c | 439 +++++ > .../LcdGraphicsOutputDxe.c | 394 +++++ > .../LcdGraphicsOutputDxe.h | 151 ++ > .../LcdGraphicsOutputDxe.inf | 46 + > .../DebugAgentTimerLib/DebugAgentTimerLib.c | 159 ++ > .../DebugAgentTimerLib/DebugAgentTimerLib.inf | 42 + > .../Library/GdbSerialLib/GdbSerialLib.c | 96 ++ > .../Library/GdbSerialLib/GdbSerialLib.inf | 35 + > .../Omap35xxTimerLib/Omap35xxTimerLib.inf | 40 + > .../Library/Omap35xxTimerLib/TimerLib.c | 151 ++ > .../Library/OmapDmaLib/OmapDmaLib.c | 170 ++ > .../Library/OmapDmaLib/OmapDmaLib.inf | 43 + > .../Omap35xxPkg/Library/OmapLib/OmapLib.c | 77 + > .../Omap35xxPkg/Library/OmapLib/OmapLib.inf | 31 + > .../RealTimeClockLib/RealTimeClockLib.c | 291 ++++ > .../RealTimeClockLib/RealTimeClockLib.inf | 32 + > .../Library/SerialPortLib/SerialPortLib.c | 208 +++ > .../Library/SerialPortLib/SerialPortLib.inf | 40 + > .../Omap35xxPkg/MMCHSDxe/MMCHS.c | 1492 +++++++++++++++++ > .../Omap35xxPkg/MMCHSDxe/MMCHS.h | 169 ++ > .../Omap35xxPkg/MMCHSDxe/MMCHS.inf | 48 + > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.c | 671 ++++++++ > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.h | 38 + > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf | 47 + > .../Omap35xxPkg/Omap35xxPkg.dec | 52 + > .../Omap35xxPkg/Omap35xxPkg.dsc | 183 ++ > .../Omap35xxPkg/PciEmulation/PciEmulation.c | 107 ++ > .../Omap35xxPkg/PciEmulation/PciEmulation.inf | 41 + > .../Omap35xxPkg/SmbusDxe/Smbus.c | 319 ++++ > .../Omap35xxPkg/SmbusDxe/Smbus.inf | 39 + > .../Omap35xxPkg/TPS65950Dxe/TPS65950.c | 110 ++ > .../Omap35xxPkg/TPS65950Dxe/TPS65950.inf | 42 + > .../Omap35xxPkg/TimerDxe/Timer.c | 370 ++++ > .../Omap35xxPkg/TimerDxe/TimerDxe.inf | 51 + > 56 files changed, 9257 insertions(+) > create mode 100644 Silicon/TexasInsturments/Omap35xxPkg/Flash/Flash.c TexasInsturments -> TexasInstruments Also, using the sortorder and --stat/--stat-graph-width from Laszlo's guide when generating patches would be helpful here even though the code is just moving. It makes the above more clear, and puts the .dec and .dsc (which have actually changed) first. Beyond that, I intend to change both this and BeagleBoardPkg to use full pathnames relative to edk2-platforms root after the migration, but we don't need to do that for the migration. Best Regards, Leif