From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=r/kfncrI; spf=pass (domain: linaro.org, ip: 209.85.128.43, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by groups.io with SMTP; Fri, 10 May 2019 12:54:42 -0700 Received: by mail-wm1-f43.google.com with SMTP id h11so8522565wmb.5 for ; Fri, 10 May 2019 12:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bWOSazdFHlAnx5UY0cU2RnU78bSPQcMlfZyuQz2cvnk=; b=r/kfncrIY/Zcq4Fk0E0QIM3E937Ndj3dYBxcUf6Lc0s2VaEalX4MLtWrvlWxXU0L3z pZtwsvVlvN+m1jKoh39chM/X+NtOA0TkOsdqBGLj4RH3Xuz5QKsK6kiVcWUzSZFxwvhI 7zRQo5ozH3zS106farzJBhfR+aFFMQ0arpfODl4PflDrrCY0W9zsnOLD3FLLMvwdGzfx dDc2h5KrYwlSzSPZbZdJFO8gkMuxrl1+ZejKTZWIyYG4k6bxoQNcFlXto0qn6GY/Ysnh fFHoxnpcy0/M4WjvLCCZpMkRLKFyMaIDxSzPGIjyjI2eOuOiTvcMkuqQWCY+jUBtcrzL CC+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bWOSazdFHlAnx5UY0cU2RnU78bSPQcMlfZyuQz2cvnk=; b=iKzXaH4c78PgSLdIi5Odm6DNZT7Zr/Fmy80T8AsiTMa08ig1twyH35gKYV3tVGLNh8 HA+Bxak/x2ooFg6E+GTV8i8ZKo5EcO1uU5md4dUUTMXxYerf68jb5r9VicMKJea3z8J/ V+u58i2Nc2Gz1zV4QtR5ro3ydOO5sT9iRSl/JHs4PYkN5qNmzho2TUNYafDhNIog9dKh SJz4xZiKQD1DJ37W47A+p35YXv192d/Te22aCRNvpvirUrN38Rn/vmn9+koKmDS1KGx1 An/MyWgv04jwt/cgPGL9UZtLG51jwdC6L3y6hz1A6SGG1PQifyVVONlAKf1Q9mRkkgDY MMAQ== X-Gm-Message-State: APjAAAXxeeUdVlrhDYvLdL10QRnB1BGiQr88qCsZ0GPv3G2hkq5r0Khy isS78Oy3HkarrBccrvhIPai0/g== X-Google-Smtp-Source: APXvYqyYZxXl2IvpLI4d6eESdzXBcfHHDmCg9KRWUr5VCq7BQkz4DbtahumhqzN8QsHtoyipU+kmNA== X-Received: by 2002:a1c:ca01:: with SMTP id a1mr8653351wmg.30.1557518080380; Fri, 10 May 2019 12:54:40 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n17sm5062367wrw.77.2019.05.10.12.54.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 May 2019 12:54:39 -0700 (PDT) Date: Fri, 10 May 2019 20:54:38 +0100 From: "Leif Lindholm" To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , Ard Biesheuvel Subject: Re: [edk2-platforms: Patch 1/8] Silicon/TexasInsturments: Import Omap35xxPkg from edk2 Message-ID: <20190510195438.63vxgjewoh6th47o@bivouac.eciton.net> References: <20190510033435.24112-1-michael.d.kinney@intel.com> <20190510033435.24112-2-michael.d.kinney@intel.com> <20190510175656.2ekr3slbbpcqo4bi@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Mike, If you explicitly didn't change any of the files, then I'm totally happy with the typo fixed. For Omap35xxPkg and BeagleBoardPkg: Reviewed-by: Leif Lindholm Regards, Leif On Fri, May 10, 2019 at 07:16:47PM +0000, Kinney, Michael D wrote: > Leif, > > Thanks. I will fix the typo. > > I did not change any of the .dec or .dsc files with this series. > > I tested builds by using PACKAGES_PATH. > > Do you approve the change with the typo fixed or do you want > me to send a V2? > > Thanks, > > Mike > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Friday, May 10, 2019 10:57 AM > > To: Kinney, Michael D > > Cc: devel@edk2.groups.io; Ard Biesheuvel > > > > Subject: Re: [edk2-platforms: Patch 1/8] > > Silicon/TexasInsturments: Import Omap35xxPkg from edk2 > > > > Hi Mike, > > > > I'm afraid a typo has snuck in below: > > > > On Thu, May 09, 2019 at 08:34:28PM -0700, Michael D > > Kinney wrote: > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1467 > > > > > > Import Omap35xxPkg from edk2/master. > > > > > > Cc: Leif Lindholm > > > Cc: Ard Biesheuvel > > > Signed-off-by: Michael D Kinney > > > > > --- > > > .../Omap35xxPkg/Flash/Flash.c | 768 > > +++++++++ > > > .../Omap35xxPkg/Flash/Flash.h | 100 > > ++ > > > .../Omap35xxPkg/Flash/Flash.inf | 42 > > + > > > .../TexasInsturments/Omap35xxPkg/Gpio/Gpio.c | 129 > > ++ > > > .../Omap35xxPkg/Gpio/Gpio.inf | 39 > > + > > > .../Omap35xxPkg/Include/Library/OmapDmaLib.h | 84 > > + > > > .../Omap35xxPkg/Include/Library/OmapLib.h | 38 > > + > > > .../Omap35xxPkg/Include/Omap3530/Omap3530.h | 34 > > + > > > .../Include/Omap3530/Omap3530Dma.h | 124 > > ++ > > > .../Include/Omap3530/Omap3530Gpio.h | 125 > > ++ > > > .../Include/Omap3530/Omap3530Gpmc.h | 101 > > ++ > > > .../Include/Omap3530/Omap3530I2c.h | 56 > > + > > > .../Include/Omap3530/Omap3530Interrupt.h | 45 > > + > > > .../Include/Omap3530/Omap3530MMCHS.h | 208 > > +++ > > > .../Omap3530/Omap3530PadConfiguration.h | 297 > > ++++ > > > .../Include/Omap3530/Omap3530Prcm.h | 159 > > ++ > > > .../Include/Omap3530/Omap3530Timer.h | 76 > > + > > > .../Include/Omap3530/Omap3530Uart.h | 48 > > + > > > .../Include/Omap3530/Omap3530Usb.h | 42 > > + > > > .../Omap35xxPkg/Include/TPS65950.h | 74 > > + > > > .../InterruptDxe/HardwareInterrupt.c | 396 > > +++++ > > > .../Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 48 > > + > > > .../LcdGraphicsOutputBlt.c | 439 > > +++++ > > > .../LcdGraphicsOutputDxe.c | 394 > > +++++ > > > .../LcdGraphicsOutputDxe.h | 151 > > ++ > > > .../LcdGraphicsOutputDxe.inf | 46 > > + > > > .../DebugAgentTimerLib/DebugAgentTimerLib.c | 159 > > ++ > > > .../DebugAgentTimerLib/DebugAgentTimerLib.inf | 42 > > + > > > .../Library/GdbSerialLib/GdbSerialLib.c | 96 > > ++ > > > .../Library/GdbSerialLib/GdbSerialLib.inf | 35 > > + > > > .../Omap35xxTimerLib/Omap35xxTimerLib.inf | 40 > > + > > > .../Library/Omap35xxTimerLib/TimerLib.c | 151 > > ++ > > > .../Library/OmapDmaLib/OmapDmaLib.c | 170 > > ++ > > > .../Library/OmapDmaLib/OmapDmaLib.inf | 43 > > + > > > .../Omap35xxPkg/Library/OmapLib/OmapLib.c | 77 > > + > > > .../Omap35xxPkg/Library/OmapLib/OmapLib.inf | 31 > > + > > > .../RealTimeClockLib/RealTimeClockLib.c | 291 > > ++++ > > > .../RealTimeClockLib/RealTimeClockLib.inf | 32 > > + > > > .../Library/SerialPortLib/SerialPortLib.c | 208 > > +++ > > > .../Library/SerialPortLib/SerialPortLib.inf | 40 > > + > > > .../Omap35xxPkg/MMCHSDxe/MMCHS.c | 1492 > > +++++++++++++++++ > > > .../Omap35xxPkg/MMCHSDxe/MMCHS.h | 169 > > ++ > > > .../Omap35xxPkg/MMCHSDxe/MMCHS.inf | 48 > > + > > > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.c | 671 > > ++++++++ > > > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.h | 38 > > + > > > .../Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf | 47 > > + > > > .../Omap35xxPkg/Omap35xxPkg.dec | 52 > > + > > > .../Omap35xxPkg/Omap35xxPkg.dsc | 183 > > ++ > > > .../Omap35xxPkg/PciEmulation/PciEmulation.c | 107 > > ++ > > > .../Omap35xxPkg/PciEmulation/PciEmulation.inf | 41 > > + > > > .../Omap35xxPkg/SmbusDxe/Smbus.c | 319 > > ++++ > > > .../Omap35xxPkg/SmbusDxe/Smbus.inf | 39 > > + > > > .../Omap35xxPkg/TPS65950Dxe/TPS65950.c | 110 > > ++ > > > .../Omap35xxPkg/TPS65950Dxe/TPS65950.inf | 42 > > + > > > .../Omap35xxPkg/TimerDxe/Timer.c | 370 > > ++++ > > > .../Omap35xxPkg/TimerDxe/TimerDxe.inf | 51 > > + > > > 56 files changed, 9257 insertions(+) > > > create mode 100644 > > Silicon/TexasInsturments/Omap35xxPkg/Flash/Flash.c > > > > TexasInsturments -> > > TexasInstruments > > > > Also, using the sortorder and --stat/--stat-graph-width > > from Laszlo's > > guide when generating patches would be helpful here even > > though the > > code is just moving. It makes the above more clear, and > > puts the .dec > > and .dsc (which have actually changed) first. > > > > Beyond that, I intend to change both this and > > BeagleBoardPkg to use > > full pathnames relative to edk2-platforms root after the > > migration, > > but we don't need to do that for the migration. > > > > Best Regards, > > > > Leif