From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=s7JFGBLm;
 spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65])
 by groups.io with SMTP; Tue, 14 May 2019 08:13:35 -0700
Received: by mail-wm1-f65.google.com with SMTP id j187so2600358wma.1
        for <devel@edk2.groups.io>; Tue, 14 May 2019 08:13:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=iyeG7VmcRddkms3N3fHXdjKJXJial83OKzaKK6oejzw=;
        b=s7JFGBLm/Cp+jncnue0daoADDTJcskV+Tb0Mmypeowv8nWGRfx/PZTpzx43SbZ795B
         EsG7UeDW8HfslOITgevlAI0sK81dSbFrYBL2C1xE+3a61gH51qeFAA/gEQMlhBFn0KUv
         8/b06liqlvtdu5ZpNCofCRlwhzMrXZPOUKewQq5pBHOYenaHcgi67YlOVxTYgMytsFpE
         oa8fZ3PWdKYMeVxs2BFvatHckCP2Nhnh7EnjPJNIX2j3VZFCsw34Seop56hmTix9hrHr
         wS3+QfwFNeIGXvnRdgeVEpAoPP5X2eA6mUAvN8gOQDWzb9xn0PYRSRaj8WT5UFmEW0NR
         L3Mw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=iyeG7VmcRddkms3N3fHXdjKJXJial83OKzaKK6oejzw=;
        b=e+EA3RjwgvdXxFvcoEADQpaAMVgLfDIipqJpyvBsB8alWCfr0bzcAKsyeCOHk0eYwV
         sMhBJ+1Ew5agO/cdKLOWWoc3DQI9J+aGuOA8ZzOBtR9sgASQikXa3jQJOMN1AXkXNo6C
         wMegYOH597k2mey+Ugy2z97oR7vYfu/G2HNDz4AjjX1q104KYeW4UfKSv0+lwsWZs+Nb
         NHLVPVTH4w+6N5B1EH3UU4TAPOd9y0h9ScdqeK37mkbPR/arot+mBpdYUuerDmNge70I
         twCoViyglC5n9w43IGQu0Qy8Q9iC1jsYN0oe9I8AdY55MVvYM3hV7eu19XNjm8632BfL
         1AKg==
X-Gm-Message-State: APjAAAVdVItig/GyOdAQBQGGKWqOe6frc6ScqCgKgITTweBs64qTDcxm
	5gL8SRB1cW9IZuR8V5UszbefpFXfPY8=
X-Google-Smtp-Source: APXvYqz7mCWB/rrBiguW8XKEkhDH0AJ32AtwfdIeNK1veSzr4qbL/QZCP9dXhUqYE7OJEk4IbFWqwQ==
X-Received: by 2002:a05:600c:22cc:: with SMTP id 12mr8171843wmg.141.1557846813712;
        Tue, 14 May 2019 08:13:33 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id b2sm16683223wrt.20.2019.05.14.08.13.32
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Tue, 14 May 2019 08:13:32 -0700 (PDT)
Date: Tue, 14 May 2019 16:13:31 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, hao.a.wu@intel.com
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] Platform/BeagleBoard: Drop the consume of PcdShellFile
Message-ID: <20190514151331.x23zejy35rkmkjzk@bivouac.eciton.net>
References: <20190514020831.7728-1-hao.a.wu@intel.com>
 <20190514020831.7728-4-hao.a.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20190514020831.7728-4-hao.a.wu@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 14, 2019 at 10:08:16AM +0800, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
> 
> There is no module in the platform that will use
> gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will
> drop the consume of this PCD.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 8e8bb833ea..043204ce4f 100644
> --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -334,9 +334,6 @@
>  
>    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10
>  
> -  # GUID of the UEFI Shell
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
> -
>    # GUID of the UI app
>    gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
>  
> -- 
> 2.12.0.windows.1
> 
> 
> 
>