From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 195.135.221.5, mailfrom: glin@suse.com) Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) by groups.io with SMTP; Tue, 14 May 2019 18:54:16 -0700 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Wed, 15 May 2019 03:54:13 +0200 Received: from GaryWorkstation (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Wed, 15 May 2019 02:53:58 +0100 Date: Wed, 15 May 2019 09:53:53 +0800 From: "Gary Lin" To: devel@edk2.groups.io, jian.j.wang@intel.com Cc: Laszlo Ersek , "Lu, XiaoyuX" , "Ye, Ting" Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b Message-ID: <20190515015353.GD23588@GaryWorkstation> References: <1557753912-30122-1-git-send-email-xiaoyux.lu@intel.com> <20190514061630.GC23588@GaryWorkstation> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 14, 2019 at 01:26:15PM +0000, Wang, Jian J wrote: > Yes, please wait for v4 version of this patch series. Good. I'm looking forward to the new series :) Thanks, Gary Lin > > Regards, > Jian > > > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Tuesday, May 14, 2019 8:06 PM > > To: devel@edk2.groups.io; glin@suse.com > > Cc: Lu, XiaoyuX ; Wang, Jian J ; > > Ye, Ting > > Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b > > > > On 05/14/19 08:16, Gary Lin wrote: > > > On Mon, May 13, 2019 at 09:24:39PM +0200, Laszlo Ersek wrote: > > >> On 05/13/19 15:25, Xiaoyu lu wrote: > > >>> (1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL > > >>> OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93). > > >>> So add --with-rand-seed=none to process_files.pl. > > >>> > > >>> (2) CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl > > >>> When running process_files.py to configure OpenSSL, we can exclude some > > unnecessary files. This can reduce porting time, compiling time and library size. > > >>> > > >>> (3) CryptoPkg/IntrinsicLib: Fix possible unresolved external symbol issue > > >>> > > >>> (4) CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL > > >>> Disable warning for building OpenSSL_1_1_1b > > >>> > > >>> (5) CryptoPkg: Upgrade OpenSSL to 1.1.1b > > >>> Update OpenSSL submodule to OpenSSL_1_1_1b > > >>> OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) > > >>> > > >>> OpenSSL doesn't implement some rand_pool function for UEFI. > > >>> Use EFI_RNG_PROTOCOL to generate random for entropy. > > >>> If EFI_RNG_PROTOCOL is not avaliable, fall back to performance > > >>> counter, but we not sure about the amount of randomness it provides. > > >>> > > >>> (6) CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible > > >>> > > >>> Note: Will be remove next update. > > >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1792 > > >>> Ref: https://github.com/openssl/openssl/pull/4338 > > >>> > > >>> > > >>> Cc: Jian J Wang > > >>> Cc: Ting Ye > > >> > > >> I'm withdrawing from reviewing or testing this series. > > >> > > >> Gary, if you have the time, can you please regression test this (for > > >> HTTPS boot) in both OVMF and ArmVirtQemu? > > >> > > > I'll find some time to do the regression test tomorrorw. > > > > Thanks, Gary! > > > > Xiaoyu might post a v4 with a remote topic branch for reviewers to > > fetch; I suggest awaiting that. (The series is difficult to apply with > > git-am.) > > > > Thanks > > Laszlo > > > > > Cheers, > > > > > > Gary Lin > > > > > > > > > > > > >