Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

["Gary Lin" <glin@suse.com>]

On Wed, May 15, 2019 at 02:00:27AM +0000, Xiaoyu lu wrote:
> Hi Gary Lin:
> 	I also need to modify the code about the entropy source today.
> 	But I have uploaded a TimerLib based implementation.
> 
> 	https://github.com/xiaoyuxlu/edk2/commits/bz_1089_patch_v4
Thanks! I'll go through the commits today and prepare for the incoming
series.

Gary Lin

> 
> Thanks.
> Xiaoyu
> 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gary Lin
> Sent: Wednesday, May 15, 2019 9:54 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b
> 
> On Tue, May 14, 2019 at 01:26:15PM +0000, Wang, Jian J wrote:
> > Yes, please wait for v4 version of this patch series.
> 
> Good. I'm looking forward to the new series :)
> 
> Thanks,
> 
> Gary Lin
> 
> > 
> > Regards,
> > Jian
> > 
> > 
> > > -----Original Message-----
> > > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > > Sent: Tuesday, May 14, 2019 8:06 PM
> > > To: devel@edk2.groups.io; glin@suse.com
> > > Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Wang, Jian J 
> > > <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> > > Subject: Re: [edk2-devel] [PATCH v3 0/6] CryptoPkg: Upgrade OpenSSL 
> > > to 1.1.1b
> > > 
> > > On 05/14/19 08:16, Gary Lin wrote:
> > > > On Mon, May 13, 2019 at 09:24:39PM +0200, Laszlo Ersek wrote:
> > > >> On 05/13/19 15:25, Xiaoyu lu wrote:
> > > >>> (1) CryptoPkg/OpensslLib: Modify process_files.pl for  upgrading OpenSSL
> > > >>>   OpenSSL only support seeding NONE for UEFI(rand_unix.c line 93).
> > > >>>   So add --with-rand-seed=none to process_files.pl.
> > > >>>
> > > >>> (2) CryptoPkg/OpensslLib: Exclude unnecessary files in  process_files.pl
> > > >>>   When running process_files.py to configure OpenSSL, we can 
> > > >>> exclude some
> > > unnecessary files. This can reduce porting time, compiling time and library size.
> > > >>>
> > > >>> (3) CryptoPkg/IntrinsicLib: Fix possible unresolved  external 
> > > >>> symbol issue
> > > >>>
> > > >>> (4) CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL
> > > >>>   Disable warning for building OpenSSL_1_1_1b
> > > >>>
> > > >>> (5) CryptoPkg: Upgrade OpenSSL to 1.1.1b
> > > >>>   Update OpenSSL submodule to OpenSSL_1_1_1b
> > > >>>   OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687)
> > > >>>
> > > >>>   OpenSSL doesn't implement some rand_pool function for UEFI.
> > > >>>   Use EFI_RNG_PROTOCOL to generate random for entropy.
> > > >>>   If EFI_RNG_PROTOCOL is not avaliable, fall back to performance
> > > >>>   counter, but we not sure about the amount of randomness it provides.
> > > >>>
> > > >>> (6) CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward
> > > >>> compatible
> > > >>>
> > > >>>   Note: Will be remove next update.
> > > >>>   Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1792
> > > >>>   Ref: https://github.com/openssl/openssl/pull/4338
> > > >>>
> > > >>>
> > > >>> Cc: Jian J Wang <jian.j.wang@intel.com>
> > > >>> Cc: Ting Ye <ting.ye@intel.com>
> > > >>
> > > >> I'm withdrawing from reviewing or testing this series.
> > > >>
> > > >> Gary, if you have the time, can you please regression test this 
> > > >> (for HTTPS boot) in both OVMF and ArmVirtQemu?
> > > >>
> > > > I'll find some time to do the regression test tomorrorw.
> > > 
> > > Thanks, Gary!
> > > 
> > > Xiaoyu might post a v4 with a remote topic branch for reviewers to 
> > > fetch; I suggest awaiting that. (The series is difficult to apply 
> > > with
> > > git-am.)
> > > 
> > > Thanks
> > > Laszlo
> > > 
> > > > Cheers,
> > > >
> > > > Gary Lin
> > > >
> > > > 
> > > >
> > 
> > 
> > 
> > 
> 
> 
> 
> 
> 
> 
>