From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=g+Wg1Mqk; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 15 May 2019 04:56:49 -0700 Received: by mail-wr1-f66.google.com with SMTP id f8so2376385wrt.1 for ; Wed, 15 May 2019 04:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WiU1XTELnp5QjIDk4EzIz62uxZIUB6Svc9SYbTVgX+c=; b=g+Wg1Mqkkh74wIZ9oAEW6TkFWyTs7NzCq3vunggZS4tkkwnsn35lKbsSvqpE3s/v5E wj5zrYweuMzdOuc1g9gajwOhRFl/pyr9jqpPKaAHuef13RCrbIILkHmVfoboUTXG5bUT Ojwpwb4KsAylZHeXe4a0dP9ajBXZLPMY8kPbcwqlOCCdaDUl4FSHe1F3dIuYkiuHbFYG N5z18Z/laf7+fquTNOHHcYlHokJL1M0pcjEwrkFn7O/emIecA5w3zvU/60HXhYhYrPiC lUAbIzfynrmFfpFpXfQ9klH2uCUVXTCpFr22Jnaz+otRL/IwYylrfoUqVg8LLGy+pNzF Pwvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WiU1XTELnp5QjIDk4EzIz62uxZIUB6Svc9SYbTVgX+c=; b=h0q4gn41gPACvPr7eO2LGVLg2RrXckPv4o3QyxGRc4FR/LTxTeXNvjilQN3KLVtJqz por6rpOUKgEFYUpfbvXaSNfS1o4qmFiIpD/npkrHWaNZ9h98RNvfpgykp90Q2A7Xm7eJ mbt9lnpd/Mv7rPVzHkWqb4Vn9DRzUeYkzh+FiK+QcZFLC8UfZvteMVEkzwE3X9chmXXg +hq1ceR+03R6xZm+FI4GfcLiJ8Cu14OvkWuAgYR3h8I+cJhPcSFMR9s2SF1g9whkaCqT 4+6afWsbsRiCB+euU00mCUi69ZpRs9ULLVwy4dW6z5etT/2w1kMiLgQhpG98+7UDtHDq Gekg== X-Gm-Message-State: APjAAAXXgafqCnZ6tJO+6I63DC4t3tPKqbDGw0EiT8zT/5QShK+qKgcG oYlbs2zV0PvTcXIfrRkXnWDN2Q== X-Google-Smtp-Source: APXvYqzd+c1pCppw6GrG22ui/NMSd5g/x0qk37ugSuZmBiykdLAMKjr92lmz/qzDxeb9/K5rtP2pRQ== X-Received: by 2002:adf:ee01:: with SMTP id y1mr7062111wrn.51.1557921407552; Wed, 15 May 2019 04:56:47 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c2sm1252597wrr.13.2019.05.15.04.56.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 04:56:46 -0700 (PDT) Date: Wed, 15 May 2019 12:56:45 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: edk2-devel-groups-io , Ard Biesheuvel , Michael Kinney , Andrew Fish , Gerd Hoffmann , Jordan Justen Subject: Re: [edk2-devel] [PATCH 0/4] OvmfPkg/PlatformPei: fix two assertion failures with weird RAM sizes Message-ID: <20190515115645.x2ewrg23rwsreocx@bivouac.eciton.net> References: <20190504000716.7525-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 12:36:22PM +0200, Laszlo Ersek wrote: > Hi Stewards, > > it seems likely that this patch series -- posted on 2019-May-04 -- will > not receive the necessary maintainer A-b's / R-b's before we enter the > soft feature freeze for edk2-stable201905. > > Therefore I'd like to state that I consider this series a bugfix series, > not a feature addition. I'm now asking for confirmation that I'll be > allowed to push the series -- dependent on the expected reviewer > feedback of course -- even after 2019-May-17 08:00:00 UTC. Clearly bugfix, and quite contained in scope as well. > Please also state whether I will need to open a TianoCore BZ for > tracking this work (and to update the commit messages accordingly). I > haven't done that because we already have two public BZs for the issue > in the Red Hat Bugzilla instance, with issue description and analysis. > (RHBZ references are captured in both the blurb below, and in the > patches themselves.) I would lean towards having a TianoCore BZ for anything pushed in the freeze period. While I don't expect Red Hat to close its BZ from public access, it does sort of open up the question of "well, which other BZs do we consider trustworthy enough to give the same treatment?" that I would prefer to avoid having to deal with during future freeze periods. But if you (plural) feel I'm being overly cautious, I don't feel *that* strongly about it. Regards, Leif > Thanks > Laszlo > > On 05/04/19 02:07, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > > Branch: exbar_mtrr_rhbz_1666941 > > Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1666941 > > Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1701710 > > > > When booting OVMF on QEMU with "weird" RAM sizes, QEMU's low-RAM split > > logic can trigger two assertion failures in OVMF: > > > > - conflict between PCIEXBAR (ECAM) and low-RAM, on q35, > > > > - running out of variable MTRRs when marking the uncacheable MMIO range > > in 32-bit address space, on both i440fx and q35. > > > > This series fixes both issues, by moving around the PCIEXBAR on q35, and > > by truncating the size of the uncacheable 32-bit area to a power of two. > > The latter idea was inspired by SeaBIOS. > > > > Tested on both machine types, with the following memory sizes (all in > > MB): 1025, 2815, 3583, 5120. On i440fx, the X64 build was used (without > > SMM). On q35, the IA32 and IA32X64 builds were used (with SMM). Testing > > included "/proc/mtrr" verification, 32-bit PCI MMIO aperture > > verification, general dmesg checks, and my usual regression tests too > > (ACPI S3, UEFI variable services, ...). > > > > Cc: Ard Biesheuvel > > Cc: Gerd Hoffmann > > Cc: Jordan Justen > > > > Thanks > > Laszlo > > > > Laszlo Ersek (4): > > OvmfPkg/PlatformPei: assign PciSize on both i440fx/q35 branches > > explicitly > > OvmfPkg/PlatformPei: hoist PciBase assignment above the i440fx/q35 > > branching > > OvmfPkg/PlatformPei: reorder the 32-bit PCI hole vs. the PCIEXBAR on > > q35 > > OvmfPkg/PlatformPei: fix MTRR for low-RAM sizes that have many bits > > clear > > > > OvmfPkg/OvmfPkgIa32.dsc | 5 +---- > > OvmfPkg/OvmfPkgIa32X64.dsc | 5 +---- > > OvmfPkg/OvmfPkgX64.dsc | 5 +---- > > OvmfPkg/PlatformPei/MemDetect.c | 23 +++++++++++++++++--- > > OvmfPkg/PlatformPei/Platform.c | 14 +++++------- > > OvmfPkg/PlatformPei/Platform.h | 2 ++ > > 6 files changed, 31 insertions(+), 23 deletions(-) > > >