From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=pXV0T2I1; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Wed, 15 May 2019 12:44:35 -0700 Received: by mail-wr1-f68.google.com with SMTP id d9so826726wrx.0 for ; Wed, 15 May 2019 12:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=86aHLnRIB+p/u6qs73X+jo+YwRPOMBANr/HLlrzpYYU=; b=pXV0T2I1Phu9gwmv1nrv0vPLExYMsfMVK/tSw0I9O/+6zUufdGIC9D1TXMjI+xinKX 3DVs/rORoUDnKeFiaGcEjFWpdjN0gzbHSxx3m8NJHsgIZo5Xu7stuKPlUYC3gG4nXnAh qldPF4B6EIZ9LELhD6dB2ZUXJSH4wi0xW5aZPEaEMV3f/65w8SZT1RBI/iKsRCkP0MTX WVTCXFYJf9udP/WA7KT8SGyiyYU2C49hypfUqOsNBNyjVbvAC0f/kao8k5FVe/V4kVCD iVUcJM9QOyjzfb6i0HfR8+97NhwOSe4yLjV7fD6qAKmzT6OsXY/lljI4s12Rm/kOTp3X Kl3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=86aHLnRIB+p/u6qs73X+jo+YwRPOMBANr/HLlrzpYYU=; b=huttlgG93oRl6hQY3yd9+qfrefJGM3kGuYJNvyT34FpdFHWIGtqrwCivjwTG7ZcGT3 yNyeEu/XNr5GynKYVB5M8UNozW9FEVH2PrjkSVh0DY7cJpuRojJmeCqlZtsSXMqZ+gW2 ryyPuyev9ZrQcHUa54lpj1aGjTRSlglVMOSFzkeLROnYT7j52YSs6b/qd2xHiuyxGHP7 w9mDpLH4jKVotCjNmLga6Ybq4j8/1lXALKYX44XFKYHpsSp/hG9fmZUJapncc8Djny3H Q3G7YhfcoPArriCej6wQnBkpTDpPNEpba4RWF/h67ZYgX5ahQyzKESmEvtLblfCqiW9o hoLA== X-Gm-Message-State: APjAAAX4mMIh3a326Wr3PoxvkxOU0RU/gnkigjqyfKWE3g0EpLc6iV7E QIZEbrpCCVMTtnzpZokppZFgYLj5j5A= X-Google-Smtp-Source: APXvYqwxd+Px8CAtY2V29wG3jl/06crQiq1w0o/ca7ohtDMSzD1QtaA1WujT3MsM0lmh6o/Qcdqnow== X-Received: by 2002:adf:db50:: with SMTP id f16mr1590656wrj.198.1557949473309; Wed, 15 May 2019 12:44:33 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a22sm2017844wma.41.2019.05.15.12.44.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 12:44:32 -0700 (PDT) Date: Wed, 15 May 2019 20:44:30 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 02/16] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg Message-ID: <20190515194430.4c5ybrw2kj72hcgn@bivouac.eciton.net> References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-5-hao.a.wu@intel.com> MIME-Version: 1.0 In-Reply-To: <20190514020831.7728-5-hao.a.wu@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 14, 2019 at 10:08:17AM +0800, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 > > This commit will update the DSC file to consume the ReportStatusCodeLib > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the > one in IntelFrameworkModulePkg. > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus, > there is no functional impact for this commit. Responding the same as when I replied to the patch sent by accident: This is inaccurate - there are non-trivial differences which could definitely impact runtime behaviour. This patch definitely needs testing, and the message needs rewording. / Leif > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Hao A Wu > --- > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > index 2d5d6f9977..8e8bb833ea 100644 > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -163,7 +163,7 @@ > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > @@ -173,19 +173,19 @@ > > > [LibraryClasses.common.DXE_DRIVER] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > > [LibraryClasses.common.UEFI_DRIVER] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > @@ -193,7 +193,7 @@ > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > PeCoffLib|BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf > -- > 2.12.0.windows.1 > > > >