From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=l3Y6cHAS; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Wed, 15 May 2019 12:51:41 -0700 Received: by mail-wr1-f68.google.com with SMTP id g12so513772wro.8 for ; Wed, 15 May 2019 12:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hujd4LLpYT53nv2uhRCiSEocXiKk5QyaDXQPnwm26F4=; b=l3Y6cHASRzLg+oSKRUSAJEFWb0i0iJmtH4Ui1IRDP/J7p5VpvP7GW+sTWQTcw8w6UJ pdNaGeL+oZPaCHKZON39OCpWpQlCw9c0J1vKKamaaRHPTsXuDZB8IQUTnfbpELaJmON4 Rp+LFnyvMVkpoEVYTPUDOiHjcsdPiaQQWPS+ZaCW7T/5T2pclO4kOEZjmptNoQGv2tCP Q+06TTzzUf1VpcgRnKTxplk/uUvA4hICjHx7+Gz0EuFv7dI+pbdW38b1K1cHlZtBu6no /CEWJrVnN7igZkq8t/adH7qDTR/NjwiSijcJc6K1eR1Lr+nLrrKgcRCif2M9ckAcpk2V m5Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hujd4LLpYT53nv2uhRCiSEocXiKk5QyaDXQPnwm26F4=; b=Hyf/2FdIcHA1EA1CbxjoK5hEa7K0f3ZvseaJjX8ZyxBOLEfVzFPitg1U1evxqzTpux 1hC8CTDE+1YwS2ZamtHy3veO5RaAuDUaIJ0xx3vOFXpqv5qcAoj1UVPet3dfErwKszpS C56QjMJUjJmfzLZAzXnLgjE/a8Y4Akk70K/nUBw44yZWQ1LPY+958Aixmi/ObkXOtEnD RgqBSlVhH0gAO7e/fzrlaWf9GIc9V7fy3GtXK6zjDk3eHe407YTPVRyyW3XJr1dfL6gP RJ2LBG2K4mCvNrdLjhOl6IRyYQhANczK4d84l+aVKSKve0/7Sg2NSi3G5XIee1VMUoo9 7/lw== X-Gm-Message-State: APjAAAVP0dvFU/aDgTC67tjDmSpfZJynuJjk9TZcfFshMHmavaK7hGUF rg+JH3cXPsXIm/JGowInIkDQBw== X-Google-Smtp-Source: APXvYqwMUV5E9QIrUByKGpfrvcM6UpfiMMfHGLw1WVEIFvJsWtKJSVDYDULwZiQJ2f+swGsWqeB2rg== X-Received: by 2002:adf:d4ca:: with SMTP id w10mr26772510wrk.293.1557949899777; Wed, 15 May 2019 12:51:39 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x64sm4829298wmg.17.2019.05.15.12.51.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 12:51:39 -0700 (PDT) Date: Wed, 15 May 2019 20:51:37 +0100 From: "Leif Lindholm" To: Hao A Wu Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-platforms][PATCH v1 14/16] Platform/LeMaker: Use ReportStatusCodeLib in MdeModulePkg Message-ID: <20190515195137.nutxyrboqv3xot6s@bivouac.eciton.net> References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-17-hao.a.wu@intel.com> MIME-Version: 1.0 In-Reply-To: <20190514020831.7728-17-hao.a.wu@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 14, 2019 at 10:08:29AM +0800, Hao A Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 > > This commit will update the DSC file to consume the ReportStatusCodeLib > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the > one in IntelFrameworkModulePkg. > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus, > there is no functional impact for this commit. This is inaccurate - there are non-trivial differences which could definitely impact runtime behaviour. This patch definitely needs testing, and the message needs rewording. / Leif > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Hao A Wu > --- > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > index bb68763743..1eec89e088 100644 > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > @@ -194,12 +194,12 @@ DEFINE NUM_CORES = 4 > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf > > [LibraryClasses.common.DXE_DRIVER] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > @@ -208,7 +208,7 @@ DEFINE NUM_CORES = 4 > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > !if $(TARGET) != RELEASE > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > @@ -221,7 +221,7 @@ DEFINE NUM_CORES = 4 > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > [LibraryClasses.common.UEFI_DRIVER] > - ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > -- > 2.12.0.windows.1 >