From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=w92+a76v; spf=pass (domain: arm.com, ip: 40.107.3.87, mailfrom: krzysztof.koch@arm.com) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (EUR03-AM5-obe.outbound.protection.outlook.com [40.107.3.87]) by groups.io with SMTP; Thu, 16 May 2019 07:53:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zwb1tkmlYepBFqAMhM3DGsZIgby6bgzG7JipNH0Kl4=; b=w92+a76vbDvwRYbQpHvDvT+88CzNoTerMiiBk4fKykAo0nDs44aN/Aq1VHIqxgw+JlszNNYhAgEswI/CmvFzZZ7eROcSRYVojHxCHHYYQgS+uIFrIdIXK+WwNfUJWTgeZTwkKHgt35CGB3oBsAOXjgAfP+6s0+BEiR3QefOtb0A= Received: from HE1PR08CA0046.eurprd08.prod.outlook.com (2603:10a6:7:2a::17) by AM5PR0802MB2499.eurprd08.prod.outlook.com (2603:10a6:203:a1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Thu, 16 May 2019 14:52:58 +0000 Received: from DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::208) by HE1PR08CA0046.outlook.office365.com (2603:10a6:7:2a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1900.16 via Frontend Transport; Thu, 16 May 2019 14:52:58 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT048.mail.protection.outlook.com (10.152.21.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.1856.11 via Frontend Transport; Thu, 16 May 2019 14:52:56 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Thu, 16 May 2019 14:52:52 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Thu, 16 May 2019 14:52:51 +0000 Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Thu, 16 May 2019 14:52:50 +0000 From: "Krzysztof Koch" To: CC: , , , , , Subject: [PATCH v1 1/1] DynamicTablesPkg: Add ACPI 6.3 SPE support to MADT generator Date: Thu, 16 May 2019 15:52:45 +0100 Message-ID: <20190516145245.32572-1-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 Return-Path: Krzysztof.Koch@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(39860400002)(346002)(376002)(396003)(2980300002)(199004)(189003)(966005)(6666004)(72206003)(478600001)(86362001)(356004)(50226002)(16586007)(2616005)(30864003)(54906003)(4326008)(53416004)(36756003)(6306002)(53936002)(1076003)(68736007)(316002)(2906002)(48376002)(47776003)(305945005)(70586007)(70206006)(2351001)(5660300002)(50466002)(77096007)(81166006)(186003)(81156014)(8936002)(26005)(486006)(51416003)(8676002)(7696005)(44832011)(426003)(336012)(6916009)(63350400001)(476003)(126002)(63370400001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0802MB2499;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 119c8535-7e91-4b48-f1e1-08d6da0e2e87 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328);SRVR:AM5PR0802MB2499; X-MS-TrafficTypeDiagnostic: AM5PR0802MB2499: X-MS-Exchange-PUrlCount: 1 NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 0039C6E5C5 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: j2VFTpMFZLJMSY6/vCVbve1Xik6qs+TGhGNVVyUWLbWx1YEU0VhoLmtPLI+1QyRmueKH+A/GoxvHhzpcLLQjQeY3egd4XAuib10Sgs6++RSlIg9/n7xbrw5qZHhUdv+R7L5gFOwuood3sqkMEYjR+eUTcArnSv2VypfR6X9RIfzck3mZxEdNdADLlkUHXXY3FhjtXGe1sxmMHlsYYdbEDLNeXxg/5SX1rm7it2/9pcdyjv2S+Ury3LZYNuh5Y1JTtrfXA4f+41UjT/IFWV0v0mNvmkoYtJzWstjkH+v10mP69vht/85XFtaT4Rq0TBkxvHIa4oeRpTrVfSeUNqFt8mf4Rtj/XSCiS1hGuo4zpQNSn/UFDeerJzy/OnOmQMdKEMyhMwO+dtioxSaFfrVWJ/uGlZ4bQ08hVDuUoC0vBGY= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2019 14:52:56.4422 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 119c8535-7e91-4b48-f1e1-08d6da0e2e87 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2499 Content-Type: text/plain The Dynamic Tables Framework now supports generating Multiple APIC Description Table (MADT) revision 5 for ARM platforms while maintaining backward-compatibility with ACPI 6.2. The relevant change is the enablement of the Statistical Profiling Extension (SPE). Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/476_madt_add_spe_v1 Notes: v1: - Add support for SPE in MADT generator [Krzysztof] DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 7 ++ DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 105 +++++++++++--------- 2 files changed, 66 insertions(+), 46 deletions(-) diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h index bf70dc76cea044b9a8e8eb529d2ddbf892bafd58..d9dcca12db68d16d3ddb73553ecd2383358832e7 100644 --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h @@ -155,6 +155,13 @@ typedef struct CmArmGicCInfo { ACPI Specification. */ UINT8 ProcessorPowerEfficiencyClass; + + /** Statistical Profiling Extension buffer overflow GSIV. Zero if + unsupported by this processor. This field was introduced in + ACPI 6.3 (MADT revision 5) and is therefore ignored when + generating MADT revision 4 or lower. + */ + UINT16 SpeOverflowInterrupt; } CM_ARM_GICC_INFO; /** A structure that describes the diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c index ab9734fb31480f1b653227d1d56abf60bb04f98a..3945d18d76915938081a5ef36fc9e50261ea3a0a 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c @@ -5,7 +5,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent @par Reference(s): - - ACPI 6.2 Specification - Errata A, September 2017 + - ACPI 6.3 Specification - January 2019 **/ @@ -82,25 +82,27 @@ GET_OBJECT_LIST ( ); /** This function updates the GIC CPU Interface Information in the - EFI_ACPI_6_2_GIC_STRUCTURE structure. + EFI_ACPI_6_3_GIC_STRUCTURE structure. - @param [in] Gicc Pointer to GIC CPU Interface structure. - @param [in] GicCInfo Pointer to the GIC CPU Interface Information. + @param [in] Gicc Pointer to GIC CPU Interface structure. + @param [in] GicCInfo Pointer to the GIC CPU Interface Information. + @param [in] MadtRev MADT table revision. **/ STATIC VOID AddGICC ( - IN EFI_ACPI_6_2_GIC_STRUCTURE * CONST Gicc, - IN CONST CM_ARM_GICC_INFO * CONST GicCInfo + IN EFI_ACPI_6_3_GIC_STRUCTURE * CONST Gicc, + IN CONST CM_ARM_GICC_INFO * CONST GicCInfo, + IN CONST UINT8 MadtRev ) { ASSERT (Gicc != NULL); ASSERT (GicCInfo != NULL); // UINT8 Type - Gicc->Type = EFI_ACPI_6_2_GIC; + Gicc->Type = EFI_ACPI_6_3_GIC; // UINT8 Length - Gicc->Length = sizeof (EFI_ACPI_6_2_GIC_STRUCTURE); + Gicc->Length = sizeof (EFI_ACPI_6_3_GIC_STRUCTURE); // UINT16 Reserved Gicc->Reserved = EFI_ACPI_RESERVED_WORD; @@ -134,10 +136,18 @@ AddGICC ( // UINT8 ProcessorPowerEfficiencyClass Gicc->ProcessorPowerEfficiencyClass = GicCInfo->ProcessorPowerEfficiencyClass; - // UINT8 Reserved2[3] - Gicc->Reserved2[0] = EFI_ACPI_RESERVED_BYTE; - Gicc->Reserved2[1] = EFI_ACPI_RESERVED_BYTE; - Gicc->Reserved2[2] = EFI_ACPI_RESERVED_BYTE; + // UINT8 Reserved2 + Gicc->Reserved2 = EFI_ACPI_RESERVED_BYTE; + + // UINT16 SpeOverflowInterrupt + if (MadtRev > EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION) { + Gicc->SpeOverflowInterrupt = GicCInfo->SpeOverflowInterrupt; + } else { + // Setting SpeOverflowInterrupt to 0 ensures backward compatibility with + // ACPI 6.2 by also clearing the Reserved2[1] and Reserved2[2] fields + // in EFI_ACPI_6_2_GIC_STRUCTURE. + Gicc->SpeOverflowInterrupt = 0; + } } /** Add the GIC CPU Interface Information to the MADT Table. @@ -147,20 +157,22 @@ AddGICC ( @param [in] GicCInfo Pointer to the GIC CPU Information list. @param [in] GicCCount Count of GIC CPU Interfaces. + @param [in] MadtRev MADT table revision. **/ STATIC VOID AddGICCList ( - IN EFI_ACPI_6_2_GIC_STRUCTURE * Gicc, + IN EFI_ACPI_6_3_GIC_STRUCTURE * Gicc, IN CONST CM_ARM_GICC_INFO * GicCInfo, - IN UINT32 GicCCount + IN UINT32 GicCCount, + IN CONST UINT8 MadtRev ) { ASSERT (Gicc != NULL); ASSERT (GicCInfo != NULL); while (GicCCount-- != 0) { - AddGICC (Gicc++, GicCInfo++); + AddGICC (Gicc++, GicCInfo++, MadtRev); } } @@ -172,7 +184,7 @@ AddGICCList ( STATIC VOID AddGICD ( - EFI_ACPI_6_2_GIC_DISTRIBUTOR_STRUCTURE * CONST Gicd, + EFI_ACPI_6_3_GIC_DISTRIBUTOR_STRUCTURE * CONST Gicd, CONST CM_ARM_GICD_INFO * CONST GicDInfo ) { @@ -180,9 +192,9 @@ AddGICD ( ASSERT (GicDInfo != NULL); // UINT8 Type - Gicd->Type = EFI_ACPI_6_2_GICD; + Gicd->Type = EFI_ACPI_6_3_GICD; // UINT8 Length - Gicd->Length = sizeof (EFI_ACPI_6_2_GIC_DISTRIBUTOR_STRUCTURE); + Gicd->Length = sizeof (EFI_ACPI_6_3_GIC_DISTRIBUTOR_STRUCTURE); // UINT16 Reserved Gicd->Reserved1 = EFI_ACPI_RESERVED_WORD; // UINT32 Identifier @@ -209,15 +221,15 @@ AddGICD ( STATIC VOID AddGICMsiFrame ( - IN EFI_ACPI_6_2_GIC_MSI_FRAME_STRUCTURE * CONST GicMsiFrame, + IN EFI_ACPI_6_3_GIC_MSI_FRAME_STRUCTURE * CONST GicMsiFrame, IN CONST CM_ARM_GIC_MSI_FRAME_INFO * CONST GicMsiFrameInfo ) { ASSERT (GicMsiFrame != NULL); ASSERT (GicMsiFrameInfo != NULL); - GicMsiFrame->Type = EFI_ACPI_6_2_GIC_MSI_FRAME; - GicMsiFrame->Length = sizeof (EFI_ACPI_6_2_GIC_MSI_FRAME_STRUCTURE); + GicMsiFrame->Type = EFI_ACPI_6_3_GIC_MSI_FRAME; + GicMsiFrame->Length = sizeof (EFI_ACPI_6_3_GIC_MSI_FRAME_STRUCTURE); GicMsiFrame->Reserved1 = EFI_ACPI_RESERVED_WORD; GicMsiFrame->GicMsiFrameId = GicMsiFrameInfo->GicMsiFrameId; GicMsiFrame->PhysicalBaseAddress = GicMsiFrameInfo->PhysicalBaseAddress; @@ -236,7 +248,7 @@ AddGICMsiFrame ( STATIC VOID AddGICMsiFrameInfoList ( - IN EFI_ACPI_6_2_GIC_MSI_FRAME_STRUCTURE * GicMsiFrame, + IN EFI_ACPI_6_3_GIC_MSI_FRAME_STRUCTURE * GicMsiFrame, IN CONST CM_ARM_GIC_MSI_FRAME_INFO * GicMsiFrameInfo, IN UINT32 GicMsiFrameCount ) @@ -257,15 +269,15 @@ AddGICMsiFrameInfoList ( STATIC VOID AddGICRedistributor ( - IN EFI_ACPI_6_2_GICR_STRUCTURE * CONST Gicr, + IN EFI_ACPI_6_3_GICR_STRUCTURE * CONST Gicr, IN CONST CM_ARM_GIC_REDIST_INFO * CONST GicRedisributorInfo ) { ASSERT (Gicr != NULL); ASSERT (GicRedisributorInfo != NULL); - Gicr->Type = EFI_ACPI_6_2_GICR; - Gicr->Length = sizeof (EFI_ACPI_6_2_GICR_STRUCTURE); + Gicr->Type = EFI_ACPI_6_3_GICR; + Gicr->Length = sizeof (EFI_ACPI_6_3_GICR_STRUCTURE); Gicr->Reserved = EFI_ACPI_RESERVED_WORD; Gicr->DiscoveryRangeBaseAddress = GicRedisributorInfo->DiscoveryRangeBaseAddress; @@ -281,7 +293,7 @@ AddGICRedistributor ( STATIC VOID AddGICRedistributorList ( - IN EFI_ACPI_6_2_GICR_STRUCTURE * Gicr, + IN EFI_ACPI_6_3_GICR_STRUCTURE * Gicr, IN CONST CM_ARM_GIC_REDIST_INFO * GicRInfo, IN UINT32 GicRCount ) @@ -302,15 +314,15 @@ AddGICRedistributorList ( STATIC VOID AddGICInterruptTranslationService ( - IN EFI_ACPI_6_2_GIC_ITS_STRUCTURE * CONST GicIts, + IN EFI_ACPI_6_3_GIC_ITS_STRUCTURE * CONST GicIts, IN CONST CM_ARM_GIC_ITS_INFO * CONST GicItsInfo ) { ASSERT (GicIts != NULL); ASSERT (GicItsInfo != NULL); - GicIts->Type = EFI_ACPI_6_2_GIC_ITS; - GicIts->Length = sizeof (EFI_ACPI_6_2_GIC_ITS_STRUCTURE); + GicIts->Type = EFI_ACPI_6_3_GIC_ITS; + GicIts->Length = sizeof (EFI_ACPI_6_3_GIC_ITS_STRUCTURE); GicIts->Reserved = EFI_ACPI_RESERVED_WORD; GicIts->GicItsId = GicItsInfo->GicItsId; GicIts->PhysicalBaseAddress = GicItsInfo->PhysicalBaseAddress; @@ -327,7 +339,7 @@ AddGICInterruptTranslationService ( STATIC VOID AddGICItsList ( - IN EFI_ACPI_6_2_GIC_ITS_STRUCTURE * GicIts, + IN EFI_ACPI_6_3_GIC_ITS_STRUCTURE * GicIts, IN CONST CM_ARM_GIC_ITS_INFO * GicItsInfo, IN UINT32 GicItsCount ) @@ -390,7 +402,7 @@ BuildMadtTable ( UINT32 GicRedistOffset; UINT32 GicItsOffset; - EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER * Madt; + EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER * Madt; ASSERT (This != NULL); ASSERT (AcpiTableInfo != NULL); @@ -521,22 +533,22 @@ BuildMadtTable ( goto error_handler; } - TableSize = sizeof (EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER); + TableSize = sizeof (EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER); GicCOffset = TableSize; - TableSize += (sizeof (EFI_ACPI_6_2_GIC_STRUCTURE) * GicCCount); + TableSize += (sizeof (EFI_ACPI_6_3_GIC_STRUCTURE) * GicCCount); GicDOffset = TableSize; - TableSize += (sizeof (EFI_ACPI_6_2_GIC_DISTRIBUTOR_STRUCTURE) * GicDCount); + TableSize += (sizeof (EFI_ACPI_6_3_GIC_DISTRIBUTOR_STRUCTURE) * GicDCount); GicMSIOffset = TableSize; - TableSize += (sizeof (EFI_ACPI_6_2_GIC_MSI_FRAME_STRUCTURE) * GicMSICount); + TableSize += (sizeof (EFI_ACPI_6_3_GIC_MSI_FRAME_STRUCTURE) * GicMSICount); GicRedistOffset = TableSize; - TableSize += (sizeof (EFI_ACPI_6_2_GICR_STRUCTURE) * GicRedistCount); + TableSize += (sizeof (EFI_ACPI_6_3_GICR_STRUCTURE) * GicRedistCount); GicItsOffset = TableSize; - TableSize += (sizeof (EFI_ACPI_6_2_GIC_ITS_STRUCTURE) * GicItsCount); + TableSize += (sizeof (EFI_ACPI_6_3_GIC_ITS_STRUCTURE) * GicItsCount); // Allocate the Buffer for MADT table *Table = (EFI_ACPI_DESCRIPTION_HEADER*)AllocateZeroPool (TableSize); @@ -552,7 +564,7 @@ BuildMadtTable ( goto error_handler; } - Madt = (EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER*)*Table; + Madt = (EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER*)*Table; DEBUG (( DEBUG_INFO, @@ -578,19 +590,20 @@ BuildMadtTable ( } AddGICCList ( - (EFI_ACPI_6_2_GIC_STRUCTURE*)((UINT8*)Madt + GicCOffset), + (EFI_ACPI_6_3_GIC_STRUCTURE*)((UINT8*)Madt + GicCOffset), GicCInfo, - GicCCount + GicCCount, + Madt->Header.Revision ); AddGICD ( - (EFI_ACPI_6_2_GIC_DISTRIBUTOR_STRUCTURE*)((UINT8*)Madt + GicDOffset), + (EFI_ACPI_6_3_GIC_DISTRIBUTOR_STRUCTURE*)((UINT8*)Madt + GicDOffset), GicDInfo ); if (GicMSICount != 0) { AddGICMsiFrameInfoList ( - (EFI_ACPI_6_2_GIC_MSI_FRAME_STRUCTURE*)((UINT8*)Madt + GicMSIOffset), + (EFI_ACPI_6_3_GIC_MSI_FRAME_STRUCTURE*)((UINT8*)Madt + GicMSIOffset), GicMSIInfo, GicMSICount ); @@ -598,7 +611,7 @@ BuildMadtTable ( if (GicRedistCount != 0) { AddGICRedistributorList ( - (EFI_ACPI_6_2_GICR_STRUCTURE*)((UINT8*)Madt + GicRedistOffset), + (EFI_ACPI_6_3_GICR_STRUCTURE*)((UINT8*)Madt + GicRedistOffset), GicRedistInfo, GicRedistCount ); @@ -606,7 +619,7 @@ BuildMadtTable ( if (GicItsCount != 0) { AddGICItsList ( - (EFI_ACPI_6_2_GIC_ITS_STRUCTURE*)((UINT8*)Madt + GicItsOffset), + (EFI_ACPI_6_3_GIC_ITS_STRUCTURE*)((UINT8*)Madt + GicItsOffset), GicItsInfo, GicItsCount ); @@ -673,9 +686,9 @@ ACPI_TABLE_GENERATOR MadtGenerator = { // Generator Description L"ACPI.STD.MADT.GENERATOR", // ACPI Table Signature - EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, + EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, // ACPI Table Revision supported by this Generator - EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION, + EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION, // Minimum supported ACPI Table Revision EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION, // Creator ID -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'