From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=SZn+/xwC; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Thu, 16 May 2019 08:32:51 -0700 Received: by mail-wm1-f66.google.com with SMTP id c77so2627684wmd.1 for ; Thu, 16 May 2019 08:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FpZHKNl0WSamNYXVHHtFp8CsmELle0UMTzhQiJBgWXY=; b=SZn+/xwC3MCrSdSFh7RITwmOc/A3Q9P/Qn4pSO0fzXEtOxsHGd7dPjFzehUSg1Th9T 0YJdXPRon785ygnR8YCSvvBU6yTSs/AZ+Jur9MOGb8wGLbPWIZ2syjS6Wl5aNTocdWNA 8AxdWi7anCDmgbkYbiT+2IdLmygTFWO3LPUDJVnmRhUmnBPNdUtg6W5s33rDUp4/PKNu KJf4VXpGIt7nHyxJZlg4U6RMIKBHNdmkkl2HN977GfsJumZhA70jQWG88ZSN7MB7IDGe j+kRHUEFBCdwwm3LGsSg1GWIIJlCX9bmlX9qwtwIXvyoaCKLYbIAhV66/MmRBrG4I8bH ZG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FpZHKNl0WSamNYXVHHtFp8CsmELle0UMTzhQiJBgWXY=; b=HW6fL33QtyI9DbGo52oOg9pc7eD52x6ERB9Ob0YVPT4euEH6kHlv6XNir4OkpaXcH1 GQjSMjlXkEAR9yKys8mGbEuEkLPn+Qe9b5sySWAhxSB2JFF0dmU1Z0flxQTo4EYcxX0J OdYt/e21h7ndSG7LWt6l1+xl495quB8LJkERa/iB0DTyBzQVaf6vuS83h1Lqyyj01RQM RtppwgjiQoW+0Q1i+Oz1whUtJH5nM70cJtRdvpngiGfTv25oftyzbAs60Xk5f0ABjTiY 8p2gx5xKh+e6kOed51rb5QcniHKHhZppzIE4Z+o5r5JhsvUrkcsXoj4NlkmwK5GgQ+be wY8Q== X-Gm-Message-State: APjAAAVutahWokWn2bUZtHD7dxFgsfI96eOqnkw2UZ5i5utSbcsZKvFI Gi4wYUMB4GghaVCEZh7WliEjByVRXrg= X-Google-Smtp-Source: APXvYqxxIo3VOrOxCS+bCjWgftRUM8TVaYOJhXWoyNhcBmwNVUsDobqNYfiqPhGiE3j04vJkqnHATQ== X-Received: by 2002:a1c:b789:: with SMTP id h131mr27653250wmf.71.1558020769175; Thu, 16 May 2019 08:32:49 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z4sm6835818wru.69.2019.05.16.08.32.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 08:32:48 -0700 (PDT) Date: Thu, 16 May 2019 16:32:47 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH edk2-platforms 01/16] Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg's fragment file. Message-ID: <20190516153246.wvobjfg5tlmgtp6b@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-2-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-2-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 04:56:46PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang > --- > .../AMD/OverdriveBoard/OverdriveBoard.dsc | 29 +------------------ > .../AMD/OverdriveBoard/OverdriveBoard.fdf | 23 +-------------- > 2 files changed, 2 insertions(+), 50 deletions(-) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index 39b5dad154..b85b7aa03e 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -78,12 +78,6 @@ DEFINE X64EMU_ENABLE = FALSE > > BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > > - # Networking Requirements > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > - I believe this should also delete (further down): TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf and HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf With those deletions added: Reviewed-by: Leif Lindholm / Leif > # ARM Architectural Libraries > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf > DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf > @@ -641,28 +635,7 @@ DEFINE X64EMU_ENABLE = FALSE > # > # Networking stack > # > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - NetworkPkg/Ip6Dxe/Ip6Dxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > - NetworkPkg/Udp6Dxe/Udp6Dxe.inf > - NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > - NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/IScsiDxe/IScsiDxe.inf > - NetworkPkg/DnsDxe/DnsDxe.inf > - NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > - NetworkPkg/HttpDxe/HttpDxe.inf > - NetworkPkg/HttpBootDxe/HttpBootDxe.inf > - NetworkPkg/TlsDxe/TlsDxe.inf > - NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > +!include NetworkPkg/Network.dsc.inc > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > # > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf > index 2aaf83084e..49af46cd16 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf > @@ -193,28 +193,7 @@ READ_LOCK_STATUS = TRUE > # > # Networking stack > # > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > - INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > - INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf > - INF NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > - INF NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - INF NetworkPkg/IScsiDxe/IScsiDxe.inf > - INF NetworkPkg/DnsDxe/DnsDxe.inf > - INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > - INF NetworkPkg/HttpDxe/HttpDxe.inf > - INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf > - INF NetworkPkg/TlsDxe/TlsDxe.inf > - INF NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > +!include NetworkPkg/Network.fdf.inc > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > # > -- > 2.18.0.windows.1 > > > >