From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [PATCH edk2-platforms 03/16] Hisilicon/D03: Update DSC/FDF to use NetworkPkg's include fragment file.
Date: Thu, 16 May 2019 17:41:38 +0100 [thread overview]
Message-ID: <20190516164138.we4zue7r54hw3ha7@bivouac.eciton.net> (raw)
In-Reply-To: <20190515085701.24724-4-shenglei.zhang@intel.com>
On Wed, May 15, 2019 at 04:56:48PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform DSC/FDF files to use the include fragment
> files provided by NetworkPkg.
>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/Hisilicon/D03/D03.dsc | 26 +++++++++++---------------
> Platform/Hisilicon/D03/D03.fdf | 10 +---------
> 2 files changed, 12 insertions(+), 24 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index 07ff461277..d98997c59e 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -29,6 +29,16 @@
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>
> + #
> + # Network definition
> + #
> + DEFINE NETWORK_SNP_ENABLE = FALSE
> + DEFINE NETWORK_IP6_ENABLE = FALSE
> + DEFINE NETWORK_TLS_ENABLE = FALSE
> + DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> + DEFINE NETWORK_ISCSI_ENABLE = FALSE
> + DEFINE NETWORK_VLAN_ENABLE = FALSE
> +
> !include Silicon/Hisilicon/Hisilicon.dsc.inc
>
> [LibraryClasses.common]
> @@ -40,13 +50,8 @@
>
> IpmiCmdLib|Silicon/Hisilicon/Library/IpmiCmdLib/IpmiCmdLib.inf
>
> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
> - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
> -
>
>
> !ifdef $(FDT_ENABLE)
> @@ -404,16 +409,7 @@
>
> Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf
>
> - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> - NetworkPkg/TcpDxe/TcpDxe.inf
> -
> +!include NetworkPkg/Network.dsc.inc
> Platform/Hisilicon/D03/Drivers/Sas/SasDxeDriver.inf
>
> SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf
> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
> index 3f07b2e577..fc8a2945ea 100644
> --- a/Platform/Hisilicon/D03/D03.fdf
> +++ b/Platform/Hisilicon/D03/D03.fdf
> @@ -246,15 +246,7 @@ READ_LOCK_STATUS = TRUE
> INF Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf
> INF Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf
>
> - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> - INF NetworkPkg/TcpDxe/TcpDxe.inf
> +!include NetworkPkg/Network.fdf.inc
>
> !ifdef $(FDT_ENABLE)
> INF Silicon/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf
> --
> 2.18.0.windows.1
>
>
>
>
next prev parent reply other threads:[~2019-05-16 16:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 8:56 [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF Zhang, Shenglei
2019-05-15 8:56 ` [PATCH edk2-platforms 01/16] Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg's fragment file Zhang, Shenglei
2019-05-16 15:32 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 02/16] Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-16 16:24 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 03/16] Hisilicon/D03: " Zhang, Shenglei
2019-05-16 16:41 ` Leif Lindholm [this message]
2019-05-15 8:56 ` [PATCH edk2-platforms 04/16] Hisilicon/D05: " Zhang, Shenglei
2019-05-16 16:57 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 05/16] Hisilicon/D06: " Zhang, Shenglei
2019-05-16 17:02 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 06/16] Hisilicon/HiKey: " Zhang, Shenglei
2019-05-16 19:23 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 07/16] Hisilicon/HiKey960: " Zhang, Shenglei
2019-05-16 19:23 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 08/16] Platform/CelloBoard: " Zhang, Shenglei
2019-05-16 20:06 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 09/16] Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-16 20:07 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 10/16] Platform/SynQuacerEvalBoard: " Zhang, Shenglei
2019-05-16 20:10 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 11/16] Platform/Overdrive1000Board: " Zhang, Shenglei
2019-05-16 20:11 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 12/16] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-16 20:18 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:56 ` [PATCH edk2-platforms 13/16] Platform/SgiPkg: Update FDF " Zhang, Shenglei
2019-05-16 20:25 ` [edk2-devel] " Leif Lindholm
2019-05-17 6:01 ` Thomas Abraham
2019-05-15 8:56 ` [PATCH edk2-platforms 14/16] Platform/RDKQemu: Update DSC " Zhang, Shenglei
2019-05-16 20:27 ` [edk2-devel] " Leif Lindholm
2019-05-15 8:57 ` [PATCH edk2-platforms 15/16] Platform/Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-15 8:57 ` [PATCH edk2-platforms 16/16] Platform/PurleyOpenBoardPkg: " Zhang, Shenglei
2019-05-15 12:29 ` [edk2-devel] [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF Liming Gao
2019-05-16 20:30 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516164138.we4zue7r54hw3ha7@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox