From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=v7Ou3zzg; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Thu, 16 May 2019 09:41:42 -0700 Received: by mail-wm1-f67.google.com with SMTP id j187so4164877wmj.1 for ; Thu, 16 May 2019 09:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TNi1VIn6qTzabk9yCQjRW3ySQY/i7kdcA6viIr/BmCE=; b=v7Ou3zzg5XEnnqW292Szaf+IiHgH+RfLKaL7/pbWYFX2aJBulg23HBRoElYXwvJghu ehcSVEp1rQpWJqyRQpEJIFY0sCp5pkzWi5hxmIf+rsp3KLGobJ6Sk39GF1AiJ6rjIgPW XTkwUT5aUHCcJ8PB8VI0Yxzli8veTwepTZZ8bYA/y+pYvKRzcKzHvGRhihfsTCAX7Ghe dW9zvPnpvRNY8VO6SQyd00M25rvtuOgE8W8heBNfc01VRzFNqJOlrMlhSQMPmo2Oj+X3 slD3qnNjFca5qJ6OmG/s0gGqltyylvpuarFlwzEC6cUTkPSsuMN7AVw42k58WYeFaV78 WK5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TNi1VIn6qTzabk9yCQjRW3ySQY/i7kdcA6viIr/BmCE=; b=UsUcqi9uA90UgRxVzvpvUV/P9N81H/GBCQxgFg0fgZRDFfRuZiMhoH5NwoRao1n5z1 rHCQWOZo/UoqR63zTqxmKpccxDVu805svy+a3Ma2f61Meds1JGlp8YV6GF6DA+YW2IW4 eQmMoFTH7aBv+6C257SKZEPquxVqG114zkl7XLtZmr2uAi7VSOTC3zSN2EGW3OvKTaS5 0KFiW2ArFyc7AGkCkfQGU3EBpJHfq+K1DSRp8ATUBpj0UHcR2UhONnAeiRPyQsj9AQJW O8mDmpUWkKNH3A7YSdkCw512/OIO4gcSZK4aqWBkQFkXbVOFZnka8+fqNnIHQDtgvU6v 255w== X-Gm-Message-State: APjAAAVvt995jSMKA0ZHrRQFDYTS7wWd55UjGsCFZgH8OgKqVh7ZIxCU EpbFPGfTMjkqyC2ebKCHvOFj2nIdhSI= X-Google-Smtp-Source: APXvYqzOnWjyDcKn/pa7lqBXfID+No/qTmllor7cPPMT2RPlToZ8e+2iyyu3mycsi7CD9DKgADgxCQ== X-Received: by 2002:a7b:cb11:: with SMTP id u17mr27784784wmj.55.1558024900514; Thu, 16 May 2019 09:41:40 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a4sm7642932wmf.45.2019.05.16.09.41.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 09:41:39 -0700 (PDT) Date: Thu, 16 May 2019 17:41:38 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH edk2-platforms 03/16] Hisilicon/D03: Update DSC/FDF to use NetworkPkg's include fragment file. Message-ID: <20190516164138.we4zue7r54hw3ha7@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-4-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-4-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 04:56:48PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D03/D03.dsc | 26 +++++++++++--------------- > Platform/Hisilicon/D03/D03.fdf | 10 +--------- > 2 files changed, 12 insertions(+), 24 deletions(-) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index 07ff461277..d98997c59e 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -29,6 +29,16 @@ > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > + # > + # Network definition > + # > + DEFINE NETWORK_SNP_ENABLE = FALSE > + DEFINE NETWORK_IP6_ENABLE = FALSE > + DEFINE NETWORK_TLS_ENABLE = FALSE > + DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > + DEFINE NETWORK_ISCSI_ENABLE = FALSE > + DEFINE NETWORK_VLAN_ENABLE = FALSE > + > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > [LibraryClasses.common] > @@ -40,13 +50,8 @@ > > IpmiCmdLib|Silicon/Hisilicon/Library/IpmiCmdLib/IpmiCmdLib.inf > > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > - > > > !ifdef $(FDT_ENABLE) > @@ -404,16 +409,7 @@ > > Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf > > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > - > +!include NetworkPkg/Network.dsc.inc > Platform/Hisilicon/D03/Drivers/Sas/SasDxeDriver.inf > > SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf > diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf > index 3f07b2e577..fc8a2945ea 100644 > --- a/Platform/Hisilicon/D03/D03.fdf > +++ b/Platform/Hisilicon/D03/D03.fdf > @@ -246,15 +246,7 @@ READ_LOCK_STATUS = TRUE > INF Silicon/Hisilicon/Drivers/SnpPlatform/SnpPlatform.inf > INF Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.inf > > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > +!include NetworkPkg/Network.fdf.inc > > !ifdef $(FDT_ENABLE) > INF Silicon/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > -- > 2.18.0.windows.1 > > > >