From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Iovl6AF3; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Thu, 16 May 2019 12:23:30 -0700 Received: by mail-wr1-f67.google.com with SMTP id f8so3214880wrt.1 for ; Thu, 16 May 2019 12:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UX0OAoKOIZZ9KU3rznj5YGi/Rh+iZ/EWA5ZztHT/688=; b=Iovl6AF3AsXBy1sOUE3UXM2dqBYDmr8T6MxmJ3rHdzP+vJH/vjv89FtXMczI0V4Y4h +NFROxoRLmWCH0aqhic6s6ZOomA2roHi/V77e08YwYrLY0P0iR9ek3wTfVuZ1xmfPrZo 2pcwPy9ArK4TsVQ1MivfrJbZRBtGmWA+bumpZl7T8RocBz2TwFN/tR15s3lurEOO4jUN hdTbFytgqimP11BkxSn1NOz6eIRFVEUm0tthMdSswM2qoQd9pIIm/3AIH6lGIz0yNYqI 38jBDmIRORKOPFvP+vLFMMN2DptLn1s+XzR7erNFKrDsVrZMnCn5SyGN+UYRnNHd8ZNL sT0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UX0OAoKOIZZ9KU3rznj5YGi/Rh+iZ/EWA5ZztHT/688=; b=qlxMZKtVC3eU6I+YXRD7omgW7tjMR/UyyzwCEblx+piEJ+ZBVvy/zhdHJvKSWlt6oF c9/v7HF6tQrjQbF+ySwZH4WHvGLguR9EuZrIYLPbWradiVVDlYEP0wTtFKUyC0HF2+SP RKxnmbEk4E2X7e12mwlchbhsvQo81ZxTvWJf9SHIgCLCkk1ZZoavGL+xs15Es+yIBkNM /izGxNacSSq/wZCtseIP57N9wguzclNxiDZmZuA6nSIcvt9uqUWH+SimY/UZnwRvsSGL c9A96u+0PHFLlNbo3VLktXH+wZwYrTXV/4XFRUW4+P3+92P3NfqX3KHtvuuUL8kkewUK nEBQ== X-Gm-Message-State: APjAAAUgNck8w9JczqEsgszw+9PVxbxQ96B1NeyJyv6o2sx8sFlH3SbP bc4gbvIDm5+i8i0fgPDfZTsPhRRwU+E= X-Google-Smtp-Source: APXvYqzz2fzcWUyVp/i7HYB6BWEY+zsliQDtdwzou+1Uax2WMC3ux69xoSGTO1FTqs365CipGooOAQ== X-Received: by 2002:adf:9042:: with SMTP id h60mr31076113wrh.248.1558034608728; Thu, 16 May 2019 12:23:28 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c11sm4831285wrs.86.2019.05.16.12.23.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 12:23:28 -0700 (PDT) Date: Thu, 16 May 2019 20:23:26 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH edk2-platforms 06/16] Hisilicon/HiKey: Update DSC/FDF to use NetworkPkg's include fragment file. Message-ID: <20190516192326.plaeydmocnxorrbg@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-7-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-7-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 04:56:51PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/HiKey/HiKey.dsc | 26 ++++++++++---------------- > Platform/Hisilicon/HiKey/HiKey.fdf | 10 +--------- > 2 files changed, 11 insertions(+), 25 deletions(-) > > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc > index 7e05babb6c..2081e95b06 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > @@ -28,6 +28,15 @@ > > DEFINE CONFIG_NO_DEBUGLIB = TRUE > > + # > + # Network definition > + # > + DEFINE NETWORK_SNP_ENABLE = FALSE > + DEFINE NETWORK_IP6_ENABLE = FALSE > + DEFINE NETWORK_TLS_ENABLE = FALSE > + DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > + DEFINE NETWORK_ISCSI_ENABLE = FALSE > + DEFINE NETWORK_VLAN_ENABLE = FALSE > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > [LibraryClasses.common] > @@ -53,12 +62,6 @@ > # USB Requirements > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > - # Network Libraries > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > - > # VariableRuntimeDxe Requirements > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > @@ -245,16 +248,7 @@ > # > # UEFI Network Stack > # > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > - > +!include NetworkPkg/Network.dsc.inc > # > # AX88772 Ethernet Driver > # > diff --git a/Platform/Hisilicon/HiKey/HiKey.fdf b/Platform/Hisilicon/HiKey/HiKey.fdf > index 7e6c8083bb..aadbfc0075 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.fdf > +++ b/Platform/Hisilicon/HiKey/HiKey.fdf > @@ -159,15 +159,7 @@ READ_LOCK_STATUS = TRUE > # > # UEFI Network Stack > # > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > +!include NetworkPkg/Network.fdf.inc > > # > # AX88772 Ethernet Driver for Apple Ethernet Adapter > -- > 2.18.0.windows.1 > > > >