From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=qMxzYU1F; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Thu, 16 May 2019 12:23:53 -0700 Received: by mail-wr1-f66.google.com with SMTP id l2so4596411wrb.9 for ; Thu, 16 May 2019 12:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rNmIJkvFj6CgOWkhPJOKDnRMnRa6V+YAXMJukwQcSvo=; b=qMxzYU1Foy3bQ6tXbuqfIKoj9R83gmAviQBjTL9PovAv5GDUtwPXOaYU5frOE2OuWN WttdchiiaFVoHOZ3cBToGwRdF/D2zGlx1oTlRRwkTJKt5V4J5L+mwpjwS3ULADqScXG7 RJ0i1XsjPlno9bKEQfVBiRPktc7UWIGMuSY4zam3a34X5nxOw2cXJI9PFj6EoiVYnm9z IrXooF4AdHttM+ulV9f9NK0ikb/ckijr6QoC7uGsUKj1hcv4xCGB8BiofsOl/vQ6VFXL NZt5izXb/xfwQK6e/2CwP3j81XFRzScnvVnmSFCB+2lnzT3xt4KAgw92jlDeIaDk5Lp9 XPcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rNmIJkvFj6CgOWkhPJOKDnRMnRa6V+YAXMJukwQcSvo=; b=hwVnz6krgLxeVcJktUqn7LsJWnb9ItkC9UFe7FWiki88fAnoDMyApK88mO0GDkF8bu LsdKwmUWVfajfqLGBvpGZuCqPalAKamgIVKCwhWmn/K74UCcQyExOxby/ff9XpW3jlvG DlME0yYE0ZfOTdmYMfHIDkSUumKrLlfovlerczCZOiKa5CeyVyJ8daXo/W59nYNeObm/ xcNyb0dHlLa/iiJ2Kj0dzHxbCHWuDVDgKdiQqrHsGr+SbAPn2Y1D3epIE/n9yxNbjdp0 IuMbekgk+EM+7Q+pQ2Oea0Lwe1xFFEQqvJyj6sWmK9XvpLc6DjEsUf8Q1L4kaowyINc0 4Qmw== X-Gm-Message-State: APjAAAV1Tw8zvnBOzOLDkAdiREYN5ZDJHuMlBpmgg5EdSQv41hpA0lTc FQpKC5eURIh2RJVt4amAH82FMuxKa8M= X-Google-Smtp-Source: APXvYqyolzHh6O543OeZKgVY+byOTTp2xW90CHLAwql0D7MMusjaf2hfNkQSIdZpRX4TuV/ST6Bwzw== X-Received: by 2002:adf:efc8:: with SMTP id i8mr26052996wrp.111.1558034631006; Thu, 16 May 2019 12:23:51 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l127sm8154740wml.40.2019.05.16.12.23.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 12:23:50 -0700 (PDT) Date: Thu, 16 May 2019 20:23:49 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Subject: Re: [edk2-devel] [PATCH edk2-platforms 07/16] Hisilicon/HiKey960: Update DSC/FDF to use NetworkPkg's include fragment file. Message-ID: <20190516192349.i7da5pnrfjwgrl3g@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-8-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-8-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 04:56:52PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/HiKey960/HiKey960.dsc | 25 ++++++++++-------------- > Platform/Hisilicon/HiKey960/HiKey960.fdf | 11 +---------- > 2 files changed, 11 insertions(+), 25 deletions(-) > > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc > index a4a1a371de..f127159138 100644 > --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc > +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc > @@ -28,6 +28,15 @@ > > DEFINE CONFIG_NO_DEBUGLIB = TRUE > > + # > + # Network definition > + # > + DEFINE NETWORK_SNP_ENABLE = FALSE > + DEFINE NETWORK_IP6_ENABLE = FALSE > + DEFINE NETWORK_TLS_ENABLE = FALSE > + DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > + DEFINE NETWORK_ISCSI_ENABLE = FALSE > + DEFINE NETWORK_VLAN_ENABLE = FALSE > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > [LibraryClasses.common] > @@ -54,11 +63,6 @@ > > # Network Libraries > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > - > # VariableRuntimeDxe Requirements > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > @@ -229,16 +233,7 @@ > # > # UEFI Network Stack > # > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > - > +!include NetworkPkg/Network.dsc.inc > # > # FAT filesystem + GPT/MBR partitioning > # > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.fdf b/Platform/Hisilicon/HiKey960/HiKey960.fdf > index 1b07284dc8..def66d41d4 100644 > --- a/Platform/Hisilicon/HiKey960/HiKey960.fdf > +++ b/Platform/Hisilicon/HiKey960/HiKey960.fdf > @@ -153,16 +153,7 @@ READ_LOCK_STATUS = TRUE > # > # UEFI Network Stack > # > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > - > +!include NetworkPkg/Network.fdf.inc > # > # FAT filesystem + GPT/MBR partitioning > # > -- > 2.18.0.windows.1 > > > >