From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=JqwPv9ty; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Thu, 16 May 2019 13:07:29 -0700 Received: by mail-wr1-f67.google.com with SMTP id h4so4727446wre.7 for ; Thu, 16 May 2019 13:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MBDeEZbc6BuJGCRIg9UWkMTXtUo8DsVyVa90Pcl1zIM=; b=JqwPv9tyaT9wLBOdyussG6bbT4a5nlbtCLbUTOvTKBy9JyqECp7wMYJ+aVTSIxSjLB d6FXY5tmen3fqKx+AjfBnWFyeZ7LHd1hbFK7/BRemIpNfOmpMd9Q4MzN1njwFu3SiQkU PmJ4M58rurlEwj2xrbEbhdajuHh9+pRKEwFFiMXGy9zBbKaMBmHxLgYJFaRCZnWNCtB9 aQ3Mz1GFmqB2wwuUPjCQAtFha7xrIAKUrhfoGzQ09xAR8gjrfKV5aOZIM8eBx0EgFrvW yx4FM6dgBWa9UVKHgfqTRYD+tyHsYpBjOTEasc8Q7pYTh8NDghzqMhHNmQjNSKk9UWLW 0P3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MBDeEZbc6BuJGCRIg9UWkMTXtUo8DsVyVa90Pcl1zIM=; b=PsXhgtq+yxjRzx1IwqDsyyaIw9ePvVORQQ/FAWeEh4iMKzGFlkyNTTZK6ikMvA2MbC 39sI+2UR0lDzIbIjRy2TDcBsyWmYaz1IXuxk44ltRVy4cl/wQYU47AVWEZtU/oJUKDFx vophaY3AwyLjxKHKQmCamYzKso+0ZpKk6KWKUpIhz+C4NJQ+vAyATyd/aZwB5iE/xEO6 bj5B1F1u3CxO3QrmPLeK37UK21I1cJYcDABz+JfoVtx/tbJsn+ON1f8NeTTQW4OWu9IS 1o25Bu1OcWy+NRb3MZHLU4iPJCWPYCQQe0CWuWIILpcLZAeOFEBv2qSGfi37qvgCqa96 F5+Q== X-Gm-Message-State: APjAAAWYYrAxC21KEnvWxP7zk9U6GzeoAjc+DyQMn7Aahj9cRxU0guHG WckK1MwuMsKOJRcugut8/toVHfqSVz8= X-Google-Smtp-Source: APXvYqwYl8/i8G9P4oW9/7zhG0HDkH6W5mvwbMmgVOmqBcJiCM4xwd994RfPkq2PEwqKujsYB9ZAtw== X-Received: by 2002:adf:f6cb:: with SMTP id y11mr33736363wrp.67.1558037247758; Thu, 16 May 2019 13:07:27 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id k184sm11116556wmk.0.2019.05.16.13.07.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 13:07:27 -0700 (PDT) Date: Thu, 16 May 2019 21:07:25 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Subject: Re: [edk2-devel] [PATCH edk2-platforms 09/16] Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg's fragment file. Message-ID: <20190516200725.saknvcybt4mv7cy3@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-10-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-10-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 04:56:54PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > .../Socionext/DeveloperBox/DeveloperBox.dsc | 29 +++++-------------- > .../Socionext/DeveloperBox/DeveloperBox.fdf | 24 ++------------- > 2 files changed, 9 insertions(+), 44 deletions(-) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 909cfb5507..24f221a022 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -28,6 +28,11 @@ > FLASH_DEFINITION = Platform/Socionext/DeveloperBox/DeveloperBox.fdf > BUILD_NUMBER = 1 > > + # > + # Network definition > + # > + DEFINE NETWORK_TLS_ENABLE = FALSE > + > DEFINE DEBUG_ON_UART1 = FALSE > DEFINE SECURE_BOOT_ENABLE = FALSE > DEFINE X64EMU_ENABLE = FALSE > @@ -410,28 +415,8 @@ > # > # Networking stack > # > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - NetworkPkg/Ip6Dxe/Ip6Dxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > - NetworkPkg/Udp6Dxe/Udp6Dxe.inf > - NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > - NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/IScsiDxe/IScsiDxe.inf > - NetworkPkg/DnsDxe/DnsDxe.inf > - NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > - NetworkPkg/HttpDxe/HttpDxe.inf > - NetworkPkg/HttpBootDxe/HttpBootDxe.inf > - NetworkPkg/TlsDxe/TlsDxe.inf > - NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > +!include NetworkPkg/Network.dsc.inc > + > Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf { > > DmaLib|EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.inf > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf > index 5309a77c1a..10c5307ebf 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf > @@ -215,28 +215,8 @@ READ_LOCK_STATUS = TRUE > # > # Networking stack > # > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > - INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > - INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf > - INF NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > - INF NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - INF NetworkPkg/IScsiDxe/IScsiDxe.inf > - INF NetworkPkg/DnsDxe/DnsDxe.inf > - INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > - INF NetworkPkg/HttpDxe/HttpDxe.inf > - INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf > - INF NetworkPkg/TlsDxe/TlsDxe.inf > - INF NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf > +!include NetworkPkg/Network.fdf.inc > + > INF Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.inf > > # > -- > 2.18.0.windows.1 > > > >