public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [PATCH edk2-platforms 11/16] Platform/Overdrive1000Board: Update DSC/FDF to use NetworkPkg's fragment file.
Date: Thu, 16 May 2019 21:11:16 +0100	[thread overview]
Message-ID: <20190516201116.7t5oodtzxac4xr2z@bivouac.eciton.net> (raw)
In-Reply-To: <20190515085701.24724-12-shenglei.zhang@intel.com>

On Wed, May 15, 2019 at 04:56:56PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform DSC/FDF files to use the include fragment
> files provided by NetworkPkg.
> 
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  .../Overdrive1000Board/Overdrive1000Board.dsc | 27 +++++++------------
>  .../Overdrive1000Board/Overdrive1000Board.fdf | 16 +----------
>  2 files changed, 10 insertions(+), 33 deletions(-)
> 
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index cc4f2facd0..3dc805921c 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -29,6 +29,14 @@ DEFINE NUM_CORES    = 4
>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
>  
> +  #
> +  # Network definition
> +  #
> +  DEFINE NETWORK_IP6_ENABLE             = FALSE
> +  DEFINE NETWORK_TLS_ENABLE             = FALSE
> +  DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
> +  DEFINE NETWORK_ISCSI_ENABLE           = FALSE
> +
>  ################################################################################
>  #
>  # Library Class section - list of all Library Classes needed by this Platform.
> @@ -75,11 +83,6 @@ DEFINE NUM_CORES    = 4
>  
>    BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
>  
> -  # Networking Requirements
> -  NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> -  DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> -  UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> -  IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
>  
>    # ARM Architectural Libraries
>    CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
> @@ -572,23 +575,11 @@ DEFINE NUM_CORES    = 4
>    #
>    # Networking stack
>    #
> -  MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf
> -  MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> -  MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> -  MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> -# MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf
> -  MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> +!include NetworkPkg/Network.dsc.inc
>    MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf {
>      <PcdsFixedAtBuild>
>        gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x21
>    }
> -  MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> -  MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> -  MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> -  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> -  NetworkPkg/TcpDxe/TcpDxe.inf
> -## Bug https://bugs.linaro.org/show_bug.cgi?id=2239
> -# NetworkPkg/IScsiDxe/IScsiDxe.inf
>  
>    #
>    # Core Info
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
> index fa814880e0..6d7cfb3933 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf
> @@ -185,21 +185,7 @@ READ_LOCK_STATUS   = TRUE
>    #
>    # Networking stack
>    #
> -  INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf
> -  INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> -  INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> -  INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> -# INF MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf
> -  INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> -  INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> -  INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> -  INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> -  INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> -  INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> -  INF NetworkPkg/TcpDxe/TcpDxe.inf
> -## Bug https://bugs.linaro.org/show_bug.cgi?id=2239
> -# INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> -
> +!include NetworkPkg/Network.fdf.inc
>    #
>    # Core Info
>    #
> -- 
> 2.18.0.windows.1
> 
> 
> 
> 

  reply	other threads:[~2019-05-16 20:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15  8:56 [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF Zhang, Shenglei
2019-05-15  8:56 ` [PATCH edk2-platforms 01/16] Platform/OverdriveBoard: Update DSC/FDF to use NetworkPkg's fragment file Zhang, Shenglei
2019-05-16 15:32   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 02/16] Platform/VExpressPkg: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-16 16:24   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 03/16] Hisilicon/D03: " Zhang, Shenglei
2019-05-16 16:41   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 04/16] Hisilicon/D05: " Zhang, Shenglei
2019-05-16 16:57   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 05/16] Hisilicon/D06: " Zhang, Shenglei
2019-05-16 17:02   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 06/16] Hisilicon/HiKey: " Zhang, Shenglei
2019-05-16 19:23   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 07/16] Hisilicon/HiKey960: " Zhang, Shenglei
2019-05-16 19:23   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 08/16] Platform/CelloBoard: " Zhang, Shenglei
2019-05-16 20:06   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 09/16] Platform/DeveloperBox: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-16 20:07   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 10/16] Platform/SynQuacerEvalBoard: " Zhang, Shenglei
2019-05-16 20:10   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 11/16] Platform/Overdrive1000Board: " Zhang, Shenglei
2019-05-16 20:11   ` Leif Lindholm [this message]
2019-05-15  8:56 ` [PATCH edk2-platforms 12/16] Silicon/Armada7k8k: Update DSC/FDF to use NetworkPkg's include " Zhang, Shenglei
2019-05-16 20:18   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:56 ` [PATCH edk2-platforms 13/16] Platform/SgiPkg: Update FDF " Zhang, Shenglei
2019-05-16 20:25   ` [edk2-devel] " Leif Lindholm
2019-05-17  6:01     ` Thomas Abraham
2019-05-15  8:56 ` [PATCH edk2-platforms 14/16] Platform/RDKQemu: Update DSC " Zhang, Shenglei
2019-05-16 20:27   ` [edk2-devel] " Leif Lindholm
2019-05-15  8:57 ` [PATCH edk2-platforms 15/16] Platform/Vlv2TbltDevicePkg: Update DSC/FDF to use NetworkPkg's " Zhang, Shenglei
2019-05-15  8:57 ` [PATCH edk2-platforms 16/16] Platform/PurleyOpenBoardPkg: " Zhang, Shenglei
2019-05-15 12:29 ` [edk2-devel] [PATCH edk2-platforms 00/16] Add Network's include segment files in DSC/FDF Liming Gao
2019-05-16 20:30 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516201116.7t5oodtzxac4xr2z@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox