From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=DiLVfLY3; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Thu, 16 May 2019 13:11:21 -0700 Received: by mail-wm1-f67.google.com with SMTP id y3so4855267wmm.2 for ; Thu, 16 May 2019 13:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XM68zUsV5s9Y1p5DWLwXL5Vi224g/kpZNByKDFM3DOU=; b=DiLVfLY37kLA9HaOT5up5fK3mPnhBC9bUQs9R2asvfHR4utcS2+s6tx7cnLvDJuSWV ID8CMRlok5TN9jsGmXGU7Er0I73eG7gnS/+7kLvbpYLYKNmJPC0yJfg90w3kzKJCGNLN DkG5cnXaGaneh5tBOwzE23fOyQqg5ShuBBRFBCUKbRbitb0PTJ1w1eL5/sAba/z73GSd zZczadlQSVj0ADYdCXXio+awFcVR2gXC4vcmuh+E5afSc0AlDUAcZWtjFUxmTZCpHdpZ u61jST9lPUKNRaMZ6yheLQ9wbn50hmj/ia3OucennW/UwOSL6g3R6xrYoJ9ZQQ+hLY6L 4dLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XM68zUsV5s9Y1p5DWLwXL5Vi224g/kpZNByKDFM3DOU=; b=fA10pElbygb4r71bRK5kBhu4Z3GZveEt+Q5wZfY0A61mRbNJwUijIKJY9dCuFkkngI EIR0ZkgCQhXtvSA5+VHu1v3NZf3BJP3KhHuKAlNkUtilOa+d6LFFvZ4Z5mEKuBy7Y1tl hTiETtZjOU75KV07ysWG7Kemoxwbta9PSRHvGCtv34DK3vb9TL/mrDkp2voA3BnHcF1p ASMmimjpn8ttdgV016CGkt7iBsQGHkGm2P9ufTxEp2x73nPhegVtGqmMp2ExUZ6Ubjlz vOT6oXCbprnZ0gW/QjPJUi4LuLDbTUP3hkecPson15hFtHsuaEImKYqtZB1sqUVHM9Uy AqxA== X-Gm-Message-State: APjAAAVPUoPpOoZfQdaB1D49AaS7ggTnZGr+M1zh1YxYATsPJFMFVPH3 xrrqtlcd8tdEcQTyPl/ABTdbj7G2b8A= X-Google-Smtp-Source: APXvYqx2qHSYA5cxed5m/INY0zBVa6lkkTMJRwaO94MqFgY2uDGxsjApl1UxySFGRa+09VjhxIAuCw== X-Received: by 2002:a7b:cb81:: with SMTP id m1mr30403050wmi.9.1558037478902; Thu, 16 May 2019 13:11:18 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z5sm6549487wmi.34.2019.05.16.13.11.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 13:11:17 -0700 (PDT) Date: Thu, 16 May 2019 21:11:16 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH edk2-platforms 11/16] Platform/Overdrive1000Board: Update DSC/FDF to use NetworkPkg's fragment file. Message-ID: <20190516201116.7t5oodtzxac4xr2z@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-12-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-12-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 04:56:56PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC/FDF files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang Reviewed-by: Leif Lindholm > --- > .../Overdrive1000Board/Overdrive1000Board.dsc | 27 +++++++------------ > .../Overdrive1000Board/Overdrive1000Board.fdf | 16 +---------- > 2 files changed, 10 insertions(+), 33 deletions(-) > > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index cc4f2facd0..3dc805921c 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -29,6 +29,14 @@ DEFINE NUM_CORES = 4 > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf > > + # > + # Network definition > + # > + DEFINE NETWORK_IP6_ENABLE = FALSE > + DEFINE NETWORK_TLS_ENABLE = FALSE > + DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > + DEFINE NETWORK_ISCSI_ENABLE = FALSE > + > ################################################################################ > # > # Library Class section - list of all Library Classes needed by this Platform. > @@ -75,11 +83,6 @@ DEFINE NUM_CORES = 4 > > BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > > - # Networking Requirements > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > # ARM Architectural Libraries > CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf > @@ -572,23 +575,11 @@ DEFINE NUM_CORES = 4 > # > # Networking stack > # > - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > -# MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > +!include NetworkPkg/Network.dsc.inc > MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf { > > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x21 > } > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > -## Bug https://bugs.linaro.org/show_bug.cgi?id=2239 > -# NetworkPkg/IScsiDxe/IScsiDxe.inf > > # > # Core Info > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf > index fa814880e0..6d7cfb3933 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.fdf > @@ -185,21 +185,7 @@ READ_LOCK_STATUS = TRUE > # > # Networking stack > # > - INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > - INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > -# INF MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf > - INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > -## Bug https://bugs.linaro.org/show_bug.cgi?id=2239 > -# INF NetworkPkg/IScsiDxe/IScsiDxe.inf > - > +!include NetworkPkg/Network.fdf.inc > # > # Core Info > # > -- > 2.18.0.windows.1 > > > >