From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=F2O+MfpM;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by groups.io with SMTP; Thu, 16 May 2019 13:26:02 -0700
Received: by mail-wm1-f66.google.com with SMTP id j187so4724087wmj.1
        for <devel@edk2.groups.io>; Thu, 16 May 2019 13:26:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=uKbEGjJc8r/ihaWOy4k/oW0zsbaEbK6HSk+IPzkEs0U=;
        b=F2O+MfpMgR7+mad84xO+106FA8ASPATHY7BLRCRy/wthSake2cu0LWdJ+/+sJyJgDA
         6EI8YKRHG9f0p12AiMTujAdgHrAIsEBVURkAYfpHETflDxszHDaTxpxH02nvs8Y5GhhZ
         u809KrHMoq/kEdsT1OMLPTcKXyEU1tWkCUhZTqde3K1CoMy2M5X6uHFc2ioXrX+iCzaO
         vm71fbMywBEknxDG5TqdGPTBKi9CL4V/Rn+D3pvZr43wZ+sIAAMnW6aOtBZDm0J+HNo9
         OEl62xKyMJhOj/os160jxKXU8x0VbklwwTO0s58gSKxV6GnLdifru9QgmPlOZy73pLjy
         tLKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=uKbEGjJc8r/ihaWOy4k/oW0zsbaEbK6HSk+IPzkEs0U=;
        b=fL4fAePwsNsierb9vLEMdnAFuocNJpEbdZxqtUvFP0y6Qd5jRAdVZXfqed0cZri3LP
         NeybrZnuL5rOtfYbN8epdPTINeTnZQgPl8edE69uyH9Au9QQZw16/oUSWEFtMro7+tu1
         01NR6a/igwzmfacHcLBJfVGz1l4birva+ELOJOJ1c00lNTyi7zUlxCHpDoiuoUTn2shd
         AAR3xvzkJjdX+1q+J3Tm2T1W6JSMzfYa3UT1ZmjopmycGVs5jq0rZ31aVWbsEAxton+B
         cWucavRUA+B/sZyOMHSlLC+9EheL16IPz/OadGwLLf1SSiHY/gLznjBUMRs4A5PMpHUM
         GKeQ==
X-Gm-Message-State: APjAAAUvY3FXBFCac9lfOGJ/juIPR/QzeTxgXDEhtZF9kGNuWddsfyqj
	8ch3g/0FTOmHxCWqpv8ksjSRORrWuYA=
X-Google-Smtp-Source: APXvYqxDGHNOmfO+uqSzTFUHQDQltsH0NRnlfVy/4/D+XRVK21mjx7U3D5/s5IZnOcpMDq8DiQZQ8g==
X-Received: by 2002:a7b:ce8c:: with SMTP id q12mr2255559wmj.34.1558038360775;
        Thu, 16 May 2019 13:26:00 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id w2sm4537082wrm.74.2019.05.16.13.25.59
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Thu, 16 May 2019 13:26:00 -0700 (PDT)
Date: Thu, 16 May 2019 21:25:58 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: ard.biesheuvel@linaro.org,
	Thomas Panakamattam Abraham <thomas.abraham@arm.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 13/16] Platform/SgiPkg: Update FDF to use NetworkPkg's include fragment file.
Message-ID: <20190516202558.m253nhsqplh4dsh3@bivouac.eciton.net>
References: <20190515085701.24724-1-shenglei.zhang@intel.com>
 <20190515085701.24724-14-shenglei.zhang@intel.com>
MIME-Version: 1.0
In-Reply-To: <20190515085701.24724-14-shenglei.zhang@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 15, 2019 at 04:56:58PM +0800, Zhang, Shenglei wrote:
> This patch updates the platform FDF files to use the include fragment
> files provided by NetworkPkg.
> 
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  Platform/ARM/SgiPkg/SgiPlatform.fdf | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> index b163dab5c3..93ea18ba18 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
> @@ -189,17 +189,7 @@ READ_LOCK_STATUS   = TRUE
>    #
>    # Networking stack
>    #
> -  INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
> -  INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
> -  INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
> -  INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
> -  INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
> -  INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
> -  INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
> -  INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> -  INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> -  INF NetworkPkg/TcpDxe/TcpDxe.inf
> -  INF NetworkPkg/IScsiDxe/IScsiDxe.inf
> +!include NetworkPkg/Network.fdf.inc

OK, so this is a little bit messy, but that is due to the include of
ArmVExpress.dsc.inc and how all that sticks together.

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

But Thomas, would you mind looking into aligning how the VExpress
config fragments used by various platforms in Platform/ARM interact
with these new NetworkPkg fragments, and try to clean up so the actual
function enabling/disabling happens per-platform?

/
    Leif

>  
>  !ifdef EDK2_ENABLE_SMSC_91X
>    INF EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
> -- 
> 2.18.0.windows.1
> 
> 
> 
>