From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ZcynYg6F; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Thu, 16 May 2019 13:27:44 -0700 Received: by mail-wr1-f65.google.com with SMTP id g12so4487387wro.8 for ; Thu, 16 May 2019 13:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v3ljG21+iEi2yrV3HPS4H/TnerFg7NxHC5AxAb3rW2k=; b=ZcynYg6FKqbGpyjRPR/T34zEykPp37VyIftBig40R5q2VV7vN3b0hcJ/fZhmcdKMtF YbJQmVQh9J4tFLjySE/2CJa8jDeL9tzu7gHwukcfKGwAIFGA4FoaPqI1NkBdwLLLaPEq ka6hjT1F9DN/g11xjh8cPadGmsQ50YhkL22U+ioYyQFZ2fPQz++EtF77mLLsjPDlvpG3 1krp2zZFmPuJzqYHSHTnt2XPXbgtS43nRIfdCoHn8m3G+pWHK1TTT/fI/0HvykztLKKd OQ+C1znwj65hSxi0BlXXCC0MG+hUoDyzMxDTpZgiRoa4TZHNuEswIHBO4u6HQIqwgu7O goqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v3ljG21+iEi2yrV3HPS4H/TnerFg7NxHC5AxAb3rW2k=; b=bU/amtvwTBnjLxfv5iXNZ7rWQxy8ZyupjUCz2o1nvd/EqJE0Mk30DcyL0MjPZJ1tGm vAVxzlMWm9kbsv5tUckZXtuNwNM4p2DiCoohVT8Y8iHt5Fts5ZNTA2tCm2zxH4jtd8/f zrJf12plOwt3xUFzCLmE60NWP409iTAVVYuwP6uoDbAzLyVSvLZNoxlXAHx31OhyafeG E1rTsP5rFyeGQXH/Zl6ogHBHiOPPeesullzxln2eEzc1SC6hx21wXYy6nplIUZAiHVEL Q+TvFdLy8DDrCGfaKO2TQpg00CoS0EFfFIT31Mw67br7mY/Nsirx8qUl7HT/Wws/yB4Z o5jw== X-Gm-Message-State: APjAAAUuy669E0B03UoiAj+p98L9Dt4tXBqSw5OYSRdHS7q4uDZcViwy kmimsfKp6HurA30o+Phv/TxvYb4D41M= X-Google-Smtp-Source: APXvYqzhQuhidkk1vtp1fgI36TyevPfOiLJHunUEewh1DNSTdwC0m8Hvhrhz/aEBBqNCC1W8RVTqbw== X-Received: by 2002:adf:fc51:: with SMTP id e17mr30694758wrs.243.1558038462455; Thu, 16 May 2019 13:27:42 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y132sm10221580wmd.35.2019.05.16.13.27.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 13:27:41 -0700 (PDT) Date: Thu, 16 May 2019 21:27:40 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [PATCH edk2-platforms 14/16] Platform/RDKQemu: Update DSC to use NetworkPkg's include fragment file. Message-ID: <20190516202740.ss5br7je436whdhw@bivouac.eciton.net> References: <20190515085701.24724-1-shenglei.zhang@intel.com> <20190515085701.24724-15-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190515085701.24724-15-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 15, 2019 at 04:56:59PM +0800, Zhang, Shenglei wrote: > This patch updates the platform DSC files to use the include fragment > files provided by NetworkPkg. > > Signed-off-by: Shenglei Zhang > --- > Platform/Comcast/RDKQemu/RDKQemu.dsc | 36 +++++++++------------------- > 1 file changed, 11 insertions(+), 25 deletions(-) > > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc > index f22f14aed9..ef4b1632ec 100644 > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc > @@ -33,8 +33,15 @@ > # Defines for default states. These can be changed on the command line. > # -D FLAG=VALUE > # > - DEFINE SECURE_BOOT_ENABLE = TRUE This whitespace change seems unnecessary to me. If you leave this line in the state it was before this patch: Reviewed-by: Leif Lindholm > - DEFINE HTTP_BOOT_ENABLE = TRUE > + DEFINE SECURE_BOOT_ENABLE = TRUE > + > + # > + # Network definition > + # > + DEFINE NETWORK_SNP_ENABLE = FALSE > + DEFINE NETWORK_TLS_ENABLE = FALSE > + DEFINE NETWORK_IP6_ENABLE = FALSE > + DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE > > !include ArmVirtPkg/ArmVirt.dsc.inc > > @@ -345,29 +352,8 @@ > # > # Networking stack > # > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > - NetworkPkg/TcpDxe/TcpDxe.inf > - NetworkPkg/IScsiDxe/IScsiDxe.inf > -!if $(NETWORK_IP6_ENABLE) == TRUE > - NetworkPkg/Ip6Dxe/Ip6Dxe.inf > - NetworkPkg/Udp6Dxe/Udp6Dxe.inf > - NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf > - NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf > -!endif > -!if $(HTTP_BOOT_ENABLE) == TRUE > - NetworkPkg/DnsDxe/DnsDxe.inf > - NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > - NetworkPkg/HttpDxe/HttpDxe.inf > - NetworkPkg/HttpBootDxe/HttpBootDxe.inf > -!endif > +!include NetworkPkg/Network.dsc.inc > + > # > # SCSI Bus and Disk Driver > # > -- > 2.18.0.windows.1 > > > >